27;s fine to mark it as
Committed where it is now.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
nning to leave Ready For Committer
till the end of the week, to make them more visible and let them get the
attention they deserve. And finally in the weekend I'll gather and share
some statistics.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russia
commitfest entry.
As far as I see, all recommendations from reviewers were addressed in
the last version of the patch.
It passes CFbot successfully, so I move it to Ready For Committer.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
is closed now and this entry is "Waiting on author".
As far as I see, part of the fixes is already committed. Is there
anything left to work on or this patch needs review/ ready for committer
now?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
" during this CF, so I've marked it as
returned with feedback. Feel free to resubmit an updated version to a
future commitfest.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
entry.
The patch is Waiting on Author for some time. As this is a bug fix, I am
moving it to the next CF.
Ian, are you planning to continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
://www.enterprisedb.com/
Status update for a commitfest entry.
The commitfest is closed now. As this entry is a bug fix, I am moving it
to the next CF.
Are you planning to continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
pdate for a commitfest entry.
The commitfest is closed now. As this entry has been Waiting on Author
for a while, I've marked it as returned with feedback. Dmitry, feel free
to resubmit an updated version to a future commitfest.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
On 30.10.2020 19:33, David G. Johnston wrote:
On Fri, Oct 30, 2020 at 9:16 AM Anastasia Lubennikova
mailto:lubennikov...@gmail.com>> wrote:
Status update for a commitfest entry.
It looks like there was no real progress on this issue since
April. I see only an experimental
On 02.12.2020 23:59, Tom Lane wrote:
Anastasia Lubennikova writes:
Commitfest 2020-11 is officially closed now.
Many thanks to everyone who participated by posting patches, reviewing
them, committing and sharing ideas in discussions!
Thanks for all the hard work!
Today, me and Georgios will
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
I wonder, why this patch hangs on commitfest for so long.
The idea o
ext format of
PostrgeSQL README files or we can use md?
[1] https://github.com/AmatanHead/psql-hooks/blob/master/Detailed.md
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
LID
5) Speaking of documentation, I think we need to add a paragraph about
CIC on partitioned indexes which will explain that invalid indexes may
appear and what user should do to fix them.
6) ReindexIndexesConcurrently() needs some code cleanup.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
LID
5) Speaking of documentation, I think we need to add a paragraph about
CIC on partitioned indexes which will explain that invalid indexes may
appear and what user should do to fix them.
6) ReindexIndexesConcurrently() needs some code cleanup.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
BTGreaterEqualStrategyNumber:
case BTGreaterStrategyNumber:
See the comment for RowCompareExpr, which states that "A RowCompareExpr
node is only generated for the < <= > >= cases".
2) It's worth to add a regression test for this feature.
Other than that, the patch look
Status update for a commitfest entry.
This patch is ReadyForCommitter. It applies and passes the CI. There are no
unanswered questions in the discussion.
The discussion started in 2015 with a patch by Jeff Janes. Later it was revived
by Pavan Deolasee. After it was picked up by Ibrar Ahmed an
update for a commitfest entry.
According to cfbot patch no longer applies. So I moved it to waiting on
author.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
opinion on the remaining patch, it still looks
good to me.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
ср, 28 окт. 2020 г. в 08:02, Yugo NAGATA :
> Hi Anastasia Lubennikova,
>
> I am writing this to you because I would like to ask the commitfest
> manager something.
>
> The status of the patch was changed to "Waiting on Author" from
> "Ready for Committer&q
Status update for a commitfest entry.
It looks like there was no real progress on this issue since April. I see only
an experimental patch. What kind of review does it need right now? Do we need
more testing or maybe production statistics for such queries?
David, are you going to continue worki
Status update for a commitfest entry.
I see quite a few unanswered questions in the thread since the last patch
version was sent. So, I move it to "Waiting on Author".
The new status of this patch is: Waiting on Author
patch review.
Also, check the state of your patch at http://cfbot.cputube.org/
Happy hacking!
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
OPY FREEZE and for matview operations. Can
you explain, what use-case are we trying to optimize by extending this
patch to heap_insert()?
The new version is attached.
I've also fixed a typo in the comment by Tatsuo Ishii suggestion.
Also, I tested this patch with replication and found no iss
Status update for a commitfest entry.
This thread was inactive for a while. Is anyone going to continue working on it?
My two cents on the topic:
I don’t see it as a big problem in the first place. In the source code, \dE
refers to foreign tables and \de refers to forign servers. So, it seems mo
Status update for a commitfest entry.
This patch implements useful improvement and the reviewer approved the code. It
lacks a test, but looking at previously committed hooks, I think it is not
mandatory.
So, I move it to RFC.
The new status of this patch is: Ready for Committer
Status update for a commitfest entry.
This entry was inactive for a very long time.
John, are you going to continue working on this?
The last message mentions some open issues, namely backend crashes, so I move
it to "Waiting on author".
The new status of this patch is: Waiting on Author
Status update for a commitfest entry.
This thread was inactive for a while. The latest review suggests that it is
Ready For Committer.
I also took a quick look at the patch and agree that it looks sensible. Maybe
add a comment before the _bt_compare_inl() to explain the need for this code
chang
Status update for a commitfest entry.
According to cfbot the patch no longer compiles.
Tomas, can you send an update, please?
I also see that a few last messages mention a data corruption bug. Sounds
pretty serious.
Alvaro, have you had a chance to look at it? I don't see anything committed
yet
Status update for a commitfest entry
According to cfbot, the patch fails to apply. Could you please send a rebased
version?
I wonder why this patch hangs so long without a review. Maybe it will help to
move discussion forward, if you provide more examples of queries that can
benefit from this
Status update for a commitfest entry.
According to CFbot this patch fails to apply. Richard, can you send an update,
please?
Also, I see that the thread was inactive for a while.
Are you going to continue this work? I think it would be helpful, if you could
write a short recap about current sta
Status update for a commitfest entry.
This thread was inactive for a while and from the latest messages, I see that
the patch needs some further work.
So I move it to "Waiting on Author".
The new status of this patch is: Waiting on Author
Assert(nappinfos >= 1 && appinfos != NULL);
+ /* If there's nothing to adjust, just return a duplication */
+ if (nappinfos == 0)
+ return copyObject(node);
5. extract_asymmetric_partitionwise_subjoin() lacks a comment
The new status of this patch is: Waiting on Au
he issue.
Do we only care about .sh scripts? There are also reindex_hash.sql and
pg_largeobject.sqlin src/bin/pg_upgrade/version.c with instructions.
How should we handle them?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
would be good to add a test to select_into.sql to show that it
only applies to 'WITH NO DATA' and that subsequent insertions will fail
if permissions are not set.
Maybe we should also mention it a documentation, but I haven't found any
specific paragraph about permission
considered stalled and returned with feedback.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
quot;. Feel free to create a new
entry, if you're going to continue working on the remaining issue.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
s. It looks like a
bullet-proof solution to me. Do you see any possible problems with it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
ut
create domain and create type I'll just stick to the implementation in
front of me.
David J.
Reminder from a CF manager, as this thread was inactive for a while.
Alexander, I see you signed up as a committer for this entry. Are you
going to continue this work?
--
Anastasia Lubennikova
Postgres
On 23.11.2020 18:35, Stephen Frost wrote:
Greetings,
* Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote:
On 21.11.2020 04:30, Michael Paquier wrote:
The only method I can think as being really
reliable is based on two facts:
- Do a check only on pd_checksums, as that validates the
quot;Waiting on author".
Euler, are you going to continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
If there aren't any objections or further comments, I'll take another
look through it and will commit it during the upcoming CF.
Thanks!
Stephen
CFM reminder. Just in case you forgot about this thread)
The commitfest is heading to the end. And there was a plenty of time for
anyone
rg/message-id/flat/9df8a3d3-13d2-116d-26ab-6a273c1ed38c%402ndquadrant.com
Since there has been no activity on this thread since before the CF and
no response from the author I have marked this "returned with feedback".
Alexandra, feel free to resubmit it to the next commitfest
se */
}
}
which will be called like
swap_lsn(XLogCtl->LogwrtRqst.Write, EndPos, true);
Greetings,
Andres Freund
This CF entry was inactive for a while. Alvaro, are you going to
continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
this entry is "Waiting on Author" and the thread was inactive for a
while. I see this discussion still has some open questions. Are you
going to continue working on it, or should I mark it as "returned with
feedback" until a better time?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
back" until a better time?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
_TABLESPACE <https://commitfest.postgresql.org/30/2269/>
range_agg / multiranges <https://commitfest.postgresql.org/30/2112/>
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
me as other contrib modules do.
Agree. It will need a bit more work, though. Probably a new version of
pageinspect contrib, as the public API will change.
Ashutosh, are you going to continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Ru
t know where we
should document it. At the very least we can improve comments. For
example, describe the fact that custom signals are handled after
receiving SIGUSR1.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
am not sure
it will be stable given that the RemovePgTempFiles() allows the
possibility of failure.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
commit 417581b287f4060178595cd96465adc639639290
Author: anastasia
Date: Thu Nov 26 11:45:05 2020 +030
.
This entry is "Waiting on author" and the thread was inactive for a
while. As far as I see, part of the fixes is already committed. Is
there anything left to work on or this patch set needs review now?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
On 02.11.2020 22:08, John Naylor wrote:
On Mon, Nov 2, 2020 at 1:30 PM Alvaro Herrera <mailto:alvhe...@alvh.no-ip.org>> wrote:
On 2020-Nov-02, Anastasia Lubennikova wrote:
> Status update for a commitfest entry.
>
> This entry was inactive for a very lon
n of the patch. Does it need more work? Are
you going to continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
atch still applies and passes all cfbot checks. I also took a quick
look at the code and everything looks good to me.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
r
This patch was inactive during the commitfest, so I am going to mark it
as "Returned with Feedback".
Fabien, are you planning to continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
, which
seems unlikely.).
regards.
Status update for a commitfest entry.
This entry was "Waiting on author" during this CF. As I see, the latest
message contains new version of the patch.
Does it need more work? Are you going to continue working on it?
--
Anastasia Lubennikova
Post
work before review, so I changed it to "Withdrawn".
Feel free to resubmit an updated version to a future commitfest.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
On 02.11.2020 18:02, Anastasia Lubennikova wrote:
Status update for a commitfest entry.
This thread was inactive for a while. Is anyone going to continue working on it?
My two cents on the topic:
I don’t see it as a big problem in the first place. In the source code, \dE
refers to foreign
obably for the next CF. Can you park it
there?
Sure, I'll move it to the next CF then.
I also noticed, that the first message mentions the idea of refactoring
to use some code it in both pgbench and psql code. Can you, please,
share a link to the thread, if it exists?
--
Anastasia Luben
e proposed idea is
great and it looks like the patch needs only a minor improvement.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
On 09.11.2020 13:53, Anastasia Lubennikova wrote:
On 21.08.2020 09:02, Andrey V. Lepikhov wrote:
On 7/1/20 2:10 PM, Daniel Gustafsson wrote:
On 27 Dec 2019, at 08:34, Kohei KaiGai wrote:
The attached v2 fixed the problem, and regression test finished
correctly.
This patch no longer
varo, are you planning to
continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
please share your concerns about the interaction of the
patch with --binary-upgrade mode? If you don't have time to write tests,
you can just describe problems.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
entry.
The commitfest is nearing the end and this thread is "Waiting on
Author". As far as I see we don't have a patch here and discussion is a
bit stuck.
So, I am planning to return it with feedback. Any objections?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Status update for a commitfest entry.
The commitfest is nearing the end and this thread was inactive for a while. As
far as I see something got committed and now the discussion is stuck in arguing
about parenthesis.
FWIW, I think it is a matter of personal taste. Maybe we can compromise on
simp
Status update for a commitfest entry.
The commitfest is nearing the end and I wonder what is this discussion waiting
for.
It looks like the proposed patch received its fair share of review, so I mark
it as ReadyForCommitter and lay responsibility for the final decision on them.
The new status o
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:tested, passed
I wonder, why this patch didn't get a review during the CF.
This minor im
test it properly in a couple of days and share results.
With this change a lot of new code is repeated in heap_insert() and
heap_multi_insert(). I think it's fine, because these functions already
have a lot in common.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgr
On 12.01.2021 00:51, Tomas Vondra wrote:
On 1/11/21 10:00 PM, Anastasia Lubennikova wrote:
On 11.01.2021 01:35, Tomas Vondra wrote:
Hi,
I started looking at this patch again, hoping to get it committed in
this CF, but I think there's a regression in handling TOAST tables
(compared t
strapping or in a recently-started system.
*/
if (targetBlock == InvalidBlockNumber)
{
BlockNumber nblocks = RelationGetNumberOfBlocks(relation);
if (nblocks > 0)
targetBlock = nblocks - 1;
}
I think we can use this code without regard to '
On 03.01.2021 14:29, Noah Misch wrote:
On Thu, Jun 11, 2020 at 07:58:43PM +0300, Anastasia Lubennikova wrote:
On 08.06.2020 19:31, Alvaro Herrera wrote:
I'm thinking what's a good way to have a test that's committable. Maybe
it would work to add a TAP test to pg_upgrade that ru
On 24.01.2021 11:39, Noah Misch wrote:
On Thu, Jan 21, 2021 at 01:03:58AM +0300, Anastasia Lubennikova wrote:
On 03.01.2021 14:29, Noah Misch wrote:
Overall, this patch predicts a subset of cases where pg_dump will emit a
failing GRANT or REVOKE that targets a pg_catalog object. Can you write
_vWAu8_Hh7gfVFcr3%2BR7ocdLvYOWJXg%40mail.gmail.com
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
commit 71bdcd268386c4240613b080b9ebd5ae935c1405
Author: anastasia
Date: Thu Jul 23 17:55:16 2020 +0300
WIP Fix root_offsets out of bound erro
On 23.07.2020 20:39, Anastasia Lubennikova wrote:
One of our clients caught an error "failed to find parent tuple for
heap-only tuple at (50661,130) in table "tbl'" in PostgreSQL v12.
Steps to reproduce (REL_12_STABLE):
1) Create table with primary key, create brin in
On 27.07.2020 20:25, Alvaro Herrera wrote:
On 2020-Jul-27, Anastasia Lubennikova wrote:
Here is the updated version of the fix.
The problem can be reproduced on all supported versions, so I suggest to
backpatch it.
Code slightly changed in v12, so here are two patches: one for versions 9.5
to
On 31.07.2020 23:28, Robert Haas wrote:
On Tue, Jul 14, 2020 at 1:51 PM Anastasia Lubennikova
wrote:
Questions from the first review pass:
1) Do we need XLH_INSERT_ALL_VISIBLE_SET ? IIUC, in the patch it is always
implied by XLH_INSERT_ALL_FROZEN_SET.
I agree that it looks unnecessary to
On 30.07.2020 16:40, Anastasia Lubennikova wrote:
While testing this fix, Alexander Lakhin spotted another problem.
After a few runs, it will fail with "ERROR: corrupted BRIN index:
inconsistent range map"
The problem is caused by a race in page locking in
brinGetTupleForHe
t there, though.
Anyway, I'm going to remove that Assert() I added.
So this is what I propose as the final form of the fix.
Cool.
This version looks much simpler than mine and passes the tests fine.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
s patch first, he said this was only for
heap_multi_insert because it was a prototype. But I think we expect
that the table_insert path (CIM_SINGLE mode in copy) should also receive
that treatment.
I am afraid that extra checks for COPY FREEZE in heap_insert() will
slow down normal inserti
On 14.07.2020 00:11, Anastasia Lubennikova wrote:
On 06.07.2020 13:45, Anastasia Lubennikova wrote:
The previous discussion of automatic partition creation [1] has
addressed static and dynamic creation of partitions and ended up with
several syntax proposals.
In this thread, I want to
On 21.08.2020 19:43, Ibrar Ahmed wrote:
On Wed, Aug 19, 2020 at 6:15 PM Anastasia Lubennikova
mailto:a.lubennik...@postgrespro.ru>>
wrote:
On 18.08.2020 02:54, Alvaro Herrera wrote:
> On 2020-Aug-14, Ibrar Ahmed wrote:
>
>> The table used for the test cont
ing_spgist.sql and
index_including.sql tests are stable without running 'vacuum analyze'
before the EXPLAIN that shows Index Only Scan plan. Is autovacuum just
always fast enough to fill a visibility map, or I miss something?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
them?
+ &multixact_local_cache_entries,
+ 256, 2, INT_MAX / 2,
2.2) MAX_CACHE_ENTRIES is not used anymore, so it can be deleted.
3) No changes for third patch. I just renamed it for consistency.
--
Anastasia Lubennikova
Postgres Professional: htt
X_REL_PROCESS_TOAST) && OidIsValid(toast_relid))
result |= reindex_relation(toast_relid, flags, options);
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
understand the logic around index list
check at first pass.
Does the version attached look fine to you? I have done one round of
indentation while on it.
Yes, this version is good.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
roof. Using it we can also check pages with lsn >=
startptr.
3) Judging by warning messages, we count checksum failures per file, not
per page, and don't report after a fifth failure. Why so? Is it a
common case that so many pages of one file are corrupted?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
se, it would be
good to document this behavior explicitly.
I need a bit more time to review this patch more thoroughly. Please,
wait for it, before committing.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
oesn't get lost.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
reindex_partitions() and new comments
added, I think this patch is ready for commit.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
hing, because no matter how many items were compressed we still
rewrite
all items from the original page to the new one, so, why not do our best.
What do we save by this incremental approach?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
10.09.2019 14:42, Asim R P wrote:
Hi Anastasia
On Thu, Aug 22, 2019 at 9:43 PM Anastasia Lubennikova
mailto:a.lubennik...@postgrespro.ru>>
wrote:
>
> But during the review, I found a bug in the current implementation.
> New behavior must apply to crash-recovery only, no
-+-+++
| checkpoints_req | 16 | 7 | 8 | 10 |
+-+-+-+++
And I struggle to explain the reason of this.
Do you understand what can cause the difference?
--
Anastasia Lubennikova
16.09.2019 21:58, Peter Geoghegan wrote:
On Mon, Sep 16, 2019 at 8:48 AM Anastasia Lubennikova
wrote:
I tested patch with nbtree_wal_test, and found out that the real issue is
not the dedup WAL records themselves, but the full page writes that they
trigger.
Here are test results (config is
this information somewhere but rel->rd_options,
while we can easily access this field from _bt_findinsertloc() and
_bt_load().
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtre
4, float8.
Does anyarray opclasses need special treatment?
New syntax for create opclass is "CREATE OPERATOR CLASS NOT BITWISE ..."
Any ideas on better names?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
commit 5916d188be1cfff798845
d multiple versions.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
commit dc6d9246c6255bed2bdb2e850a21bb1fc5e0c2fc
Author: Anastasia
Date: Fri Oct 4 14:39:54 2019 +0300
pg_upgrade_ACL_check_v2
diff --git a/src/bin/pg_upgrade/check.c
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Hi,
thank you for your work on this patch.
Patch #1 is ready
08.07.2019 4:18, Thomas Munro:
The July Commitfest is here. Could we please have a rebase of this patch?
Updated patch is in attachments.
I've only resolved one small cosmetic merge conflict.
Later this week I'm going to send a more thoughtful review.
--
Anastasia Lubennikov
23.07.2019 14:36, Anastasia Lubennikova :
08.07.2019 4:18, Thomas Munro:
The July Commitfest is here. Could we please have a rebase of this
patch?
Updated patch is in attachments.
I've only resolved one small cosmetic merge conflict.
Later this week I'm going to send a more thought
duce it.
The explanation I see is that page had DEAD items, but for some reason
BTP_HAS_GARBAGE was not set so _bt_vacuum_one_page() was not called.
I find it difficult to understand what could lead to this situation,
so probably we need to inspect it closer to exclude the possibility of a
bug.
-
;new') q where
txtsample @@ q;
So I also added another test to tsearch.sql to illustrate difference
between optimized and not optimized plans.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
diff --git a/src/backend/optimizer/pl
1 - 100 of 180 matches
Mail list logo
