Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

2018-02-22 Thread Nikolay Shaplov
В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал: > I think we should split this in at least two commits, I've added a third part of this patch to commitfest: https://www.postgresql.org/message-id/flat/2083183.Rn7qOxG4Ov@x200m#2083183.Rn7qOxG4Ov@x200m To finally commit the

Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

2018-01-21 Thread Nikolay Shaplov
В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал: > I think we should split this in at least two commits, Added another part for commit: https://www.postgresql.org/message-id/43332102.S2V5pIjXRx@x200m This one adds an enum relation option type. -- Do code for fun.

Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

2018-01-17 Thread Nikolay Shaplov
В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал: > The new checks around toast table creation look like they belong to a > completely independent patch also ... the error message there goes > against message style guidelines also. Offered toast relation checks as a

Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

2017-11-27 Thread Nikolay Shaplov
В письме от 28 ноября 2017 11:23:38 пользователь Michael Paquier написал: > On Tue, Nov 28, 2017 at 11:22 AM, Michael Paquier > > wrote: > > On Tue, Nov 14, 2017 at 4:44 PM, Michael Paquier > > > > wrote: > >> On Mon, Oct 30, 2017 at 9:49

Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

2017-11-27 Thread Michael Paquier
On Tue, Nov 28, 2017 at 11:22 AM, Michael Paquier wrote: > On Tue, Nov 14, 2017 at 4:44 PM, Michael Paquier > wrote: >> On Mon, Oct 30, 2017 at 9:49 AM, Nikolay Shaplov wrote: >>> В письме от 3 сентября 2017 11:45:43

Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

2017-11-13 Thread Michael Paquier
On Mon, Oct 30, 2017 at 9:49 AM, Nikolay Shaplov wrote: > В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал: > > Yet another git rebase. This patch can be applied to master branch again. > > For this patch no review needed now, as I will offer part of it