Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

2018-02-18 Thread Michael Paquier
On Sat, Feb 17, 2018 at 07:17:24PM -0300, Alvaro Herrera wrote: > Pushed 0003. Thanks. > Maybe we can get rid of format_type_be_qualified too, but I didn't > care too much about it either; it's not a big deal I think. Agreed. There are 16 callers spread in objectaddress.c and regproc.c, this wo

Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

2018-02-17 Thread Alvaro Herrera
Michael Paquier wrote: > > As far as format_type_extended() is concerned, IMO we've gone far enough > > with the number of variants of format_type(). Making the function > > public makes sense to me, but let's add a bits32 flags argument instead > > of exposing the messy set of booleans. We can

Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

2018-02-12 Thread Alvaro Herrera
Michael Paquier wrote: > On Fri, Jan 12, 2018 at 11:01:59AM +0900, Michael Paquier wrote: > > Thanks Mr. Robot and Thomas for the reminder. Attached is an updated > > patch set taking care of those warnings, 0002 and 0004 being impacted. > > The last patch set has rotten enough for git am to compl

Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

2018-01-11 Thread Thomas Munro
On Mon, Nov 27, 2017 at 1:01 AM, Michael Paquier wrote: > On Fri, Nov 24, 2017 at 9:13 PM, Michael Paquier > wrote: >> Attached is a rebased patch set. Álvaro, as you have introduced most >> of the problems with 4464303 & friends dated of 2015 when you >> introduced get_object_address(), could yo

Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

2017-11-26 Thread Michael Paquier
On Fri, Nov 24, 2017 at 9:13 PM, Michael Paquier wrote: > Attached is a rebased patch set. Álvaro, as you have introduced most > of the problems with 4464303 & friends dated of 2015 when you > introduced get_object_address(), could you look at this patch set? Moved to next commit fest. -- Michae