Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-05-10 Thread Noah Misch
On Wed, May 08, 2019 at 10:10:35PM +1200, Thomas Munro wrote: > On Mon, May 6, 2019 at 3:30 PM Thomas Munro wrote: > > I put the second sentence back and tweaked it thus: s/fails/might > > fail/. Maybe I'm being too pedantic here, but binding to 127.0.0.2 > > works on other OSes too, as long as y

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-05-08 Thread Thomas Munro
On Mon, May 6, 2019 at 3:30 PM Thomas Munro wrote: > I put the second sentence back and tweaked it thus: s/fails/might > fail/. Maybe I'm being too pedantic here, but binding to 127.0.0.2 > works on other OSes too, as long as you've configured an interface or > alias for it (and it's not terribly

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-05-05 Thread Thomas Munro
On Wed, May 1, 2019 at 12:57 PM Noah Misch wrote: > On Tue, Apr 30, 2019 at 10:47:37PM +1200, Thomas Munro wrote: > > --- a/src/test/perl/PostgresNode.pm > > +++ b/src/test/perl/PostgresNode.pm > > @@ -1098,17 +1098,12 @@ sub get_new_node > > # native Perl (https://stackoverflow.co

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-30 Thread Noah Misch
On Tue, Apr 30, 2019 at 10:47:37PM +1200, Thomas Munro wrote: > On Mon, Apr 22, 2019 at 4:59 AM Noah Misch wrote: > > On Thu, Apr 18, 2019 at 04:30:46PM +1200, Thomas Munro wrote: > > > This causes make check-world to deliver a flurry of pop-ups from > > > macOS's built-in Firewall asking if perl

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-28 Thread Noah Misch
On Fri, Mar 29, 2019 at 09:53:51AM +, Daniel Gustafsson wrote: > On Saturday, March 9, 2019 8:16 AM, Noah Misch wrote: > > I tested on Red Hat and on Windows Server 2016; I won't be shocked > > if the test (not the code under test) breaks on other Windows > > configurations. > > IIRC there a

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-21 Thread Noah Misch
On Thu, Apr 18, 2019 at 04:30:46PM +1200, Thomas Munro wrote: > On Thu, Apr 11, 2019 at 6:22 PM Noah Misch wrote: > > - my $iaddr = inet_aton($test_localhost); > > + my $iaddr = inet_aton('0.0.0.0'); > > This causes make check-world to deliver a flurry

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-17 Thread Thomas Munro
On Thu, Apr 11, 2019 at 6:22 PM Noah Misch wrote: > - my $iaddr = inet_aton($test_localhost); > + my $iaddr = inet_aton('0.0.0.0'); This causes make check-world to deliver a flurry of pop-ups from macOS's built-in Firewall asking if perl should be allo

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-10 Thread Noah Misch
On Thu, Apr 11, 2019 at 12:48:35PM +1200, Thomas Munro wrote: > On Mon, Apr 8, 2019 at 6:42 PM Noah Misch wrote: > > - AIX animals failed two ways. First, I missed a "use" statement such that > > poll_start() would fail if it needed more than one attempt. Second, I > > assumed $pid would be

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-10 Thread Thomas Munro
On Mon, Apr 8, 2019 at 6:42 PM Noah Misch wrote: > - AIX animals failed two ways. First, I missed a "use" statement such that > poll_start() would fail if it needed more than one attempt. Second, I > assumed $pid would be gone as soon as kill(9, $pid) returned[1]. > [1] POSIX says "sig or a

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-08 Thread Noah Misch
On Mon, Apr 08, 2019 at 08:07:28PM +1200, Thomas Munro wrote: > On Mon, Apr 8, 2019 at 6:42 PM Noah Misch wrote: > > - lorikeet's FailedAssertion("!(vmq->mq_sender == ((void *)0))" looked > > suspicious, but this happened six other times in the past year[2], always > > on > > v10 lorikeet. >

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-08 Thread Thomas Munro
On Mon, Apr 8, 2019 at 6:42 PM Noah Misch wrote: > - lorikeet's FailedAssertion("!(vmq->mq_sender == ((void *)0))" looked > suspicious, but this happened six other times in the past year[2], always on > v10 lorikeet. It happens on v11 too: https://buildfarm.postgresql.org/cgi-bin/show_log.pl

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-07 Thread Noah Misch
On Thu, Apr 04, 2019 at 07:53:19AM -0700, Noah Misch wrote: > On Wed, Apr 03, 2019 at 07:05:43PM -0700, Noah Misch wrote: > > Pushed, but that broke two buildfarm members: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=idiacanthus&dt=2019-04-04%2000%3A33%3A14 > > https://buildfarm.post

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-04 Thread Noah Misch
On Wed, Apr 03, 2019 at 07:05:43PM -0700, Noah Misch wrote: > On Mon, Apr 01, 2019 at 08:19:56AM +, Daniel Gustafsson wrote: > > On Monday, April 1, 2019 12:42 AM, Noah Misch wrote: > > > On Fri, Mar 29, 2019 at 09:53:51AM +, Daniel Gustafsson wrote: > > > > > > This seems like a case whe

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-03 Thread Noah Misch
On Mon, Apr 01, 2019 at 08:19:56AM +, Daniel Gustafsson wrote: > On Monday, April 1, 2019 12:42 AM, Noah Misch wrote: > > On Fri, Mar 29, 2019 at 09:53:51AM +, Daniel Gustafsson wrote: > > > > This seems like a case where it would be useful to log a shmdt() error or > > > do > > > an Ass

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-04-01 Thread Daniel Gustafsson
On Monday, April 1, 2019 12:42 AM, Noah Misch wrote: > On Fri, Mar 29, 2019 at 09:53:51AM +, Daniel Gustafsson wrote: > > This seems like a case where it would be useful to log a shmdt() error or do > > an Assert() around the success of the operation perhaps? > > I'll add the same elog(LOG) w

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-03-31 Thread Noah Misch
On Fri, Mar 29, 2019 at 09:53:51AM +, Daniel Gustafsson wrote: > On Saturday, March 9, 2019 8:16 AM, Noah Misch wrote: > > I renamed IpcMemoryAnalyze() to PGSharedMemoryAttach() and deleted the old > > function of that name. Now, this function never calls shmdt(); the caller is > > responsible

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-03-29 Thread Daniel Gustafsson
On Saturday, March 9, 2019 8:16 AM, Noah Misch wrote: This patch is not really in my wheelhouse, so I might very well be testing it in the wrong way, but whats the fun in staying in shallow end. Below is my attempt at reviewing this patchset. Both patches applies with a little bit of fuzz, and p

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-03-08 Thread Noah Misch
On Wed, Mar 06, 2019 at 07:24:22PM -0800, Noah Misch wrote: > On Mon, Mar 04, 2019 at 06:04:20PM +0900, Kyotaro HORIGUCHI wrote: > > PGSharedMemoryCreate changed to choose a usable shmem id using > > the IpcMemoryAnalyze(). But some of the statuses from > > IpcMemoryAnalyze() is concealed by failu

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-03-06 Thread Noah Misch
On Mon, Mar 04, 2019 at 06:04:20PM +0900, Kyotaro HORIGUCHI wrote: > I found that I have 65(h) segments left alone on my environment:p Did patched PostgreSQL create those, or did unpatched PostgreSQL create them? > At Sat, 11 Aug 2018 23:48:15 -0700, Noah Misch wrote in > <20180812064815.gb2301

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-03-04 Thread Kyotaro HORIGUCHI
Hello. At Sun, 2 Dec 2018 16:41:06 -0800, Noah Misch wrote in <20181203004106.ga2860...@rfd.leadboat.com> > On Thu, Nov 29, 2018 at 10:51:40PM -0800, Noah Misch wrote: > > On Thu, Nov 29, 2018 at 01:10:57PM +0100, Dmitry Dolgov wrote: > > > As a side note, with this patch recovery tests are fail

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-02-01 Thread Michael Paquier
On Sun, Dec 02, 2018 at 04:41:06PM -0800, Noah Misch wrote: > Here's a version fixing that test for post-cfdf4dc backends. This patch set still applies and needs review, so moved to next CF. -- Michael signature.asc Description: PGP signature

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2018-12-02 Thread Noah Misch
On Thu, Nov 29, 2018 at 10:51:40PM -0800, Noah Misch wrote: > On Thu, Nov 29, 2018 at 01:10:57PM +0100, Dmitry Dolgov wrote: > > As a side note, with this patch recovery tests are failing now on 016_shm.pl > > > > # Failed test 'detected live backend via shared memory' > > # at t/016_shm.pl li

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2018-11-29 Thread Noah Misch
On Thu, Nov 29, 2018 at 01:10:57PM +0100, Dmitry Dolgov wrote: > On Sun, Aug 12, 2018 at 8:48 AM Noah Misch wrote: > > With 9.3 having a few months left, that's less interesting, but ... > I'm a bit out of context, but taking into account that 9.3 is already beyond > EOL, is it still interesting?

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2018-11-29 Thread Dmitry Dolgov
> On Sun, Aug 12, 2018 at 8:48 AM Noah Misch wrote: > > On Wed, Sep 11, 2013 at 10:28:00PM -0400, Noah Misch wrote: > > On Wed, Sep 11, 2013 at 11:32:01AM -0400, Stephen Frost wrote: > > > * Noah Misch (n...@leadboat.com) wrote: > > > > Concretely, that means > > > > not removing postmaster.pid on

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2018-08-11 Thread Noah Misch
On Wed, Sep 11, 2013 at 10:28:00PM -0400, Noah Misch wrote: > On Wed, Sep 11, 2013 at 11:32:01AM -0400, Stephen Frost wrote: > > * Noah Misch (n...@leadboat.com) wrote: > > > Concretely, that means > > > not removing postmaster.pid on immediate shutdown in 9.3 and earlier. > > > That's > > > cons