Re: [HACKERS] plpgsql - additional extra checks

Committed, with some minor changes: > > 1) The too_many_rows check in exec_stmt_execsql included the errhint > conditionally, depending on force_error variable > > force_error = stmt->strict || stmt->mod_stmt; > use_errhint = !force_error; > > That is, the hint was not included when

Re: [HACKERS] plpgsql - additional extra checks

On 07/22/2018 10:24 PM, Tomas Vondra wrote: > > > On 07/19/2018 02:50 PM, Pavel Stehule wrote: >> >> >> 2018-07-15 1:38 GMT+02:00 Tomas Vondra > >: >> >> Hi, >> >> I've been looking at the version submitted on Thursday, planning to >> commit it,

Re: [HACKERS] plpgsql - additional extra checks

On 07/19/2018 02:50 PM, Pavel Stehule wrote: > > > 2018-07-15 1:38 GMT+02:00 Tomas Vondra >: > > Hi, > > I've been looking at the version submitted on Thursday, planning to > commit it, but I think it needs a wee bit more work on the error >

Re: [HACKERS] plpgsql - additional extra checks

2018-07-15 1:38 GMT+02:00 Tomas Vondra : > Hi, > > I've been looking at the version submitted on Thursday, planning to > commit it, but I think it needs a wee bit more work on the error messages. > > 1) The example in sgml docs does not work, because it's missing a > semicolon after the CREATE

Re: [HACKERS] plpgsql - additional extra checks

Hi, I've been looking at the version submitted on Thursday, planning to commit it, but I think it needs a wee bit more work on the error messages. 1) The example in sgml docs does not work, because it's missing a semicolon after the CREATE FUNCTION. And the output was not updated after tweaking

Re: [HACKERS] plpgsql - additional extra checks

Hi 2018-07-09 21:44 GMT+02:00 Alvaro Herrera : > > + ereport(errlevel, > > (errcode(ERRCODE_TOO_MANY_ > ROWS), > >errmsg("query returned > more than one row"), > > -

Re: [HACKERS] plpgsql - additional extra checks

2018-07-09 21:44 GMT+02:00 Alvaro Herrera : > > + ereport(errlevel, > > (errcode(ERRCODE_TOO_MANY_ > ROWS), > >errmsg("query returned > more than one row"), > > -

Re: [HACKERS] plpgsql - additional extra checks

On 2018-07-09 15:44:36 -0400, Alvaro Herrera wrote: > > + ereport(errlevel, > > (errcode(ERRCODE_TOO_MANY_ROWS), > > errmsg("query returned more > > than one row"), > > -

Re: [HACKERS] plpgsql - additional extra checks

On 07/03/2018 03:45 PM, Tomas Vondra wrote: > On 03/20/2018 01:35 PM, Tomas Vondra wrote: >> >> >> On 03/20/2018 05:36 AM, Pavel Stehule wrote: >>> >>> >>> 2018-03-19 21:47 GMT+01:00 Tomas Vondra >> >: >>> >>> Hi, >>> >>> I'm looking at the updated

Re: [HACKERS] plpgsql - additional extra checks

2018-03-20 13:56 GMT+01:00 Tels : > Hello Pavel and Tomas, > > On Tue, March 20, 2018 12:36 am, Pavel Stehule wrote: > > 2018-03-19 21:47 GMT+01:00 Tomas Vondra : > > > >> Hi, > >> > >> I'm looking at the updated patch

Re: [HACKERS] plpgsql - additional extra checks

Hello Pavel and Tomas, On Tue, March 20, 2018 12:36 am, Pavel Stehule wrote: > 2018-03-19 21:47 GMT+01:00 Tomas Vondra : > >> Hi, >> >> I'm looking at the updated patch (plpgsql-extra-check-180316.patch), and >> this time it applies and builds OK. The one thing I

Re: [HACKERS] plpgsql - additional extra checks

On 03/20/2018 05:36 AM, Pavel Stehule wrote: > > > 2018-03-19 21:47 GMT+01:00 Tomas Vondra >: > > Hi, > > I'm looking at the updated patch (plpgsql-extra-check-180316.patch), and > this time it applies and

Re: [HACKERS] plpgsql - additional extra checks

2018-03-19 21:47 GMT+01:00 Tomas Vondra : > Hi, > > I'm looking at the updated patch (plpgsql-extra-check-180316.patch), and > this time it applies and builds OK. The one thing I noticed is that the > documentation still uses the old wording for

Re: [HACKERS] plpgsql - additional extra checks

Hi, I'm looking at the updated patch (plpgsql-extra-check-180316.patch), and this time it applies and builds OK. The one thing I noticed is that the documentation still uses the old wording for strict_multi_assignement: WARNING: Number of evaluated fields does not match expected. HINT:

Re: [HACKERS] plpgsql - additional extra checks

2018-03-16 2:46 GMT+01:00 Tomas Vondra : > On 03/04/2018 07:07 PM, Pavel Stehule wrote: > > > > ... > > > > I am sending updated patch with Tomas changes > > > > Seems 2cf8c7aa48 broke this patch, as it tweaked a number of regression > tests. Other than that, I think

Re: [HACKERS] plpgsql - additional extra checks

On 03/04/2018 07:07 PM, Pavel Stehule wrote: > > ... > > I am sending updated patch with Tomas changes > Seems 2cf8c7aa48 broke this patch, as it tweaked a number of regression tests. Other than that, I think the patch is pretty much ready. One minor detail is that this bit from

Re: [HACKERS] plpgsql - additional extra checks

2018-03-04 13:37 GMT+01:00 Pavel Stehule : > > > 2018-03-04 2:46 GMT+01:00 Tomas Vondra : > >> On 03/02/2018 10:30 PM, Pavel Stehule wrote: >> > Hi >> > >> > 2018-03-01 21:14 GMT+01:00 David Steele > >

Re: [HACKERS] plpgsql - additional extra checks

2018-03-04 2:46 GMT+01:00 Tomas Vondra : > On 03/02/2018 10:30 PM, Pavel Stehule wrote: > > Hi > > > > 2018-03-01 21:14 GMT+01:00 David Steele > >: > > > > Hi Pavel, > > > > On 1/7/18 3:31 AM, Pavel Stehule

Re: [HACKERS] plpgsql - additional extra checks

On 03/02/2018 10:30 PM, Pavel Stehule wrote: > Hi > > 2018-03-01 21:14 GMT+01:00 David Steele >: > > Hi Pavel, > > On 1/7/18 3:31 AM, Pavel Stehule wrote: > > > >     There, now it's in the correct Waiting for Author state. :) >

Re: Re: [HACKERS] plpgsql - additional extra checks

Hi 2018-03-01 21:14 GMT+01:00 David Steele : > Hi Pavel, > > On 1/7/18 3:31 AM, Pavel Stehule wrote: > > > > There, now it's in the correct Waiting for Author state. :) > > > > thank you for comments. All should be fixed in attached patch > > This patch no longer applies

Re: Re: [HACKERS] plpgsql - additional extra checks

Hi Pavel, On 1/7/18 3:31 AM, Pavel Stehule wrote: > > There, now it's in the correct Waiting for Author state. :) > > thank you for comments. All should be fixed in attached patch This patch no longer applies (and the conflicts do not look trivial). Can you provide a rebased patch? $ git

Re: [HACKERS] plpgsql - additional extra checks

Hi 2018-01-07 0:59 GMT+01:00 Stephen Frost : > Greetings Pavel, > > * Pavel Stehule (pavel.steh...@gmail.com) wrote: > > 2017-11-30 3:44 GMT+01:00 Michael Paquier : > > > At least documentation needs patching, or this is going to generate > > >

Re: [HACKERS] plpgsql - additional extra checks

Greetings Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > 2017-11-30 3:44 GMT+01:00 Michael Paquier : > > At least documentation needs patching, or this is going to generate > > warnings on HEAD at compilation. I am moving this to next CF for lack > > of

Re: [HACKERS] plpgsql - additional extra checks

On Wed, Sep 13, 2017 at 12:51 PM, Pavel Stehule wrote: > > > 2017-09-13 1:42 GMT+02:00 Daniel Gustafsson : >> >> > On 08 Apr 2017, at 15:46, David Steele wrote: >> > >> >> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: >> >>> On Fri, Jan