Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record

2018-07-12 Thread Michael Paquier
On Fri, Jul 13, 2018 at 08:13:39AM +0500, Andrey V. Lepikhov wrote: > Timestamp in a backup history file not correspond to any WAL record and > can't be bind with a time of backup exactly. > In my opinion, keeping timestamp in XLOG_BACKUP_END is more reliable, safe > and easy way for recovering a d

Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record

2018-07-12 Thread Andrey V. Lepikhov
On 10.07.2018 22:26, Fujii Masao wrote: On Tue, Jul 10, 2018 at 6:41 PM, Andrey V. Lepikhov wrote: On 10.07.2018 06:45, Andres Freund wrote: Hi, On 2018-07-10 06:41:32 +0500, Andrey V. Lepikhov wrote: This functionality is needed in practice when we have to determine a recovery time o

Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record

2018-07-10 Thread Fujii Masao
On Tue, Jul 10, 2018 at 6:41 PM, Andrey V. Lepikhov wrote: > > > On 10.07.2018 06:45, Andres Freund wrote: >> >> Hi, >> >> On 2018-07-10 06:41:32 +0500, Andrey V. Lepikhov wrote: >>> >>> This functionality is needed in practice when we have to determine a >>> recovery time of specific backup. >> >

Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record

2018-07-10 Thread Andrey V. Lepikhov
On 10.07.2018 06:45, Andres Freund wrote: Hi, On 2018-07-10 06:41:32 +0500, Andrey V. Lepikhov wrote: This functionality is needed in practice when we have to determine a recovery time of specific backup. What do you mean by "recovery time of specific backup"? recovery time - is a time

Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record

2018-07-09 Thread Andres Freund
Hi, On 2018-07-10 06:41:32 +0500, Andrey V. Lepikhov wrote: > This functionality is needed in practice when we have to determine a > recovery time of specific backup. What do you mean by "recovery time of specific backup"? > This code developed in compatibility with WAL segments, which do not h