Hi,
On Wed, 3 Apr 2024 at 12:11, Daniel Gustafsson wrote:
>
> > On 6 Mar 2024, at 09:59, Daniel Gustafsson wrote:
>
> > Nothing sticks out from reading through these patches, they seem quite
> > ready to
> > me.
>
> Took another look at this today and committed it. Thanks!
Thanks for the
> On 6 Mar 2024, at 09:59, Daniel Gustafsson wrote:
> Nothing sticks out from reading through these patches, they seem quite ready
> to
> me.
Took another look at this today and committed it. Thanks!
--
Daniel Gustafsson
> On 26 Feb 2024, at 13:42, Nazir Bilal Yavuz wrote:
> All of your feedback is addressed in v2.
Nothing sticks out from reading through these patches, they seem quite ready to
me. Being able to filter and analyze on errorcodes is likely to be more
important going forward as more are running
Hi,
On Fri, 23 Feb 2024 at 15:34, Daniel Gustafsson wrote:
>
> > On 23 Feb 2024, at 13:09, Nazir Bilal Yavuz wrote:
>
> > Does errmsg_internal() need to be used all the time when turning elogs
> > into ereports? errmsg_internal()'s comment says that "This should be
> > used for "can't happen"
> On 23 Feb 2024, at 13:09, Nazir Bilal Yavuz wrote:
> Does errmsg_internal() need to be used all the time when turning elogs
> into ereports? errmsg_internal()'s comment says that "This should be
> used for "can't happen" cases that are probably not worth spending
> translation effort on.". Is
Hi,
Thanks for the review!
On Thu, 22 Feb 2024 at 16:55, Daniel Gustafsson wrote:
>
> > On 6 Dec 2023, at 14:03, Nazir Bilal Yavuz wrote:
>
> > There is an ongoing thread [1] for adding missing SQL error codes to
> > PANIC and FATAL error reports in xlogrecovery.c file. I did the same
> > but
> On 6 Dec 2023, at 14:03, Nazir Bilal Yavuz wrote:
> There is an ongoing thread [1] for adding missing SQL error codes to
> PANIC and FATAL error reports in xlogrecovery.c file. I did the same
> but for xlog.c and relcache.c files.
- elog(PANIC, "space reserved for WAL record does not
