Re: GSoC 2017: weekly progress reports (week 6)

2018-03-07 Thread Andres Freund
Hi,

On 2018-03-07 11:58:51 -0300, Alvaro Herrera wrote:
> > This appears to be a duplicate of 
> > https://commitfest.postgresql.org/17/1466/ - as the other one is older, I'm 
> > closing this one.
> 
> This comment makes no sense from the POV of the mail archives.  I had to
> look at the User-Agent in your email to realize that you wrote it in the
> commitfest app.

Yea, I stopped doing so afterwards...


> 1. impersonating the "From:" header is a bad idea; needs fixed much as
>we did with the bugs and doc comments submission forms
> 2. it should have had a header indicating it comes from CF app
> 3. it would be great to include in said header a link to the CF entry
>to which the comment was attached.

Sounds reasonable.

Greetings,

Andres Freund



Re: GSoC 2017: weekly progress reports (week 6)

2018-03-07 Thread Alvaro Herrera
Andres Freund wrote:

> This appears to be a duplicate of https://commitfest.postgresql.org/17/1466/ 
> - as the other one is older, I'm closing this one.

This comment makes no sense from the POV of the mail archives.  I had to
look at the User-Agent in your email to realize that you wrote it in the
commitfest app.  I see three problems here

1. impersonating the "From:" header is a bad idea; needs fixed much as
   we did with the bugs and doc comments submission forms
2. it should have had a header indicating it comes from CF app
3. it would be great to include in said header a link to the CF entry
   to which the comment was attached.

Thanks

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: GSoC 2017: weekly progress reports (week 6)

2018-03-01 Thread Andres Freund
This appears to be a duplicate of https://commitfest.postgresql.org/17/1466/ - 
as the other one is older, I'm closing this one.