Re: Synchronous replay take III

2019-02-03 Thread Thomas Munro
On Mon, Feb 4, 2019 at 4:47 PM Michael Paquier wrote: > Last patch set fails to apply properly, so moved to next CF waiting on > author for a rebase. Thanks. Rebased. -- Thomas Munro http://www.enterprisedb.com 0001-Synchronous-replay-mode-for-avoiding-stale-reads-v11.patch Description: Bina

Re: Synchronous replay take III

2019-02-03 Thread Michael Paquier
On Fri, Feb 01, 2019 at 09:34:49AM -0500, Robert Haas wrote: > Maybe I'm misunderstanding the terminology here, but if not, I find > this theory wildly implausible. *Most* people want read-your-writes > behavior. *Few* people want to wait for a dead standby. The only > application of the later i

Re: Synchronous replay take III

2019-02-01 Thread Robert Haas
On Thu, Jan 24, 2019 at 6:42 PM Thomas Munro wrote: > Yes, this is essentially the same thing that you were arguing against > above. Perhaps you are right, and there are no people who would want > synchronous replay, but not synchronous commit. Maybe I'm misunderstanding the terminology here, bu

Re: Synchronous replay take III

2019-01-30 Thread Michail Nikolaev
Hello, Sorry, missed email. >> In our case we have implemented some kind of "replication barrier" functionality based on table with counters (one counter per application backend in simple case). >> Each application backend have dedicated connection to each replica. And it selects its counter valu

Re: Synchronous replay take III

2019-01-24 Thread Thomas Munro
On Tue, Jan 15, 2019 at 11:17 PM Masahiko Sawada wrote: > Regarding the current (v10 patch) design I have some questions and > comments. Hi Sawada-san, Thanks for your testing and feedback. > The patch introduces new GUC parameter synchronous_replay. We can set > synchronous_commit = off while

Re: Synchronous replay take III

2019-01-15 Thread Masahiko Sawada
On Sat, Dec 1, 2018 at 10:49 AM Thomas Munro wrote: > > On Sat, Dec 1, 2018 at 9:06 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > Unfortunately, cfbot says that patch can't be applied without conflicts, > > could > > you please post a rebased version and address commentaries from Masahiko?

Re: Synchronous replay take III

2018-12-27 Thread Thomas Munro
Hello, Here is a rebased patch, and separate replies to Michael and Michail. On Sat, Dec 1, 2018 at 4:57 PM Michael Paquier wrote: > On Sat, Dec 01, 2018 at 02:48:29PM +1300, Thomas Munro wrote: > > Right, it conflicted with 4c703369 and cfdf4dc4. While rebasing on > > top of those, I found mys

Re: Synchronous replay take III

2018-12-02 Thread Michail Nikolaev
Hello. It is really nice feature. I am working on the project which heavily reads from replicas (6 of them). In our case we have implemented some kind of "replication barrier" functionality based on table with counters (one counter per application backend in simple case). Each application backend

Re: Synchronous replay take III

2018-11-30 Thread Michael Paquier
On Sat, Dec 01, 2018 at 02:48:29PM +1300, Thomas Munro wrote: > On Sat, Dec 1, 2018 at 9:06 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: >> Unfortunately, cfbot says that patch can't be applied without conflicts, >> could >> you please post a rebased version and address commentaries from Masahi

Re: Synchronous replay take III

2018-11-30 Thread Thomas Munro
On Sat, Dec 1, 2018 at 9:06 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > Unfortunately, cfbot says that patch can't be applied without conflicts, could > you please post a rebased version and address commentaries from Masahiko? Right, it conflicted with 4c703369 and cfdf4dc4. While rebasing

Re: Synchronous replay take III

2018-11-30 Thread Dmitry Dolgov
> On Thu, Nov 15, 2018 at 6:34 AM Masahiko Sawada wrote: > > On Thu, Mar 1, 2018 at 10:40 AM Thomas Munro > > wrote: > > > > In previous threads[1][2][3] I called this feature proposal "causal > > reads". That was a terrible name, borrowed from MySQL. While it is > > probably a useful term of

Re: Synchronous replay take III

2018-11-14 Thread Masahiko Sawada
On Thu, Mar 1, 2018 at 10:40 AM Thomas Munro wrote: > > Hi hackers, > > I was pinged off-list by a fellow -hackers denizen interested in the > synchronous replay feature and wanting a rebased patch to test. Here > it goes, just in time for a Commitfest. Please skip to the bottom of > this messag

Re: Synchronous replay take III

2018-10-22 Thread Thomas Munro
On Mon, Sep 24, 2018 at 10:39 AM Thomas Munro wrote: > On Mon, Jul 2, 2018 at 12:39 PM Thomas Munro > wrote: > > On Sat, Mar 3, 2018 at 2:11 AM, Adam Brusselback > > wrote: > > > Thanks Thomas, appreciate the rebase and the work you've done on this. > > > I should have some time to test this out

Re: Synchronous replay take III

2018-09-23 Thread Thomas Munro
On Mon, Jul 2, 2018 at 12:39 PM Thomas Munro wrote: > On Sat, Mar 3, 2018 at 2:11 AM, Adam Brusselback > wrote: > > Thanks Thomas, appreciate the rebase and the work you've done on this. > > I should have some time to test this out over the weekend. > > Rebased. Rebased. -- Thomas Munro http:/

Re: Synchronous replay take III

2018-07-01 Thread Thomas Munro
On Sat, Mar 3, 2018 at 2:11 AM, Adam Brusselback wrote: > Thanks Thomas, appreciate the rebase and the work you've done on this. > I should have some time to test this out over the weekend. Rebased. Moved to September. I still need to provide a TAP test and explain that weirdness reported by Dm

Re: Synchronous replay take III

2018-03-02 Thread Adam Brusselback
Thanks Thomas, appreciate the rebase and the work you've done on this. I should have some time to test this out over the weekend. -Adam

Re: Synchronous replay take III

2018-03-01 Thread Michael Paquier
On Thu, Mar 01, 2018 at 06:55:18PM +1300, Thomas Munro wrote: > On Thu, Mar 1, 2018 at 2:39 PM, Thomas Munro > wrote: >> I was pinged off-list by a fellow -hackers denizen interested in the >> synchronous replay feature and wanting a rebased patch to test. Here >> it goes, just in time for a Comm

Re: Synchronous replay take III

2018-02-28 Thread Thomas Munro
On Thu, Mar 1, 2018 at 2:39 PM, Thomas Munro wrote: > I was pinged off-list by a fellow -hackers denizen interested in the > synchronous replay feature and wanting a rebased patch to test. Here > it goes, just in time for a Commitfest. Please skip to the bottom of > this message for testing note