Re: complier warnings from ecpg tests
Hi >> Thanks for the set of flags. So this comes from the use of -Og, and >> the rest of the tree does not complain. The issue is that gcc >> complains about the buffer not being large enough, but %d only uses up >> to 2 characters so there is no overflow. In order to fix the issue it >> is fine enough to increase the buffer size to 28 bytes, so I would >> recommend to just do that. This is similar to the business done in >> 3a4b891. > > And fixed with a9f301d. Thank you! My compiler is now quiet regards, Sergei
Re: complier warnings from ecpg tests
On Thu, Aug 01, 2019 at 03:14:06PM +0900, Michael Paquier wrote: > Thanks for the set of flags. So this comes from the use of -Og, and > the rest of the tree does not complain. The issue is that gcc > complains about the buffer not being large enough, but %d only uses up > to 2 characters so there is no overflow. In order to fix the issue it > is fine enough to increase the buffer size to 28 bytes, so I would > recommend to just do that. This is similar to the business done in > 3a4b891. And fixed with a9f301d. -- Michael signature.asc Description: PGP signature
Re: complier warnings from ecpg tests
On Thu, Jul 11, 2019 at 04:57:08PM +0300, Sergei Kornilov wrote: > I use: ./configure --prefix=somepath --enable-cassert --enable-debug > CFLAGS="-ggdb -Og -g3 -fno-omit-frame-pointer" --enable-tap-tests > No other explicit options. Thanks for the set of flags. So this comes from the use of -Og, and the rest of the tree does not complain. The issue is that gcc complains about the buffer not being large enough, but %d only uses up to 2 characters so there is no overflow. In order to fix the issue it is fine enough to increase the buffer size to 28 bytes, so I would recommend to just do that. This is similar to the business done in 3a4b891. -- Michael signature.asc Description: PGP signature
Re: complier warnings from ecpg tests
Hi > Are you using -Wformat-overflow? At which level? I use: ./configure --prefix=somepath --enable-cassert --enable-debug CFLAGS="-ggdb -Og -g3 -fno-omit-frame-pointer" --enable-tap-tests No other explicit options. pg_config reports: CPPFLAGS = -D_GNU_SOURCE CFLAGS = -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -ggdb -Og -g3 -fno-omit-frame-pointer CFLAGS_SL = -fPIC regards, Sergei
Re: complier warnings from ecpg tests
On Thu, Jul 11, 2019 at 03:21:15PM +0300, Sergei Kornilov wrote: > I noticed few warnings from my compiler (gcc version 8.3.0 (Debian > 8.3.0-6)) during make check-world: > > They coming from src/interfaces/ecpg tests ( > ./src/interfaces/ecpg/test/sql/array.pgc ). > Seems this code is 4 year old but I did not found discussion related > to such compiler warnings. Is this expected? Are you using -Wformat-overflow? At which level? -- Michael signature.asc Description: PGP signature
