Re: [HACKERS] NT + deadlock intended behaviour ?

2004-07-18 Thread Alvaro Herrera
On Sun, Jul 18, 2004 at 01:38:57AM -0400, Tom Lane wrote: Gaetano Mendola [EMAIL PROTECTED] writes: why SESSION 1 was unblocked ? ... Why that commit unblock the SESSION 1? IMHO session 1 should have been unblocked in both cases as soon as session 2's subtransaction failed. We have

Re: [HACKERS] PITR COPY Failure (was Point in Time Recovery)

2004-07-18 Thread Tom Lane
Mark Kirkwood [EMAIL PROTECTED] writes: - anything =128393 rows in test0.dat results in 2 or more archived logs, and recovery fails on the second log (and gives the zero length redo at 0/1E0 message). Zero length record is not an error, it's the normal way of detecting end-of-log.

Re: [HACKERS] Vacuum Cost Documentation?

2004-07-18 Thread Tom Lane
Matthew T. O'Connor [EMAIL PROTECTED] writes: Related to autovacuum work, I was looking into the new vacuum delay functionality. I might be missing something, but I can't find anything on it in the developer docs. Is that right? You are not missing anything. I already nagged Jan about this

[HACKERS] pg_dump bug fixing

2004-07-18 Thread Christopher Kings-Lynne
Hi everyone, I've decided to attempt to nail all known bugs in pg_dump for 7.5 :) So, please send me ALL your known bugs/issues with pg_dump, pg_dumpall and pg_restore. Note that I am NOT interested in feature requests, ONLY bugs. A bug is considered to be an issue in pg_dump that means that

Re: [HACKERS] PITR COPY Failure (was Point in Time Recovery)

2004-07-18 Thread Mark Kirkwood
There are some silly bugs in the script: - forgot to export PGDATA and PATH after changing them - forgot to mention the need to edit test.sql (COPY line needs path to dump file) Apologies - I will submit a fixed version a little later regards Mark Mark Kirkwood wrote: A script to run the whole

Re: [HACKERS] PITR COPY Failure (was Point in Time Recovery)

2004-07-18 Thread Mark Kirkwood
fixed. Mark Kirkwood wrote: There are some silly bugs in the script: - forgot to export PGDATA and PATH after changing them - forgot to mention the need to edit test.sql (COPY line needs path to dump file) Apologies - I will submit a fixed version a little later regards Mark Mark Kirkwood wrote:

Re: [HACKERS] NT + deadlock intended behaviour ?

2004-07-18 Thread Gaetano Mendola
Alvaro Herrera wrote: On Sun, Jul 18, 2004 at 01:06:39AM +0200, Gaetano Mendola wrote: I'm doing some experiments with NT, I din't expect this behaviuor: First of all, let me point that the behavior on deadlock has been agreed to change. Instead of only aborting the innermost transaction, it

Re: [HACKERS] NT + deadlock intended behaviour ?

2004-07-18 Thread Gaetano Mendola
Alvaro Herrera wrote: Gaetano, please apply the latest savepoints patch (savepoint-5.patch) and let me know how it goes ... where is it ? Regards Gaetano Mendola ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [HACKERS] pg_dump bug fixing

2004-07-18 Thread Bruno Wolff III
On Sun, Jul 18, 2004 at 14:33:09 +0800, Christopher Kings-Lynne [EMAIL PROTECTED] wrote: * If you drop your public schema, a drop command is not issued for it in the dump, so when you restore your public schema is back I am not sure that is really a bug. If someone really wants less than

Re: [HACKERS] pg_dump bug fixing

2004-07-18 Thread Christopher Kings-Lynne
I am not sure that is really a bug. If someone really wants less than what is in template1, they should be dropping stuff from template1 before recreating the database. No, because pg_dump itself dumps template1's contents... Chris ---(end of

Re: [HACKERS] pg_dump bug fixing

2004-07-18 Thread Bruno Wolff III
On Sun, Jul 18, 2004 at 19:42:09 +0800, Christopher Kings-Lynne [EMAIL PROTECTED] wrote: I am not sure that is really a bug. If someone really wants less than what is in template1, they should be dropping stuff from template1 before recreating the database. No, because pg_dump itself dumps

Re: [HACKERS] pg_dump bug fixing

2004-07-18 Thread Rod Taylor
On Sun, 2004-07-18 at 07:42, Christopher Kings-Lynne wrote: I am not sure that is really a bug. If someone really wants less than what is in template1, they should be dropping stuff from template1 before recreating the database. No, because pg_dump itself dumps template1's contents...

Re: [HACKERS] NT + deadlock intended behaviour ?

2004-07-18 Thread Alvaro Herrera
On Sun, Jul 18, 2004 at 11:00:25AM +0200, Gaetano Mendola wrote: Alvaro Herrera wrote: If I abort only the innermost transaction on session 2, the application writer can have a retry loop on it, so it will issue the begin again and the same update. Since session 1 is still locked, session 2

Re: [HACKERS] NT + deadlock intended behaviour ?

2004-07-18 Thread Alvaro Herrera
On Sun, Jul 18, 2004 at 11:06:19AM +0200, Gaetano Mendola wrote: Alvaro Herrera wrote: Gaetano, please apply the latest savepoints patch (savepoint-5.patch) and let me know how it goes ... where is it ? I just sent it by private mail to you (11kb). I don't see it in the archives ... --

Re: [HACKERS] Vacuum Cost Documentation?

2004-07-18 Thread David Fetter
On Sun, Jul 18, 2004 at 02:32:10AM -0400, Tom Lane wrote: Matthew T. O'Connor [EMAIL PROTECTED] writes: Related to autovacuum work, I was looking into the new vacuum delay functionality. I might be missing something, but I can't find anything on it in the developer docs. Is that right?

[HACKERS] Toward better documentation

2004-07-18 Thread David Fetter
Kind people, It's been pointed out to me that I tend to document by example http://fetter.org/sgml/plperl.html, e.g. My personal opinion is that this is a good thing, and should happen throughout the PostgreSQL documentation. However, this is not my decision to make. Here's some pros cons, as

Re: [HACKERS] Toward better documentation

2004-07-18 Thread Marc G. Fournier
On Sun, 18 Jul 2004, David Fetter wrote: Kind people, It's been pointed out to me that I tend to document by example http://fetter.org/sgml/plperl.html, e.g. My personal opinion is that this is a good thing, and should happen throughout the PostgreSQL documentation. However, this is not my

Re: [HACKERS] Toward better documentation

2004-07-18 Thread Peter Eisentraut
David Fetter wrote: It's been pointed out to me that I tend to document by example Documenting by example is like proving by example -- it helps understanding, but it doesn't replace the actual thing. Nonetheless, no one ever claimed that more examples would be a bad thing. -- Peter

[HACKERS] XLogWrite: write request 0/53A4000 is past end of log 0/53A4000

2004-07-18 Thread lists
this is 7.3.3 (PGDG rpm's) on red hat 7.2: i had a lot of debugging enabled. i went to create an index, and pgsql dumped on me. i tried restarting several times - no luck. starting postgresql gives LOG: database system shutdown was interrupted at 2004-07-16 01:11:56 EDT LOG: checkpoint

Re: [HACKERS] Toward better documentation

2004-07-18 Thread David Fetter
On Sun, Jul 18, 2004 at 10:14:23PM +0200, Peter Eisentraut wrote: David Fetter wrote: It's been pointed out to me that I tend to document by example Documenting by example is like proving by example -- it helps understanding, but it doesn't replace the actual thing. Nonetheless, no one

Re: [HACKERS] Release planning

2004-07-18 Thread Christopher Browne
A long time ago, in a galaxy far, far away, Gaetano Mendola [EMAIL PROTECTED] wrote: I was thinking of something much simpler where Jan would create an ARC patch against 7.4.X and have it either in /contrib for 7.4.X or on our ftp servers, or on a web site. I could create a mechanism so

[HACKERS] Escaping metacharacters

2004-07-18 Thread DarkSamurai
Hi, To prevent SQL injections, I try to neutralize SQL metacharacters. ex: Code: function SQLString($s) { $s = str_replace(', \\s, $s)' $s = str_replace(\\, , $s); return ' . $s . '; And suppose I use this : $cat = $GET[category]; $query = SELECT Id, Title, Abstract FROM News .

Re: [HACKERS] Toward better documentation

2004-07-18 Thread Marc G. Fournier
On Sun, 18 Jul 2004, David Fetter wrote: What I am looking for is how the community feels about committing resources, which are in short supply, to putting more examples in the docs. I think this is a worthwhile effort, as it can pull in a larger group of people to do documentation, taking

Re: [HACKERS] Why we really need timelines *now* in PITR

2004-07-18 Thread Simon Riggs
On Sat, 2004-07-17 at 21:36, Tom Lane wrote: If we do not add timeline numbers to WAL file names, we will be forced to destroy information during recovery. Consider the following scenario: 1. You have a WAL directory containing, say, WAL segments 0010 to 0020 (for the purposes of this

Re: [HACKERS] Escaping metacharacters

2004-07-18 Thread Oliver Elphick
On Thu, 2004-07-15 at 23:02, DarkSamurai wrote: Hi, To prevent SQL injections, I try to neutralize SQL metacharacters. ex: Code: function SQLString($s) { $s = str_replace(', \\s, $s)' $s = str_replace(\\, , $s); return ' . $s . '; Have you looked at the

[HACKERS] function return type

2004-07-18 Thread Andrew Dunstan
How can I get a TupleDesc for the return type of a non-SR function that returns a tuple? I'm sure it's there somewhere but I just can't see it. thanks andrew ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index

Re: [HACKERS] pg_dump bug fixing

2004-07-18 Thread Christopher Kings-Lynne
No, because pg_dump itself dumps template1's contents... Are you planning on extending this line of thought to other things in template1 such as operators? Ah, I see where you are going with this I think that we should treat the public schema specially :) That's because it is much more

Re: [HACKERS] Toward better documentation

2004-07-18 Thread Christopher Kings-Lynne
I see I have gotten off to a bad start here, and I apologize for not having made myself clearer. I did not suggest removing the principles items from the docs, nor did I suggest that anybody thought examples are a bad thing. What I am looking for is how the community feels about committing

Re: [HACKERS] Toward better documentation

2004-07-18 Thread Christopher Kings-Lynne
Pros: * Accomodates different learning styles * Jump-starts development by providing working code * Built-in tests for breakage of backward compatibility Cons: * Start-up costs re: actually writing checking the examples * Bigger document base to update maintain * Disk space What do you all

Re: [HACKERS] Escaping metacharacters

2004-07-18 Thread Christopher Kings-Lynne
function SQLString($s) { $s = str_replace(', \\s, $s)' $s = str_replace(\\, , $s); return ' . $s . '; Have you looked at the function PQescapeString() in the libpq library? Using that would seem to be a simpler way of solving this problem. If he's using PHP, he should be using the

Re: [HACKERS] Toward better documentation

2004-07-18 Thread Andrew Dunstan
David Fetter wrote: Kind people, It's been pointed out to me that I tend to document by example http://fetter.org/sgml/plperl.html, e.g. My personal opinion is that this is a good thing, and should happen throughout the PostgreSQL documentation. However, this is not my decision to make. Here's

Re: [HACKERS] Escaping metacharacters

2004-07-18 Thread Greg Stark
DarkSamurai [EMAIL PROTECTED] writes: And suppose I use this : $cat = $GET[category]; $query = SELECT Id, Title, Abstract FROM News . Where Category= . $cat; From a security point of view you're even better off using something like $dbh-query(SELECT id, title, abstract FROM news WHERE

[HACKERS] CVS compile failure

2004-07-18 Thread Bruce Momjian
I am seeing a compile failure in current CVS from strptime(): ./backend/access/transam/xlog.c:if (strptime(tok2, %Y-%m-%d %H:%M:%S, tm) == NULL) BSD/OS does not have that function. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] |

Re: [HACKERS] Why we really need timelines *now* in PITR

2004-07-18 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: The way you write this makes me think you might mean you would allow: we can start recovering in one timelines, then rollforward takes us through all the timeline nexus points required to get us to the target timeline. Sure. Let's draw a diagram:

Re: [HACKERS] pg_dump bug fixing

2004-07-18 Thread Tom Lane
Rod Taylor [EMAIL PROTECTED] writes: I think what we want is a clean template without all of the extras that template1 has. Sounds like a job for ... template0 ! Seriously, this thread would be more convincing if anyone in it betrayed any knowledge that pg_dump wants you to start from

Re: [HACKERS] CVS compile failure

2004-07-18 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: I am seeing a compile failure in current CVS from strptime(): ./backend/access/transam/xlog.c:if (strptime(tok2, %Y-%m-%d %H:%M:%S, tm) == NULL) BSD/OS does not have that function. Hmph. I was wondering if that was really portable or not :-(.

Re: [HACKERS] CVS compile failure

2004-07-18 Thread Marc G. Fournier
On Mon, 19 Jul 2004, Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I am seeing a compile failure in current CVS from strptime(): ./backend/access/transam/xlog.c:if (strptime(tok2, %Y-%m-%d %H:%M:%S, tm) == NULL) BSD/OS does not have that function. Hmph. I was wondering if that

Re: [HACKERS] CVS compile failure

2004-07-18 Thread Tom Lane
Marc G. Fournier [EMAIL PROTECTED] writes: Bruce Momjian [EMAIL PROTECTED] writes: I am seeing a compile failure in current CVS from strptime(): ./backend/access/transam/xlog.c:if (strptime(tok2, %Y-%m-%d %H:%M:%S, tm) == NULL) BSD/OS does not have that function. Under FreeBSD: