Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread David Fetter
On Tue, Apr 28, 2009 at 11:33:28AM +0300, Heikki Linnakangas wrote: I wrote a little perl script to perform a basic sanity check to keywords in gram.y and kwlist.h. It checks that all lists are in alphabetical order, all keywords present in gram.y are listed in kwlist.h in the right

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Andy Lester
On Apr 30, 2009, at 2:27 AM, David Fetter wrote: Please clean up this code at least to the point where it's strict-clean, which means putting use strict; right after the shebang line and not checking it in until it runs that way. I can take care of this, David. Shouldn't be too tough. --

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Robert Haas
On Thu, Apr 30, 2009 at 3:27 AM, David Fetter da...@fetter.org wrote: On Tue, Apr 28, 2009 at 11:33:28AM +0300, Heikki Linnakangas wrote: I wrote a little perl script to perform a basic sanity check to keywords  in gram.y and kwlist.h. It checks that all lists are in alphabetical  order, all

Re: [HACKERS] Python 3.0 does not work with PL/Python

2009-04-30 Thread David Blewett
On Thu, Apr 30, 2009 at 8:30 AM, James Pye li...@jwp.name wrote: On Apr 30, 2009, at 5:09 AM, David Blewett wrote: I'd love to see this. yep, once I get 0.9 of the driver out the door, I'll probably focus on this. It's the perfect time for a rewrite.. I really don't want to see the 2.x

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Bruce Momjian
David Fetter wrote: On Tue, Apr 28, 2009 at 11:33:28AM +0300, Heikki Linnakangas wrote: I wrote a little perl script to perform a basic sanity check to keywords in gram.y and kwlist.h. It checks that all lists are in alphabetical order, all keywords present in gram.y are listed in

[HACKERS] Documenting bgwriter during recovery

2009-04-30 Thread Simon Riggs
There's an Open Item for 8.4 about documenting the fact that the bgwriter is now active during archive recovery. So down to me. We don't currently document which processes are active at any given time. i.e. we didn't document that the bgwriter *wasn't* active during recovery, so there's nothing

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Andy Lester
On Apr 30, 2009, at 6:41 AM, Robert Haas wrote: Please clean up this code at least to the point where it's strict-clean, which means putting use strict; right after the shebang line and not checking it in until it runs that way. And use warnings;, too. I'll prob'ly come up with a policy

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Bruce Momjian
Robert Haas wrote: On Thu, Apr 30, 2009 at 3:27 AM, David Fetter da...@fetter.org wrote: On Tue, Apr 28, 2009 at 11:33:28AM +0300, Heikki Linnakangas wrote: I wrote a little perl script to perform a basic sanity check to keywords ?in gram.y and kwlist.h. It checks that all lists are in

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread David Fetter
On Thu, Apr 30, 2009 at 11:39:33AM -0500, Andy Lester wrote: On Apr 30, 2009, at 6:41 AM, Robert Haas wrote: Please clean up this code at least to the point where it's strict-clean, which means putting use strict; right after the shebang line and not checking it in until it runs that way.

[HACKERS] pg_resetxlog bug?

2009-04-30 Thread Fujii Masao
Hi, Current pg_resetxlog doesn't remove any archive status files. This may cause continuous failure of archive command since .ready file remains even if a corresponding XLOG segment is removed. And, .done file without XLOG segment cannot be removed by checkpoint, and would remain forever. These

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Peter Eisentraut
On Thursday 30 April 2009 10:27:45 David Fetter wrote: I'd also like to propose that strict clean be a minimum code quality metric for any Perl code in our code base. A lot of what's in there is just about impossible to maintain. use strict and use warnings, I think, although with use

[HACKERS] Creating a tablespace directory in recovery

2009-04-30 Thread Fujii Masao
Hi, Does anyone know why a tablespace directory isn't automatically created in recovery? I think that it's troublesome to create all the directories before recovery. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Heikki Linnakangas
Laurent Laborde wrote: On Tue, Apr 28, 2009 at 10:33 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I wrote a little perl script to perform a basic sanity check to keywords in gram.y and kwlist.h. It checks that all lists are in alphabetical order, all keywords present in

Re: [HACKERS] Python 3.0 does not work with PL/Python

2009-04-30 Thread David Blewett
On Sun, Apr 5, 2009 at 7:10 PM, James Pye li...@jwp.name wrote: Any thoughts on the acceptability of a complete rewrite for Python 3? I've been fiddling with a HEAD branch including the plpy code in a github repo. (nah it dunt compile yet: bitrot and been busy with a 3.x driver. ;) I'd love to

[HACKERS] Creating a tablespace directory in recovery

2009-04-30 Thread Fujii Masao
Hi, Does anyone know why a tablespace directory isn't automatically created in recovery? I think that it's troublesome to create all the directories before recovery. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers

[HACKERS] Throw some low-level C scutwork at me

2009-04-30 Thread Andy Lester
I've got my git clone set up, a copy of GCC 4.4 (and other compilers) at the ready, and am glad to help out on low-level scut work. Anybody need anything done? splint? valgrind? Let me know. xoxo, Andy -- Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance --

[HACKERS] User documentation on signal handling

2009-04-30 Thread Gurjeet Singh
Hi All, I just came across this page from 6.4 docs: http://www.postgresql.org/docs/6.4/static/signals.htm Do we have any such doc in our current release? It sure is helpful from user perspective to understand how Postgres responds to different signals; I just saw another instance of kill -9

Re: [HACKERS] Throw some low-level C scutwork at me

2009-04-30 Thread Andy Lester
Getting our Perl into shape would be Really Good(TM). :) I will, but right now my #1 is getting some vi modelines in place so we can all be using the same tab/space settings. xoxo, Andy -- Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance -- Sent via

Re: [HACKERS] Throw some low-level C scutwork at me

2009-04-30 Thread Andy Lester
On Apr 30, 2009, at 4:39 PM, Andrew Dunstan wrote: I will, but right now my #1 is getting some vi modelines in place so we can all be using the same tab/space settings. Hasn't that been discussed before and rejected? (For one thing, plenty of us don't use vi) For those who do use vi,

Re: [HACKERS] GiST index changes

2009-04-30 Thread Bruce Momjian
bruce wrote: Has the on-disk format changed for GiST indexes? I know it has for hash and GIN indexes. Sorry, I should have clarified: did the GiST index on-disk format change between Postgres 8.3 and 8.4. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB

Re: [HACKERS] Throw some low-level C scutwork at me

2009-04-30 Thread David Fetter
On Thu, Apr 30, 2009 at 05:39:42PM -0400, Andrew Dunstan wrote: Andy Lester wrote: Getting our Perl into shape would be Really Good(TM). :) I will, but right now my #1 is getting some vi modelines in place so we can all be using the same tab/space settings. Hasn't that been discussed

Re: [HACKERS] Throw some low-level C scutwork at me

2009-04-30 Thread Andrew Dunstan
Andy Lester wrote: Getting our Perl into shape would be Really Good(TM). :) I will, but right now my #1 is getting some vi modelines in place so we can all be using the same tab/space settings. Hasn't that been discussed before and rejected? (For one thing, plenty of us don't use vi)

[HACKERS] GiST index changes

2009-04-30 Thread Bruce Momjian
Has the on-disk format changed for GiST indexes? I know it has for hash and GIN indexes. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via

Re: [HACKERS] pg_resetxlog bug?

2009-04-30 Thread Simon Riggs
On Fri, 2009-05-01 at 00:07 +0900, Fujii Masao wrote: Current pg_resetxlog doesn't remove any archive status files. This may cause continuous failure of archive command since .ready file remains even if a corresponding XLOG segment is removed. And, .done file without XLOG segment cannot be

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread David Fetter
On Thu, Apr 30, 2009 at 09:40:50AM -0700, David Fetter wrote: On Thu, Apr 30, 2009 at 11:39:33AM -0500, Andy Lester wrote: On Apr 30, 2009, at 6:41 AM, Robert Haas wrote: Please clean up this code at least to the point where it's strict-clean, which means putting use strict; right after

Re: [HACKERS] idea: global temp tables

2009-04-30 Thread James Mansion
Kevin Grittner wrote: contexts. I don't think the updates to the system tables have the same magnitude of performance hit as creating these tables, especially if write barriers are on. Wouldn't it be cleaner just to defer creation of real files to support the structures associated with a

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Laurent Laborde
On Tue, Apr 28, 2009 at 10:33 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I wrote a little perl script to perform a basic sanity check to keywords in gram.y and kwlist.h. It checks that all lists are in alphabetical order, all keywords present in gram.y are listed in

Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Andy Lester
On Apr 30, 2009, at 2:11 PM, David Fetter wrote: Here's a patch that gets it to pass perlcritic -4 and still (as far as I can tell) work. Tell ya what. Let me at it and I'll give a larger, more inclusive patch. xoxo, Andy -- Andy Lester = a...@petdance.com = www.theworkinggeek.com =

Re: [HACKERS] Creating a tablespace directory in recovery

2009-04-30 Thread Jaime Casanova
On Thu, Apr 30, 2009 at 2:58 AM, Fujii Masao masao.fu...@gmail.com wrote: Hi, Does anyone know why a tablespace directory isn't automatically created in recovery? I think that it's troublesome to create all the directories before recovery. i guess it's because you need an absolute path to

Re: [HACKERS] idea: global temp tables

2009-04-30 Thread Kevin Grittner
Greg Stark st...@enterprisedb.com wrote: creating/deleting a few dozen rows in the system catalogs shouldn't really be something that autovacuum can't deal with. I don't see why it's limited to a few dozen rows. Moderately busy web sites these days count their traffic in hundreds of page

Re: [HACKERS] idea: global temp tables

2009-04-30 Thread Kevin Grittner
Greg Stark st...@enterprisedb.com wrote: On Wed, Apr 29, 2009 at 6:42 PM, Tom Lane t...@sss.pgh.pa.us wrote: I agree with Kevin's objection that you are unfairly raising the bar for this feature by demanding a performance improvement to go along with a functionality change. I think

[HACKERS] Documentation: GiST extension implementation

2009-04-30 Thread Dimitri Fontaine
Hi, The following documentation page explains the GiST API to extensions authors: http://www.postgresql.org/docs/current/static/gist-implementation.htm I think we should be a little more verbose, and at least explains some more the big picture: same/consistent/union are responsible for

Re: [HACKERS] idea: global temp tables

2009-04-30 Thread Pavel Stehule
2009/4/29 Tom Lane t...@sss.pgh.pa.us: Greg Stark st...@enterprisedb.com writes: Well I claim it's not just a nice bonus but is the difference between implementing something which falls technically within the standard's rules but fails to actually be useful for the standard's intended

[HACKERS] UHC as a server encoding?

2009-04-30 Thread Chuck McDevitt
Why are certain character encodings not legal for the server_encoding? For example, we allow EUC_KR, but disallow UHC, which is a superset of EUC_KR. What are the rules for what is or is not allowed as server_encoding? Is it having a conversion to MIC that is the issue? Why is that important