Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread KaiGai Kohei
(2010/02/04 0:20), Robert Haas wrote: 2010/2/1 KaiGai Koheikai...@ak.jp.nec.com: I again wonder whether we are on the right direction. I believe the proposed approach is to dump blob metadata if and only if you are also dumping blob contents, and to do all of this for data dumps but not

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread KaiGai Kohei
(2010/02/04 17:30), KaiGai Kohei wrote: (2010/02/04 0:20), Robert Haas wrote: 2010/2/1 KaiGai Koheikai...@ak.jp.nec.com: I again wonder whether we are on the right direction. I believe the proposed approach is to dump blob metadata if and only if you are also dumping blob contents, and to do

Re: [HACKERS] [CFReview] Red-Black Tree

2010-02-04 Thread Mark Cave-Ayland
Robert Haas wrote: Maybe we are now getting to the heart of the confusion. Mark wrote in his email: Unfortunately I was not really able to reproduce the RND (teodor's) dataset, nor the random array test as the SQL used to test the implementation was not present on the page above. The SQL for

Re: [HACKERS] CommitFest Status Summary - 2010-02-03

2010-02-04 Thread Mark Cave-Ayland
Robert Haas wrote: Here's an overview of where we stand with the remaining 14 patches, according to my best understanding of the situation. * rbtree - I have done a lot of work reviewing this, and Mark Cave-Ayland has done some work on it, too. But there are some unanswered performance

[HACKERS] Shared catalogs vs pg_global tablespace

2010-02-04 Thread Tom Lane
So while playing with cluster/vac full on shared catalogs I ran into a small catch-22. If the transient table created by make_new_heap is marked relisshared, the code complains because that OID is not known to IsSharedRelation. If it's not marked shared, you run into various error checks and

Re: [HACKERS] [CFReview] Red-Black Tree

2010-02-04 Thread Oleg Bartunov
I'm in progress of preparing this page http://www.sai.msu.su/~megera/wiki/rbtree_test Hope, tests are easy to reproduce. This is slightly improved version of rbtree patch, Teodor didn't commit yet. Random array test and real-life examples are ok, I still working on test #1, which is quite

Re: [HACKERS] Shared catalogs vs pg_global tablespace

2010-02-04 Thread Heikki Linnakangas
Tom Lane wrote: I'm not sure whether allowing that would be good or bad. I see no obvious killer reason why it'd be bad, but it seems like the kind of thing we might regret someday. pg_global is in some sense an implementation artifact, so allowing users to depend on it might be bad in the

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-04 Thread Chris Campbell
On Feb 3, 2010, at 10:16 AM, Stefan Kaltenbrunner wrote: Robert Haas wrote: On Wed, Feb 3, 2010 at 6:24 AM, Chris Campbell chris_campb...@mac.com wrote: The flurry of patches that vendors have recently been making to OpenSSL to address the potential man-in-the-middle attack during SSL

Re: [HACKERS] [CFReview] Red-Black Tree

2010-02-04 Thread Teodor Sigaev
I would like to see point #2 of the following email addressed before commit. As things stand, it is not clear (at least to me) whether this is a win. Reimplementation of ginInsertRecordBA reduces difference of HEAD and HEAD+rbtree in regular case. Test suite is taken from

[HACKERS] Writeable CTEs documentation patch

2010-02-04 Thread Marko Tiikkaja
Hi, Attached is a documentation patch for writeable CTEs. Most of it is explaining how this feature works in select.sgml. I wasn't sure if that's the right place, but couldn't find a better one. I also wasn't able to find any place discussing the command tag, other than libpq's documentation.

Re: NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-02-04 Thread Michael Meskes
On Thu, Feb 04, 2010 at 03:55:06PM +0100, Boszormenyi Zoltan wrote: I added the #include float.h to the nan_test.pgc in the hope it fixes the Windows machines in the buildfarm. I already commited this earlier today after looking at the problem myself. But of course I'm also just hoping as I do

Re: [HACKERS] PG 9.0 and standard_conforming_strings

2010-02-04 Thread David E. Wheeler
On Feb 3, 2010, at 6:16 PM, Robert Haas wrote: Any web framework that interpolates user supplied values into SQL rather than using placeholders is broken from the get go, IMNSHO. I'm not saying that there aren't reasons to hold up moving to SCS, but this isn't one of them. That seems more

Re: [HACKERS] PG 9.0 and standard_conforming_strings

2010-02-04 Thread Andrew Dunstan
Robert Haas wrote: On Wed, Feb 3, 2010 at 5:57 PM, Andrew Dunstan and...@dunslane.net wrote: marcin mank wrote: A certain prominent web framework has a nasty SQL injection bug when PG is configured with SCS. This bug is not present without SCS (details per email for interested PG

Re: [HACKERS] Shared catalogs vs pg_global tablespace

2010-02-04 Thread Robert Haas
On Thu, Feb 4, 2010 at 10:30 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Tom Lane wrote: I'm not sure whether allowing that would be good or bad.  I see no obvious killer reason why it'd be bad, but it seems like the kind of thing we might regret someday.  pg_global is in

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread Robert Haas
2010/2/4 KaiGai Kohei kai...@ak.jp.nec.com: (2010/02/04 0:20), Robert Haas wrote: 2010/2/1 KaiGai Koheikai...@ak.jp.nec.com: I again wonder whether we are on the right direction. I believe the proposed approach is to dump blob metadata if and only if you are also dumping blob contents, and

Re: [HACKERS] Re: [COMMITTERS] pgsql: Assorted cleanups in preparation for using a map file to support

2010-02-04 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Wed, 2010-02-03 at 10:48 -0500, Tom Lane wrote: If so, there is some minor code cleanup and comment changes in ProcessCommittedInvalidationMessages(). Would you like me to do that, or should we wait? I saw that. I didn't touch it because it's

Re: [HACKERS] Re: [COMMITTERS] pgsql: Assorted cleanups in preparation for using a map file to support

2010-02-04 Thread Simon Riggs
On Thu, 2010-02-04 at 13:02 -0500, Tom Lane wrote: Simon Riggs si...@2ndquadrant.com writes: On Wed, 2010-02-03 at 10:48 -0500, Tom Lane wrote: If so, there is some minor code cleanup and comment changes in ProcessCommittedInvalidationMessages(). Would you like me to do that, or should we

Re: [HACKERS] testing cvs HEAD - HS/SR - cannot stat

2010-02-04 Thread Josh Berkus
Yeah, this is not a bug. At first, the standby performs an archive recovery until an invalid WAL record is found. Then it starts replication and tries to receive the missing WAL records from the primary. So such an error message would be logged whenever an invalid record is found and

[HACKERS] building tsquery directly in memory (avoid makepol)

2010-02-04 Thread Ivan Sergio Borgonovo
I know in advance the structure of a whole tsquery, it has already been reduced and lexemes have been already computed. I'd like to directly write it in memory without having to pass through pushValue/makepol. Anyway I'm not pretty sure about what is the layout of a tsquery in memory and I still

Re: [HACKERS] testing cvs HEAD - HS/SR - cannot stat

2010-02-04 Thread Heikki Linnakangas
Josh Berkus wrote: Can we improve the error message? Right now it's alarming people. Such as: cannot stat `/var/data1/pg_stuff/dump/replication_archive/00010002': End of Log Not really, it's coming from 'cp'. Not sure if we could capture the stderr and somehow decorate the

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread Alvaro Herrera
Robert Haas escribió: 2010/2/4 KaiGai Kohei kai...@ak.jp.nec.com: (2010/02/04 0:20), Robert Haas wrote: 2010/2/1 KaiGai Koheikai...@ak.jp.nec.com: I again wonder whether we are on the right direction. I believe the proposed approach is to dump blob metadata if and only if you are also

Re: [HACKERS] testing cvs HEAD - HS/SR - cannot stat

2010-02-04 Thread Magnus Hagander
2010/2/4 Heikki Linnakangas heikki.linnakan...@enterprisedb.com: Josh Berkus wrote: Can we improve the error message?  Right now it's alarming people.  Such as: cannot stat `/var/data1/pg_stuff/dump/replication_archive/00010002': End of Log Not really, it's coming from

Re: [HACKERS] testing cvs HEAD - HS/SR - cannot stat

2010-02-04 Thread Erik Rijkers
On Thu, February 4, 2010 19:29, Heikki Linnakangas wrote: Josh Berkus wrote: Can we improve the error message? Right now it's alarming people. Such as: cannot stat `/var/data1/pg_stuff/dump/replication_archive/00010002': End of Log Not really, it's coming from 'cp'. Not

Re: [HACKERS] testing cvs HEAD - HS/SR - cannot stat

2010-02-04 Thread Heikki Linnakangas
Magnus Hagander wrote: 2010/2/4 Heikki Linnakangas heikki.linnakan...@enterprisedb.com: Josh Berkus wrote: Can we improve the error message? Right now it's alarming people. Such as: cannot stat `/var/data1/pg_stuff/dump/replication_archive/00010002': End of Log Not

Re: [HACKERS] building tsquery directly in memory (avoid makepol)

2010-02-04 Thread Teodor Sigaev
Before doing it the trial and error way can somebody just make me an example? I'm not pretty sure about my interpretation of the comments of the documentation. TSQuery [skipped] Right, valcrc is computed in pushValue I couldn't see any place in the code where TSQuery is built in one shot in

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread KaiGai Kohei
(2010/02/05 3:27), Alvaro Herrera wrote: Robert Haas escribió: 2010/2/4 KaiGai Koheikai...@ak.jp.nec.com: (2010/02/04 0:20), Robert Haas wrote: 2010/2/1 KaiGai Koheikai...@ak.jp.nec.com: I again wonder whether we are on the right direction. I believe the proposed approach is to dump blob

Re: [HACKERS] Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION

2010-02-04 Thread Takahiro Itagaki
Fujii Masao masao.fu...@gmail.com wrote: On Fri, Dec 5, 2008 at 11:41 PM, Randy Isbell jisb...@cisco.com wrote: An inconsistency exists between the segment name reported by pg_stop_backup() and the actual WAL file name. START WAL LOCATION: 10/FE1E2BAC (file 0002001000FE)

Re: [HACKERS] Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION

2010-02-04 Thread Fujii Masao
On Fri, Feb 5, 2010 at 9:08 AM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: But it was rejected because its change might break the existing app. It might break existing applications if it returns FE instead of FF, but never-used filename surprises users. (IMO, the existing apps

Re: [HACKERS] building tsquery directly in memory (avoid makepol)

2010-02-04 Thread Ivan Sergio Borgonovo
On Thu, 04 Feb 2010 22:13:02 +0300 Teodor Sigaev teo...@sigaev.ru wrote: Before doing it the trial and error way can somebody just make me an example? I'm not pretty sure about my interpretation of the comments of the documentation. TSQuery [skipped] Right, valcrc is computed in

Re: [HACKERS] testing cvs HEAD - HS/SR - cannot stat

2010-02-04 Thread Fujii Masao
On Fri, Feb 5, 2010 at 3:58 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: LOG:  database system was interrupted while in recovery at log time 2010-02-04 20:45:40 EET HINT:  If this has occurred more than once some data might be corrupted and you might need to choose an

Re: [HACKERS] Personal Copyright Notices

2010-02-04 Thread Bruce Momjian
Bruce Momjian wrote: The intagg copyright is on a _Makefile_: # Makefile for integer aggregator # Copyright (C) 2001 Digital Music Network. # by Mark L. Woodward # $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 19:58:45 tgl Exp $ Seems we either

Re: [HACKERS] remove contrib/xml2

2010-02-04 Thread M Z
I did some tests followed Robert's test cases on both postgresql 8.4.2-0ubu and 8.3.8-1, OS: Ubuntu Karmic. 1) 1st test case, it doesn't crash on 8.3.8 but crash on 8.4.2; 2) 2nd test case, both 8.3.8 and 8.4.2 are fine, and no warning (different from Robert's test?); 3) 3rd test case (and

Re: [HACKERS] Personal Copyright Notices

2010-02-04 Thread Bruce Momjian
Bruce Momjian wrote: The ISN copyright looks like this: * Copyright (c) 2004-2006, GermE1n ME9ndez Bravo (Kronuz) * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group Interestingly, he mentions himself and PGDG both in the copyright, which makese this

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread Takahiro Itagaki
KaiGai Kohei kai...@kaigai.gr.jp wrote: default:both contents and metadata --data-only:same --schema-only: neither However, it means only large object performs an exceptional object class that dumps its owner, acl and comment even if --data-only is given. Is

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread KaiGai Kohei
(2010/02/05 13:53), Takahiro Itagaki wrote: KaiGai Koheikai...@kaigai.gr.jp wrote: default:both contents and metadata --data-only:same --schema-only: neither However, it means only large object performs an exceptional object class that dumps its owner, acl and

Re: Looking for Bill Huang; was [HACKERS] Personal Copyright Notices

2010-02-04 Thread Bruce Momjian
Bruce Momjian wrote: Some more _personalized_ copyright noticed have crept into our source tree: /src/tutorial/basics.source Copyright (c) 1994, Andrew Yu, University of California /contrib/intagg/Makefile Copyright (c) 2001 Digital Music Network by Mark L. Woodward

Re: [HACKERS] Writeable CTEs patch

2010-02-04 Thread Takahiro Itagaki
Marko Tiikkaja marko.tiikk...@cs.helsinki.fi wrote: Here's an updated patch. Only changes from the previous patch are fixing the above issue and a regression test for it. A brief report for of the patch: * The patch has the following error cases, and also have one regression test for each

Re: [HACKERS] Writeable CTEs patch

2010-02-04 Thread Marko Tiikkaja
On 2010-02-05 07:14 UTC+2, Takahiro Itagaki wrote: Marko Tiikkaja marko.tiikk...@cs.helsinki.fi wrote: Here's an updated patch. Only changes from the previous patch are fixing the above issue and a regression test for it. * In the regression tests, almost all of them don't have ORDER BY

Re: [HACKERS] Writeable CTEs patch

2010-02-04 Thread Tom Lane
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: * In the regression tests, almost all of them don't have ORDER BY clause. They just work, but we might need ORDER BY to get robust output. What did we do in other regression tests? We add ORDER BY only when experience shows it's

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-02-04 Thread KaiGai Kohei
(2010/02/05 13:53), Takahiro Itagaki wrote: KaiGai Koheikai...@kaigai.gr.jp wrote: default:both contents and metadata --data-only:same --schema-only: neither However, it means only large object performs an exceptional object class that dumps its owner, acl and