Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-15 Thread Heikki Linnakangas
Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: So you'd prefer a message that is sometimes flat-out wrong over a message that is correct but less informative in the common case? I guess that could be right call, but it's not what I'd pick. Well, as I said, I think the only way

Re: [HACKERS] Streaming replication and a disk full in primary

2010-04-15 Thread Heikki Linnakangas
Robert Haas wrote: I've realized another problem with this patch. standby_keep_segments only controls the number of segments that we keep around for purposes of streaming: it doesn't affect archiving at all. And of course, a standby server based on archiving is every bit as much of a standby

Re: [HACKERS] Rogue TODO list created

2010-04-15 Thread Simon Riggs
On Wed, 2010-04-14 at 23:28 -0400, Bruce Momjian wrote: Greg Smith wrote: Bruce Momjian wrote: What is Prioritised Todo? It looks like a copy of the TODO list that was created on March 23, 2010, and only you and Simon have modified it:

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-15 Thread Simon Riggs
On Thu, 2010-04-15 at 00:24 -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: So you'd prefer a message that is sometimes flat-out wrong over a message that is correct but less informative in the common case? I guess that could be right call, but it's not what I'd pick.

Re: [HACKERS] walreceiver is uninterruptible on win32

2010-04-15 Thread Magnus Hagander
On Thu, Apr 15, 2010 at 4:17 AM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Looking at the call-sites, there are bugs now - if PQexec() returns NULL, we don't deal with it. It also doesn't always free the result properly. I've added checks for that. I

Re: [HACKERS] walreceiver is uninterruptible on win32

2010-04-15 Thread Magnus Hagander
On Thu, Apr 15, 2010 at 5:13 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Apr 14, 2010 at 11:15 PM, Magnus Hagander mag...@hagander.net wrote: The patch also seems confused about whether it's intending to be a general-purpose solution or not.  You can maybe take some shortcuts if it's

Re: [HACKERS] Win32 timezone matching

2010-04-15 Thread Magnus Hagander
On Thu, Apr 15, 2010 at 2:54 AM, Tom Lane t...@sss.pgh.pa.us wrote: [ back to this... ] Magnus Hagander mag...@hagander.net writes: On Wed, Apr 7, 2010 at 21:06, Tom Lane t...@sss.pgh.pa.us wrote: I suppose we had a reason for doing it the first way but I can't see what.  GMT seems a fairly

Re: [HACKERS] Win32 timezone matching

2010-04-15 Thread Magnus Hagander
On Thu, Apr 15, 2010 at 3:48 AM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Wed, Apr 7, 2010 at 21:01, Tom Lane t...@sss.pgh.pa.us wrote: ... lack either the note about defaulting to GMT or the hint.  I guess we should add both of those to the failure

Re: [HACKERS] Timezone matching script (win32)

2010-04-15 Thread Magnus Hagander
On Tue, Apr 13, 2010 at 7:55 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Magnus Hagander wrote: This script should probably live in CVS, and be run when Microsoft releases new timezone data. Where should I put it - src/timezone or somewhere in

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-15 Thread Stephen Frost
Simon, * Simon Riggs (si...@2ndquadrant.com) wrote: So instead of the typical reject instruction we also add a rejectverbose instruction that has a more verbose message. Docs would describe it as an additional instruction to assist with debugging a complex pg_hba.conf, with warning that if

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-15 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: * Simon Riggs (si...@2ndquadrant.com) wrote: So instead of the typical reject instruction we also add a rejectverbose instruction that has a more verbose message. Erm, so we'd add an option for this? That strikes me as pretty excessive. I think

Re: [HACKERS] testing HS/SR - invalid magic number

2010-04-15 Thread Erik Rijkers
On Wed, April 14, 2010 08:23, Heikki Linnakangas wrote: Erik Rijkers wrote: This replication test that was working well earlier (it ran daily), stopped working This is probably because of this change: date: 2010/04/12 09:52:29; author: heikki; state: Exp; lines: +71 -23 Change the

Re: [HACKERS] walreceiver is uninterruptible on win32

2010-04-15 Thread Robert Haas
On Wed, Apr 14, 2010 at 11:13 PM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Apr 14, 2010 at 11:15 PM, Magnus Hagander mag...@hagander.net wrote: http://archives.postgresql.org/pgsql-hackers/2010-04/msg00077.php As for the code itself, don't we need a CHECK_FOR_INTERRUPTS in there for it

Re: [HACKERS] Streaming replication and a disk full in primary

2010-04-15 Thread Alvaro Herrera
Robert Haas escribió: In the department of minor nits, I also don't like the fact that the GUC is called standby_keep_segments and the variable is called StandbySegments. If we really have to capitalize them differently, we should at least make it StandbyKeepSegments, but personally I think

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-15 Thread David Fetter
On Wed, Apr 14, 2010 at 08:37:18PM -0400, Robert Haas wrote: On Wed, Apr 14, 2010 at 8:31 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: What's wrong with something like connection not permitted or connection not authorized? The

Re: [HACKERS] testing HS/SR - invalid magic number

2010-04-15 Thread Heikki Linnakangas
Erik Rijkers wrote: Btw, typo alert: documentation 18.5.4, subhead 'standby_keep_segments', says: 'replciation' for 'replication'. http://developer.postgresql.org/pgdocs/postgres/runtime-config-wal.html#RUNTIME-CONFIG-REPLICATION Thanks, fixed. -- Heikki Linnakangas EnterpriseDB

[HACKERS] Very ineffective plan with merge join

2010-04-15 Thread Oleg Bartunov
Hi there, below is an example of interesting query and two plans - the bad plan, which uses merge join and big sorting, took 216 sec, and good plan with merge join disabled took 8 sec. Sorry for odd names, they were generated by popular accounting engine in Russia. 8.4.3 and HEAD show the

Re: [HACKERS] Very ineffective plan with merge join

2010-04-15 Thread Kevin Grittner
Oleg Bartunov o...@sai.msu.su wrote: Sorry for odd names, they were generated by popular accounting engine in Russia. How much of that can you trim out and still see the problem? -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] [PATCH] Add --ordered option to pg_dump

2010-04-15 Thread Bob Lunney
I needed a way to run diffs on two database dumps to see what data developers put in their local databases versus the initial database load.  The pg_dump utility with --inserts works well for this, but since the order in which the data is returned of the server is not guaranteed I hacked this

Re: [HACKERS] Very ineffective plan with merge join

2010-04-15 Thread Oleg Bartunov
On Thu, 15 Apr 2010, Kevin Grittner wrote: Oleg Bartunov o...@sai.msu.su wrote: Sorry for odd names, they were generated by popular accounting engine in Russia. How much of that can you trim out and still see the problem? It's difficult, since I don't know semantics of data. I reduced

Re: [HACKERS] [PATCH] Add --ordered option to pg_dump

2010-04-15 Thread Peter Eisentraut
On tor, 2010-04-15 at 10:48 -0700, Bob Lunney wrote: I needed a way to run diffs on two database dumps to see what data developers put in their local databases versus the initial database load. Maybe pg_comparator would help you? -- Sent via pgsql-hackers mailing list

[HACKERS] pgindent and tabs in comments

2010-04-15 Thread Peter Eisentraut
Apparently, pgindent replaces multiple spaces in comments by a tab (possibly subject to additional logic). An example among thousands:

Re: [HACKERS] Very ineffective plan with merge join

2010-04-15 Thread Pavel Stehule
Hello there is significant problem in statistics I think, Regards Pavel Stehule 2010/4/15 Oleg Bartunov o...@sai.msu.su: On Thu, 15 Apr 2010, Kevin Grittner wrote: Oleg Bartunov o...@sai.msu.su wrote: Sorry for odd names, they were generated by popular accounting engine in Russia. How

Re: [HACKERS] Very ineffective plan with merge join

2010-04-15 Thread Oleg Bartunov
On Thu, 15 Apr 2010, Pavel Stehule wrote: Hello there is significant problem in statistics I think, Ah, you're right ! Regards Pavel Stehule 2010/4/15 Oleg Bartunov o...@sai.msu.su: On Thu, 15 Apr 2010, Kevin Grittner wrote: Oleg Bartunov o...@sai.msu.su wrote: Sorry for odd names,

Re: [HACKERS] Very ineffective plan with merge join

2010-04-15 Thread Tom Lane
Oleg Bartunov o...@sai.msu.su writes: below is an example of interesting query and two plans - the bad plan, which uses merge join and big sorting, took 216 sec, and good plan with merge join disabled took 8 sec. The good plan seems to be fast mainly because of heavily cached inner

Re: [HACKERS] Rogue TODO list created

2010-04-15 Thread Bruce Momjian
Greg Smith wrote: Bruce Momjian wrote: http://wiki.postgresql.org/wiki/User:Simon Well, unless Simon wants to keep it for some reason, it should be removed, and if kept, renamed. Simon? I already retitled the copy left on the personal page and deleted the one that was causing the

Re: [HACKERS] Very ineffective plan with merge join

2010-04-15 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: I'm not sure how much it would help to increase the statistics targets, but that would be worth trying. I notice that the scan rowcount estimates are very accurate, there's that one hash join result that's way off, though. What's up with the sort of

Re: [HACKERS] Very ineffective plan with merge join

2010-04-15 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: What's up with the sort of _accrged7200 (in the slower plan) taking in 3.5 million rows and putting out 1 row? There's something there I'm not understanding. It's under a merge join, so what probably happened is that the first row from that

Re: [HACKERS] Streaming replication and a disk full in primary

2010-04-15 Thread Robert Haas
On Thu, Apr 15, 2010 at 2:54 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Robert Haas wrote: I've realized another problem with this patch.  standby_keep_segments only controls the number of segments that we keep around for purposes of streaming: it doesn't affect

Re: [HACKERS] [PATCH] Add --ordered option to pg_dump

2010-04-15 Thread Mark Kirkwood
Peter Eisentraut wrote: On tor, 2010-04-15 at 10:48 -0700, Bob Lunney wrote: I needed a way to run diffs on two database dumps to see what data developers put in their local databases versus the initial database load. Maybe pg_comparator would help you? Or DBIx::Compare if you

Re: [HACKERS] pgindent and tabs in comments

2010-04-15 Thread Bruce Momjian
Peter Eisentraut wrote: Apparently, pgindent replaces multiple spaces in comments by a tab (possibly subject to additional logic). An example among thousands:

Re: [HACKERS] autovacuum and temp tables support

2010-04-15 Thread Bruce Momjian
Robert Haas wrote: On Thu, Apr 8, 2010 at 3:22 PM, Oleg Bartunov o...@sai.msu.su wrote: On general thought I've had is that it would be nice if the first attempt to SELECT against a table with no statistics would trigger an automatic ANALYZE by the backend on which the query was executed.

[HACKERS] solaris sparc 64bit binary release

2010-04-15 Thread John R Pierce
the 8.4.3 binary tarball for solaris sparc 64bit on postgresql.com was shipped with the 32bit includes and the Makefile fragments from 8.4-community/lib/64/pgxs/src/ I'm specifically hitting this contradition: $ grep FLOAT8 include/server/pg_config.h #define FLOAT8PASSBYVAL false and $

Re: [HACKERS] [PATCH] Add --ordered option to pg_dump

2010-04-15 Thread Bob Lunney
Thanks for the suggestion, Peter. It looks like pg_comparator is for comparing the contents of two different servers. I need to compare the contents of two dump files from the same server separated by time and busy developers. Regards, Bob Lunney --- On Thu, 4/15/10, Peter Eisentraut