[HACKERS] Online base backup from the hot-standby

2011-06-14 Thread Jun Ishiduka
( Quotation from http://archives.postgresql.org/pgsql-hackers/2011-05/msg01396.php ) STEP1: Make startup process to acquire backup-end-position from not only backup-end record but also backup-history-file . * startup process allows to acquire backup-end-position

Re: [HACKERS] Online base backup from the hot-standby

2011-06-14 Thread Heikki Linnakangas
On 14.06.2011 09:03, Jun Ishiduka wrote: ( Quotation from http://archives.postgresql.org/pgsql-hackers/2011-05/msg01396.php ) STEP1: Make startup process to acquire backup-end-position from not only backup-end record but also backup-history-file . * startup process

Re: [HACKERS] Online base backup from the hot-standby

2011-06-14 Thread Jun Ishiduka
I still think that's headed in the wrong direction. (http://archives.postgresql.org/pgsql-hackers/2011-05/msg01405.php) Please check these mails, and teach the reason for content of the wrong direction. (http://archives.postgresql.org/pgsql-hackers/2011-06/msg00209.php)

Re: [HACKERS] FOREIGN TABLE doc fix

2011-06-14 Thread Dave Page
On Mon, Jun 13, 2011 at 8:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: Dave Page dp...@pgadmin.org writes: I've already implemented some simple qual pushdown in the redis FDW, and am planning to do something similar for MySQL - however I won't be surprised if I have to rewrite redisGetQual in

Re: [HACKERS] 9.1 beta1 error

2011-06-14 Thread Thom Brown
On 14 June 2011 05:17, Franklin Haut franklin.h...@gmail.com wrote: hi people, postgresql goes down on a  WindowsXP SP3 machine. there a script to reproduce. (on XP with 8.4 works fine) CREATE DATABASE teste   WITH OWNER = postgres        ENCODING = 'UTF8'        TABLESPACE = pg_default  

Re: [HACKERS] ECPG parse.pl and parse2.pl

2011-06-14 Thread Michael Meskes
On Mon, Jun 13, 2011 at 10:59:38PM +0300, Peter Eisentraut wrote: I propose that we move parse2.pl to parse.pl and only keep the one. I agree, thanks for taking care. Originally I wanted to keep parse.pl around for a bit, so I could run both and compare the output over the development cycle.

[HACKERS] per-column generic option

2011-06-14 Thread Shigeru Hanada
Hi, I would like to propose support for per-column generic option, which is defined in the SQL/MED standard. In 9.0 release, support for foreign tables and per-table generic option have been added, but support for per-column generic option hasn't. Please examine the description below and

Re: [HACKERS] pg_trgm: unicode string not working

2011-06-14 Thread Florian Pflug
On Jun14, 2011, at 07:15 , Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jun 13, 2011 at 7:47 PM, Bruce Momjian br...@momjian.us wrote: No, it does not. Under what circumstances should I issue a suggestion to reindex, and what should the text be? It sounds like GIN

Re: [HACKERS] SSI patch renumbered existing 2PC resource managers??

2011-06-14 Thread Heikki Linnakangas
On 13.06.2011 22:33, Tom Lane wrote: Heikki Linnakangasheikki.linnakan...@enterprisedb.com writes: On 13.06.2011 21:31, Tom Lane wrote: So far as I can tell, that breaks pg_upgrade (if there are any open prepared transactions) for no redeeming social benefit. Surely pg_upgrade can't work

Re: [HACKERS] [PATCH] Bug in XPATH() if expression returns a scalar value

2011-06-14 Thread Florian Pflug
On Jun13, 2011, at 21:24 , Peter Eisentraut wrote: On ons, 2011-06-08 at 10:14 +0200, Florian Pflug wrote: But then you lose the ability to evaluate user-supplied XPath expressions, because there's no way of telling which of these function to use. Perhaps having both variants, one type-safe

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-14 Thread Florian Pflug
On Jun13, 2011, at 16:19 , Andrew Dunstan wrote: On 06/13/2011 10:07 AM, Robert Haas wrote: Some languages use =~ and some use just ~... I was just wondering if anyone thought the commutator of =~ was ~=... My feeling is it's a bit dangerous. It's too easy to fat-finger the reverse op, and

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-14 Thread Florian Pflug
On Jun13, 2011, at 05:44 , Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Jun 12, 2011 at 7:46 AM, Florian Pflug f...@phlo.org wrote: (B) There should be a way to use ANY()/ALL() with the array elements becoming the left arguments of the operator. It seems to me that if

Re: [HACKERS] SSI work for 9.1

2011-06-14 Thread Heikki Linnakangas
On 10.06.2011 19:05, Kevin Grittner wrote: I found that pgindent would like to tweak whitespace in three places in that patch, and I found an unnecessary include that I would like to remove. Normally, I would post a new version of the patch with those adjustments, but there's been a disquieting

Re: [HACKERS] lazy vxid locks, v1

2011-06-14 Thread Robert Haas
On Mon, Jun 13, 2011 at 8:10 PM, Jeff Janes jeff.ja...@gmail.com wrote: On Sun, Jun 12, 2011 at 2:39 PM, Robert Haas robertmh...@gmail.com wrote: ... Profiling reveals that the system spends enormous amounts of CPU time in s_lock.  LWLOCK_STATS reveals that the only lwlock with significant

Re: [HACKERS] 9.1 beta1 error

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 1:17 AM, Franklin Haut franklin.h...@gmail.com wrote: hi people, postgresql goes down on a  WindowsXP SP3 machine. there a script to reproduce. (on XP with 8.4 works fine) There is a crash related to time zone handling that was fixed in 9.1beta2. -- Robert Haas

Re: [HACKERS] Make relation_openrv atomic wrt DDL

2011-06-14 Thread Robert Haas
On Mon, Jun 13, 2011 at 4:04 PM, Noah Misch n...@leadboat.com wrote: On Mon, Jun 13, 2011 at 08:21:05AM -0400, Robert Haas wrote: On Mon, Jun 13, 2011 at 1:12 AM, Noah Misch n...@leadboat.com wrote: This probably would not replace a backend-local counter of processed messages for

[HACKERS] [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address

2011-06-14 Thread Kohei KaiGai
The attached patch is a preparation to rework implementation of DROP statement using a common code. That intends to apply get_object_address() to resolve name of objects to be removed, and eventually minimizes the number of places to put permission checks. Its first step is an enhancement of

Re: [HACKERS] pg_trgm: unicode string not working

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 1:15 AM, Tom Lane t...@sss.pgh.pa.us wrote: I'm not sure that pg_upgrade is a good vehicle for dispensing such advice, anyway.  At least in the Red Hat packaging, end users will never read what it prints, unless maybe it fails outright and they're trying to debug why.

Re: [HACKERS] Creating new remote branch in git?

2011-06-14 Thread Robert Haas
On Mon, Jun 13, 2011 at 10:54 PM, Bruce Momjian br...@momjian.us wrote: Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of lun jun 13 18:38:46 -0400 2011: Andrew Dunstan wrote: Is putting remotes in your ~/.gitconfig  good practice? I certainly don't have any in mine.

Re: [HACKERS] SSI patch renumbered existing 2PC resource managers??

2011-06-14 Thread Kevin Grittner
Heikki Linnakangas wrote: Ok, I've renumbered the existing RMs back the way they were. Don't we also need something like the attached? -Kevin ssi-twophase-c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] per-column generic option

2011-06-14 Thread Robert Haas
I haven't looked at the patch yet, but here are a few comments on the design, which overall looks good. 2011/6/14 Shigeru Hanada shigeru.han...@gmail.com: 1) psql should support describing per-column generic options, so \dec command was added.  If the form \dec+ is used, generic options are

Re: [HACKERS] SSI patch renumbered existing 2PC resource managers??

2011-06-14 Thread Heikki Linnakangas
On 14.06.2011 15:14, Kevin Grittner wrote: Heikki Linnakangas wrote: Ok, I've renumbered the existing RMs back the way they were. Don't we also need something like the attached? Yes. I just committed a fix for that after noticing that the buildfarm didn't like it. Sorry.. -- Heikki

Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-14 Thread Robert Haas
On Mon, Jun 13, 2011 at 4:10 PM, richhguard-monot...@yahoo.co.uk wrote: Apologies - I meant to CC in the list but forgot. I have gone through and changed all the related functions except ``update_attstats''. Do you have any advice of how to handle the inner loops, such as those

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 6:10 AM, Florian Pflug f...@phlo.org wrote: On Jun13, 2011, at 05:44 , Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Jun 12, 2011 at 7:46 AM, Florian Pflug f...@phlo.org wrote: (B) There should be a way to use ANY()/ALL() with the array elements

Re: [HACKERS] 9.1 beta1 error

2011-06-14 Thread Franklin Haut
Hass, there problem are fixed in 9.1beta2, and now works. thanks 2011/6/14 Robert Haas robertmh...@gmail.com On Tue, Jun 14, 2011 at 1:17 AM, Franklin Haut franklin.h...@gmail.com wrote: hi people, postgresql goes down on a WindowsXP SP3 machine. there a script to reproduce. (on XP

Re: [HACKERS] Creating new remote branch in git?

2011-06-14 Thread Bruce Momjian
Robert Haas wrote: On Mon, Jun 13, 2011 at 10:54 PM, Bruce Momjian br...@momjian.us wrote: Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of lun jun 13 18:38:46 -0400 2011: Andrew Dunstan wrote: Is putting remotes in your ~/.gitconfig ?good practice? I certainly

Re: [HACKERS] Creating new remote branch in git?

2011-06-14 Thread Bruce Momjian
Magnus Hagander wrote: I understand now --- that it is risky to create an origin branch in ~/.gitconfig. ?I am now using an alias: ? ? ? ?[alias] ? ? ? ? ? ? ? ?pgclone = clone ssh://g...@gitmaster.postgresql.org/postgresql.git I assume the 'github' branch in ~/.gitconfig

Re: [HACKERS] Creating new remote branch in git?

2011-06-14 Thread Magnus Hagander
On Tue, Jun 14, 2011 at 14:40, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jun 13, 2011 at 10:54 PM, Bruce Momjian br...@momjian.us wrote: Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of lun jun 13 18:38:46 -0400 2011: Andrew Dunstan wrote: Is

Re: [HACKERS] ITYM DROP TABLE

2011-06-14 Thread Robert Haas
On Mon, Jun 13, 2011 at 5:44 PM, David E. Wheeler da...@kineticode.com wrote: I was reading the partitioning docs when I spotted this. I think it means to highlight the advantages of DROP TABLE over DELETE rather than ALTER TABLE. I guess they might mean ALTER TABLE .. NO INHERIT. But I think

Re: [HACKERS] SSI patch renumbered existing 2PC resource managers??

2011-06-14 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: No, pg_upgrade should not be unilaterally refusing that. Uh, isn't there some physical files in pg_twophase/ that stick around to keep prepared transactions --- if so, pg_upgrade does not copy them from the old

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-14 Thread Florian Pflug
On Jun14, 2011, at 14:29 , Robert Haas wrote: On Tue, Jun 14, 2011 at 6:10 AM, Florian Pflug f...@phlo.org wrote: On Jun13, 2011, at 05:44 , Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Jun 12, 2011 at 7:46 AM, Florian Pflug f...@phlo.org wrote: (B) There should be a way

Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-14 Thread Alvaro Herrera
Excerpts from richhguard-monotone's message of lun jun 13 16:10:17 -0400 2011: Apologies - I meant to CC in the list but forgot. I have gone through and changed all the related functions except ``update_attstats''. Do you have any advice of how to handle the inner loops, such as those

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-06-14 Thread Alexander Korotkov
Version of patch with few more comments and some fixes. -- With best regards, Alexander Korotkov. arrayanalyze-0.4.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Cédric Villemain
2011/5/16 Greg Smith g...@2ndquadrant.com: Cédric Villemain wrote: http://git.postgresql.org/gitweb?p=users/c2main/postgres.git;a=shortlog;h=refs/heads/analyze_cache This rebases easily to make Cedric's changes move to the end; I just pushed a version with that change to

Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-14 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from richhguard-monotone's message of lun jun 13 16:10:17 -0400 2011: Do you have any advice of how to handle the inner loops, such as those initializing ``stakindN''. The entries before can be handled just like in this patch, by

Re: [HACKERS] ITYM DROP TABLE

2011-06-14 Thread Alvaro Herrera
Excerpts from David E. Wheeler's message of lun jun 13 17:44:05 -0400 2011: I was reading the partitioning docs when I spotted this. I think it means to highlight the advantages of DROP TABLE over DELETE rather than ALTER TABLE. I think the point of the existing wording is to point out ALTER

Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 10:30 AM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from richhguard-monotone's message of lun jun 13 16:10:17 -0400 2011: Do you have any advice of how to handle the inner loops, such as those initializing

Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-14 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar jun 14 10:30:28 -0400 2011: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from richhguard-monotone's message of lun jun 13 16:10:17 -0400 2011: Do you have any advice of how to handle the inner loops, such as those initializing

Re: [HACKERS] Re: patch review : Add ability to constrain backend temporary file space

2011-06-14 Thread Cédric Villemain
2011/6/3 Mark Kirkwood mark.kirkw...@catalyst.net.nz: On 02/06/11 18:34, Jaime Casanova wrote: - the patch adds this to serial_schedule but no test has been added... diff --git a/src/test/regress/serial_schedule b/src/test/regress/serial_schedule index bb654f9..325cb3d 100644 ---

Re: [HACKERS] SSI work for 9.1

2011-06-14 Thread Kevin Grittner
Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I did some further changes, refactoring SkipSerialization so that it's hopefully more readable, and added a comment about the side-effects. See attached. Let me know if I'm missing something. I do think the changes improve

Re: [HACKERS] ITYM DROP TABLE

2011-06-14 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from David E. Wheeler's message of lun jun 13 17:44:05 -0400 2011: I was reading the partitioning docs when I spotted this. I think it means to highlight the advantages of DROP TABLE over DELETE rather than ALTER TABLE. I think the

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 10:29 AM, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 0001-Add-reloscache-column-to-pg_class.patch 0002-Add-a-function-to-update-the-new-pg_class-cols.patch 0003-Add-ANALYZE-OSCACHE-VERBOSE-relation.patch 0004-Add-a-Hook-to-handle-OSCache-stats.patch

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-14 Thread Robert Haas
On Wed, May 25, 2011 at 3:05 PM, Simon Riggs si...@2ndquadrant.com wrote: Yes, that's correct. We can remove them from the normal commit record when nmsgs == 0. Leonardo, can you submit an updated version of this patch today that incorporates Simon's suggestion? The CommitFest starts tomorrow.

Re: [HACKERS] Patch: add GiST support for BOX @ POINT queries

2011-06-14 Thread Robert Haas
On Fri, Jun 10, 2011 at 6:16 AM, Hitoshi Harada umi.tan...@gmail.com wrote: 2011/2/24 Andrew Tipton andrew.t.tip...@gmail.com: While playing around with the BOX and POINT datatypes, I was surprised to note that BOX @ POINT (and likewise POINT @ BOX) queries were not using the GiST index I had

Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-14 Thread richhguard-monotone
I have left update_attstat which I'm unsure about, and have attached the updated patch handling the other cases. This will be linked in via the commitfest page. I picked commands/comment.c randomly and found the i = 0, i++ method of initializing the array made it harder for me to visualize

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Cédric Villemain
2011/6/14 Robert Haas robertmh...@gmail.com: On Tue, Jun 14, 2011 at 10:29 AM, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 0001-Add-reloscache-column-to-pg_class.patch 0002-Add-a-function-to-update-the-new-pg_class-cols.patch 0003-Add-ANALYZE-OSCACHE-VERBOSE-relation.patch

Re: [HACKERS] psql describe.c cleanup

2011-06-14 Thread Merlin Moncure
On Sat, May 7, 2011 at 2:40 PM, Josh Kupershmidt schmi...@gmail.com wrote: Hi all, I use psql's -E mode every now and then, copy-and-pasting and further tweaking the SQL displayed. Most queries are displayed terminated by a semicolon, but quite a few aren't, making copy-and-paste just a bit

Re: [HACKERS] ITYM DROP TABLE

2011-06-14 Thread David E. Wheeler
On Jun 14, 2011, at 8:03 AM, Tom Lane wrote: - commandALTER TABLE/ is far faster than a bulk operation. + commandALTER TABLE/ (to split out a sub-table from the partitioned + table) and commandDROP TABLE/ (to remove a partition altogether) are + both far faster than a

Re: [HACKERS] ITYM DROP TABLE

2011-06-14 Thread Alvaro Herrera
Excerpts from David E. Wheeler's message of mar jun 14 12:33:27 -0400 2011: On Jun 14, 2011, at 8:03 AM, Tom Lane wrote: - commandALTER TABLE/ is far faster than a bulk operation. + commandALTER TABLE/ (to split out a sub-table from the partitioned + table) and

Re: [HACKERS] procpid?

2011-06-14 Thread Jim Nasby
On Jun 13, 2011, at 10:56 AM, Simon Riggs wrote: If we were going to make changes like this, I'd suggest we save them up in a big bag for when we change major version number. Everybody in the world thinks that PostgreSQL v8 is compatible across all versions (8.0, 8.1, 8.2, 8.3, 8.4), and it

Re: [HACKERS] procpid?

2011-06-14 Thread Bruce Momjian
Jim Nasby wrote: On Jun 13, 2011, at 10:56 AM, Simon Riggs wrote: If we were going to make changes like this, I'd suggest we save them up in a big bag for when we change major version number. Everybody in the world thinks that PostgreSQL v8 is compatible across all versions (8.0, 8.1,

Re: [HACKERS] Why polecat and colugos are failing to build back branches

2011-06-14 Thread Robert Creager
On Jun 13, 2011, at 6:05 PM, Tom Lane t...@sss.pgh.pa.us wrote: I looked into $SUBJECT. There appear to be two distinct issues: 1. On colugos (OS X with LLVM), the ... However, because when using gcc that only results in a warning, we didn't back-patch it. Now it appears that it's an

Re: [HACKERS] ITYM DROP TABLE

2011-06-14 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Done that way (9.0 and beyond). Re-reading the actual commit, I notice that there's now a grammatical problem: the following sentence says It also entirely avoids the commandVACUUM/command overhead caused by a bulk commandDELETE/.

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Greg Smith
On 06/14/2011 11:04 AM, Robert Haas wrote: Even if the data were accurate and did not cause plan stability, we have no evidence that using it will improve real-world performance. That's the dependency Cédric has provided us a way to finally make progress on. Everyone says there's no

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 1:10 PM, Greg Smith g...@2ndquadrant.com wrote: On 06/14/2011 11:04 AM, Robert Haas wrote: Even if the data were accurate and did not cause plan stability, we have no evidence that using it will improve real-world performance. That's the dependency Cédric has provided

Re: [HACKERS] procpid?

2011-06-14 Thread Greg Smith
On 06/14/2011 11:44 AM, Jim Nasby wrote: Wouldn't it be better still to have both the new and old columns available for a while? That would produce the minimum amount of disruption to tools, etc. Doing this presumes the existence of a large number of tools where the author is unlikely to be

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 12:06 PM, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 1. ANALYZE happens far too infrequently to believe that any data taken at ANALYZE time will still be relevant at execution time. ANALYZE happens when people execute it, else it is auto-analyze and I am

Re: [HACKERS] procpid?

2011-06-14 Thread Jaime Casanova
On Tue, Jun 14, 2011 at 12:25 PM, Greg Smith g...@2ndquadrant.com wrote: Anyway, I want a larger change to pg_stat_activity than this one Well, Simon recomended to have a big bag of changes that justify break tools... and you have presented a good one item for that bag... Maybe we should start

[HACKERS] startupBufferPinWaitBufId vs. ProcGlobalShmemSize

2011-06-14 Thread Robert Haas
ProcGlobalShmemSize() currently includes code to allow space for startupBufferPinWaitBufId. But I think that's redundant, because that variable is stored in PROC_HDR *ProcGlobal, for which this function is separately allocating space. So I propose to apply the attached patch, barring objections.

Re: [HACKERS] procpid?

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 1:43 PM, Jaime Casanova ja...@2ndquadrant.com wrote: On Tue, Jun 14, 2011 at 12:25 PM, Greg Smith g...@2ndquadrant.com wrote: Anyway, I want a larger change to pg_stat_activity than this one Well, Simon recomended to have a big bag of changes that justify break

Re: [HACKERS] procpid?

2011-06-14 Thread Kevin Grittner
Greg Smith g...@2ndquadrant.com wrote: Doing this presumes the existence of a large number of tools where the author is unlikely to be keeping up with PostgreSQL development. I don't believe that theorized set of users actually exists. There could be a number of queries used for

[HACKERS] One-Shot Plans

2011-06-14 Thread Simon Riggs
Currently, the planner and executor are mostly independent of each other: the planner doesn't really know when the plan will be executed, and the executor doesn't know how recently the plan was made. We can work out the various paths through the traffic cop to see when a plan will be a one-shot -

Re: [HACKERS] One-Shot Plans

2011-06-14 Thread Bruce Momjian
Simon Riggs wrote: Currently, the planner and executor are mostly independent of each other: the planner doesn't really know when the plan will be executed, and the executor doesn't know how recently the plan was made. We can work out the various paths through the traffic cop to see when a

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-14 Thread Simon Riggs
On Tue, Jun 14, 2011 at 4:21 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, May 25, 2011 at 3:05 PM, Simon Riggs si...@2ndquadrant.com wrote: Yes, that's correct. We can remove them from the normal commit record when nmsgs == 0. Leonardo, can you submit an updated version of this patch

Re: [HACKERS] One-Shot Plans

2011-06-14 Thread Simon Riggs
On Tue, Jun 14, 2011 at 7:28 PM, Bruce Momjian br...@momjian.us wrote: Simon Riggs wrote: Currently, the planner and executor are mostly independent of each other: the planner doesn't really know when the plan will be executed, and the executor doesn't know how recently the plan was made. We

[HACKERS] Crash dumps

2011-06-14 Thread Radosław Smogura
Hello, Because, I work a little bit on streaming protocol and from time to time I have crashes. I want ask if you wont crash reporting (this is one of minors products from mmap playing) those what I have there is mmaped areas, and call stacks, and some other stuff. This based reports works

Re: [HACKERS] One-Shot Plans

2011-06-14 Thread Bruce Momjian
Simon Riggs wrote: On Tue, Jun 14, 2011 at 7:28 PM, Bruce Momjian br...@momjian.us wrote: Simon Riggs wrote: Currently, the planner and executor are mostly independent of each other: the planner doesn't really know when the plan will be executed, and the executor doesn't know how recently

Re: [HACKERS] ITYM DROP TABLE

2011-06-14 Thread Simon Riggs
On Mon, Jun 13, 2011 at 10:44 PM, David E. Wheeler da...@kineticode.com wrote: I was reading the partitioning docs when I spotted this. I think it means to highlight the advantages of DROP TABLE over DELETE rather than ALTER TABLE. Best, David diff --git a/doc/src/sgml/ddl.sgml

Re: [HACKERS] SSI patch renumbered existing 2PC resource managers??

2011-06-14 Thread Bruce Momjian
Bruce Momjian wrote: This argument seems a tad peculiar, since the *entire* *point* of pg_upgrade is to push physical files from one installation into another even though compatibility isn't guaranteed. It is the program's duty to understand enough to know whether it can transport the

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-14 Thread Robert Haas
On Tue, Jun 14, 2011 at 2:31 PM, Simon Riggs si...@2ndquadrant.com wrote: We don't need to be in a hurry here. As the reviewer I'm happy to give Leonardo some time, obviously no more than the end of the commit fest. Well, we certainly have the option to review and commit the patch any time up

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Cédric Villemain
2011/6/14 Robert Haas robertmh...@gmail.com: On Tue, Jun 14, 2011 at 12:06 PM, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 1. ANALYZE happens far too infrequently to believe that any data taken at ANALYZE time will still be relevant at execution time. ANALYZE happens when

Re: [HACKERS] ITYM DROP TABLE

2011-06-14 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar jun 14 13:04:30 -0400 2011: Alvaro Herrera alvhe...@commandprompt.com writes: Done that way (9.0 and beyond). Re-reading the actual commit, I notice that there's now a grammatical problem: the following sentence says It also entirely avoids

Re: [HACKERS] psql describe.c cleanup

2011-06-14 Thread Alvaro Herrera
Excerpts from Josh Kupershmidt's message of sáb may 07 16:40:35 -0300 2011: And while I'm griping about describe.c, is it just me or is the source code indentation in that file totally screwy? I'm using emacs and I've loaded the snippet for pgsql-c-mode from ./src/tools/editors/emacs.samples

[HACKERS] perltidy

2011-06-14 Thread Peter Eisentraut
How much do we care about applying perltidy, as described in src/tools/msvc/README, everywhere? I just ran it across the entire tree, using perltidy -b -bl -nsfs -naws -l=100 -ole=unix **/*.pl **/*.pm and it generated 6531 lines of (unified) diff, of which 357 are in src/tools/msvc/ itself. So

Re: [HACKERS] perltidy

2011-06-14 Thread Bruce Momjian
Peter Eisentraut wrote: How much do we care about applying perltidy, as described in src/tools/msvc/README, everywhere? I just ran it across the entire tree, using perltidy -b -bl -nsfs -naws -l=100 -ole=unix **/*.pl **/*.pm and it generated 6531 lines of (unified) diff, of which 357 are

Re: [HACKERS] perltidy

2011-06-14 Thread Magnus Hagander
On Tue, Jun 14, 2011 at 21:39, Bruce Momjian br...@momjian.us wrote: Peter Eisentraut wrote: How much do we care about applying perltidy, as described in src/tools/msvc/README, everywhere?  I just ran it across the entire tree, using perltidy -b -bl -nsfs -naws -l=100 -ole=unix **/*.pl

Re: pgbench cpu overhead (was Re: [HACKERS] lazy vxid locks, v1)

2011-06-14 Thread Jeff Janes
On Mon, Jun 13, 2011 at 9:09 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: I noticed that pgbench's doCustom (the function highest in the profile posted) returns doing nothing if the connection is supposed to be sleeping; seems an open door for busy waiting.  I didn't check the rest of

Re: [HACKERS] Detailed documentation for external calls (threading, shared resources etc)

2011-06-14 Thread Dimitri Fontaine
Seref Arikan serefari...@kurumsalteknoloji.com writes: This is actually a request for documentation guidance. I intend to develop an extension to postgresql. Basically I'd like to place calls to network using ZeroMQ, and I need to have detailed information about You didn't tell us about what

[HACKERS] Polecat quit unexpectdly

2011-06-14 Thread Robert Creager
Stack trace, nothing else. Now that the horse has left the barn, I changed to keep error builds...Process: postgres [17457]Path: /Volumes/High

Re: pgbench cpu overhead (was Re: [HACKERS] lazy vxid locks, v1)

2011-06-14 Thread Stefan Kaltenbrunner
On 06/14/2011 02:27 AM, Jeff Janes wrote: On Mon, Jun 13, 2011 at 7:03 AM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: ... so it seems that sysbench is actually significantly less overhead than pgbench and the lower throughput at the higher conncurency seems to be cause by sysbench

Re: [HACKERS] Polecat quit unexpectdly

2011-06-14 Thread Kevin Grittner
Robert Creager robert.crea...@oracle.com wrote: Stack trace, nothing else. 3 postgres 0x00010005cafa multixact_twophase_postcommit + 74 (multixact.c:1367) 4 postgres 0x00010005deab ProcessRecords + 91 (twophase.c:1407) 5

Re: [HACKERS] procpid?

2011-06-14 Thread Greg Smith
On 06/14/2011 02:20 PM, Kevin Grittner wrote: Just on our Wiki pages we have some queries available for copy/paste which would need multiple versions while both column names were in supported versions of the software: http://wiki.postgresql.org/wiki/Lock_dependency_information

Re: [HACKERS] procpid?

2011-06-14 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of mar jun 14 12:59:15 -0400 2011: Well, someone doing SELECT *, which is probably 90% of the users, are going to be pretty confused by duplicate columns, asking, What is the difference? For those people this would make things worse than they are now.

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Alvaro Herrera
Excerpts from Cédric Villemain's message of mar jun 14 10:29:36 -0400 2011: Attached are updated patches without the plugin itself. I've also added the cache_page_cost GUC, this one is not per tablespace, like others page_cost. There are 6 patches:

[HACKERS] possible connection leak in dblink?

2011-06-14 Thread Peter Eisentraut
With gcc 4.6, I get this warning: dblink.c: In function ‘dblink_send_query’: dblink.c:620:7: warning: variable ‘freeconn’ set but not used [-Wunused-but-set-variable] I don't know much about the internals of dblink, but judging from the surrounding code, I guess that this fix is necessary:

Re: [HACKERS] One-Shot Plans

2011-06-14 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: Currently, the planner and executor are mostly independent of each other: the planner doesn't really know when the plan will be executed, and the executor doesn't know how recently the plan was made. We can work out the various paths through the

Re: [HACKERS] Polecat quit unexpectdly

2011-06-14 Thread Kevin Grittner
Robert Creager robert.crea...@oracle.com wrote: You believe it was related to the flurry of errors that popped up then. I haven't looked at all the error in the flurry. I think your particular report is consistent with being caused by this commit:

Re: [HACKERS] procpid?

2011-06-14 Thread Peter Eisentraut
On tis, 2011-06-14 at 13:50 -0400, Robert Haas wrote: There are real problems with the idea of having one release where we break everything that we want to break - mostly from a process standpoint. We aren't always good at being organized and disciplined, and coming up with a multi-year plan

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Cédric Villemain
2011/6/14 Alvaro Herrera alvhe...@commandprompt.com: Excerpts from Cédric Villemain's message of mar jun 14 10:29:36 -0400 2011: Attached are updated patches without the plugin itself. I've also added the cache_page_cost GUC, this one is not per tablespace, like others page_cost. There are

Re: [HACKERS] creating CHECK constraints as NOT VALID

2011-06-14 Thread Alvaro Herrera
Excerpts from Alvaro Herrera's message of lun jun 13 18:08:12 -0400 2011: Excerpts from Dean Rasheed's message of sáb jun 11 09:32:15 -0400 2011: I think that you also need to update the constraint exclusion code (get_relation_constraints() or nearby), otherwise the planner might exclude a

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Alvaro Herrera
Excerpts from Cédric Villemain's message of mar jun 14 17:10:20 -0400 2011: If we can have ALTER TABLE running on heavy workload, why not. I am bit scared by the effect of such reloption, it focus on HINT oriented strategy when I would like to allow a dynamic strategy from the server. This

Re: [HACKERS] creating CHECK constraints as NOT VALID

2011-06-14 Thread Jaime Casanova
On Tue, Jun 14, 2011 at 4:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Alvaro Herrera's message of lun jun 13 18:08:12 -0400 2011: Excerpts from Dean Rasheed's message of sáb jun 11 09:32:15 -0400 2011: I think that you also need to update the constraint exclusion

Re: [HACKERS] Why polecat and colugos are failing to build back branches

2011-06-14 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 06/13/2011 08:05 PM, Tom Lane wrote: I looked into $SUBJECT. There appear to be two distinct issues: ... I think we can be a bit more liberal about build patches than things that can affect the runtime behaviour. So +1 for fixing both of

Re: [HACKERS] procpid?

2011-06-14 Thread Bruce Momjian
Peter Eisentraut wrote: On tis, 2011-06-14 at 13:50 -0400, Robert Haas wrote: There are real problems with the idea of having one release where we break everything that we want to break - mostly from a process standpoint. We aren't always good at being organized and disciplined, and

Re: [HACKERS] procpid?

2011-06-14 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On tis, 2011-06-14 at 13:50 -0400, Robert Haas wrote: There are real problems with the idea of having one release where we break everything that we want to break - mostly from a process standpoint. We aren't always good at being organized and

Re: [HACKERS] Why polecat and colugos are failing to build back branches

2011-06-14 Thread Andrew Dunstan
On 06/14/2011 05:45 PM, Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: On 06/13/2011 08:05 PM, Tom Lane wrote: I looked into $SUBJECT. There appear to be two distinct issues: ... I think we can be a bit more liberal about build patches than things that can affect the runtime

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Cédric Villemain's message of mar jun 14 10:29:36 -0400 2011: 0001-Add-reloscache-column-to-pg_class.patch Hmm, do you really need this to be a new column? Would it work to have it be a reloption? If it's to be updated in the

Re: [HACKERS] Why polecat and colugos are failing to build back branches

2011-06-14 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 06/14/2011 05:45 PM, Tom Lane wrote: I've committed patches that fix these issues on my own OS X machine, Well, OSX is just using our usual *nix paraphernalia, so if it's broken won't all such platforms probably be broken too? Yes, certainly.

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Greg Smith
On 06/14/2011 01:16 PM, Robert Haas wrote: But there's no reason that code (which may or may not eventually prove useful) has to be incorporated into the main tree. We don't commit code so people can go benchmark it; we ask for the benchmarking to be done first, and then if the results are

Re: [HACKERS] [WIP] cache estimates, cache access cost

2011-06-14 Thread Bruce Momjian
Greg Smith wrote: On 06/14/2011 01:16 PM, Robert Haas wrote: But there's no reason that code (which may or may not eventually prove useful) has to be incorporated into the main tree. We don't commit code so people can go benchmark it; we ask for the benchmarking to be done first, and

  1   2   >