[HACKERS] Re: [GENERAL] Symbols and versioning of binary releases; running a symbol server

2011-06-16 Thread Magnus Hagander
On Thu, Jun 16, 2011 at 02:52, Craig Ringer cr...@postnewspapers.com.au wrote: Hi (EnterpriseDB) folks I've been working with someone off list to get some information about a crash they encounter during a batch run. We're generating a crash dump, but I'm having some issues getting matching

[HACKERS] [Streaming] Datum compression

2011-06-16 Thread Radosław Smogura
Hello, I think about following functionality to add to streaming. In some way earlier or later soemone will add possibility for gzip communication. As I try to make streaming, I wonder if it is possible to change TOAST compression to GZIP/zLib, currently is LZMA. I want to make this: if user

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2011-06-16 Thread Pavel Stehule
2011/6/15 Pavel Stehule pavel.steh...@gmail.com: Hello I try to apply your patch, but it is finished with some failed hinks. Please, can you refresh your patch Regards Pavel [pavel@nemesis postgresql]$ patch -p1 pghba.patch patching file src/backend/libpq/hba.c Hunk #1 succeeded at

Re: [HACKERS] creating CHECK constraints as NOT VALID

2011-06-16 Thread Jaime Casanova
On Wed, Jun 15, 2011 at 7:08 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Yeah, nothing serious.  Updated patch attached.  The wording in the doc changes could probably use some look over. looks good to me... at least it compiles, and function as i would expect... tomorrow i will read

Re: [WIP] Support for ANY/ALL(array) op scalar (Was: Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY)

2011-06-16 Thread Florian Pflug
On Jun16, 2011, at 04:19 , Tom Lane wrote: Florian Pflug f...@phlo.org writes: Comments are extremely welcome, especially ones regarding the overall approach taken in this patch. If people consider that to be acceptable, I'd try to add the missing features and add documentation. Quite

Re: [HACKERS] WIP: Fast GiST index build

2011-06-16 Thread Alexander Korotkov
Actually, I would like to measure CPU and IO load independently for more comprehensive benchmarks. Can you advice me some appropriate tools for it? -- With best regards, Alexander Korotkov.

[HACKERS] Re: [GENERAL] Symbols and versioning of binary releases; running a symbol server

2011-06-16 Thread Craig Ringer
On 16/06/2011 2:47 PM, Magnus Hagander wrote: We could (once we've figured out why it's wrong) put that number in the version string as well. Or some other number - if we can pick a good one. I don't think the EDB installers should have a *different* string than what you'd get if you built the

Re: [HACKERS] .gitignore for some of cygwin files

2011-06-16 Thread Peter Eisentraut
On tor, 2011-06-09 at 16:25 +0200, Magnus Hagander wrote: Based on this list, a global exclude for *.exe and lib*dll.def seems reasonable. We already have finer-grained excludes for various lib*dll.def variations in the libpq and ecpg subdirectories. Those should be cleaned up if we are adding

Re: [HACKERS] Re: [GENERAL] Symbols and versioning of binary releases; running a symbol server

2011-06-16 Thread Dave Page
On Thu, Jun 16, 2011 at 11:31 AM, Craig Ringer cr...@postnewspapers.com.au wrote: In this case a different (or additional) string for EDB releases is exactly what I'm after - a string that uniquely identifies a release made with an EDB installer, so that 8.4.2-1 can be reliably identified as

Re: [HACKERS] Re: [GENERAL] Symbols and versioning of binary releases; running a symbol server

2011-06-16 Thread Craig Ringer
On 16/06/2011 6:38 PM, Dave Page wrote: To download 8.4.2-2 at all I had to go to download the latest EDB release, note the URL and play substitution games. Maybe I just didn't find the old versions link that'll turn out to be lurking somewhere. I'm not sure I understand the problem. We ship

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Florian Pflug
Hi On May14, 2011, at 00:49 , Alexey Klyukin wrote: The patch forces the parser to report all errors (max 100) from the ProcessConfigFile/ParseConfigFp. Currently, only the first parse error or an invalid directive is reported. Reporting all of them is crucial to automatic validation of

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Peter Geoghegan
I had another quick look-over this patch, and realised that I made a minor mistake: +void +ReleasePostmasterDeathWatchHandle(void) +{ + /* MyProcPid won't have been set yet */ + Assert(PostmasterPid != getpid()); + /* Please don't ask twice */ +

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Heikki Linnakangas
On 16.06.2011 15:07, Peter Geoghegan wrote: I had another quick look-over this patch, and realised that I made a minor mistake: +void +ReleasePostmasterDeathWatchHandle(void) +{ + /* MyProcPid won't have been set yet */ + Assert(PostmasterPid != getpid()); + /* Please don't

Re: [HACKERS] pg_upgrade using appname to lock out other users

2011-06-16 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: Right, we will re-check at the time they do the actual upgrade. This was requested so people can prepare for the real upgrade without having to stop their live server. Exactly. A very good thing to have, and something which I needed and would have

[HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Radosław Smogura
Hello, I'm sending following patch which disables optimization when --enable-debug is passed. It was nasty (for me, at least) that debug build required passing of CFLAGS with -O0 to get nice traceable code. Regards, Radekdiff --git a/configure.in b/configure.in old mode 100644 new mode

[HACKERS] reminder: buildfarm members need to add 9.1

2011-06-16 Thread Andrew Dunstan
We have branched somewhat earlier than has been usual for release 9.1. Buildfarm animal owners who have not already done so need to add REL9_1_STABLE to their rotations. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Peter Geoghegan
On 16 June 2011 13:15, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Hmm, I'm not sure having the pid in that error message is too useful in the first place. The process was just spawned, and it will die at that error. When you try to debug that sort of error, what you would

Re: [HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Radosław Smogura
On Thu, 16 Jun 2011 14:30:27 +0200, Radosław Smogura wrote: Hello, I'm sending following patch which disables optimization when --enable-debug is passed. It was nasty (for me, at least) that debug build required passing of CFLAGS with -O0 to get nice traceable code. Regards, Radek Sorry for

Re: [HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Florian Pflug
On Jun16, 2011, at 14:30 , Radosław Smogura wrote: I'm sending following patch which disables optimization when --enable-debug is passed. It was nasty (for me, at least) that debug build required passing of CFLAGS with -O0 to get nice traceable code. Unfortunately, with some compilers (gcc,

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Leonardo Francalanci
With regards to the naming, I think it would be better if we kept XLOG_XACT_COMMIT record exactly as it is now, and make the second record an entirely new record called XLOG_XACT_COMMIT_FASTPATH. That way we retain backwards compatibility. If you'd like to rework like that please,

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Simon Riggs
On Wed, Jun 15, 2011 at 10:55 AM, Leonardo Francalanci m_li...@yahoo.it wrote:  On Wed, May 25, 2011 at 3:05 PM, Simon Riggs si...@2ndquadrant.com wrote: Leonardo, can you  submit an updated version of this patch today that incorporates Simon's  suggestion? Mmmh, maybe it was simpler

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Simon Riggs
On Thu, Jun 16, 2011 at 2:00 PM, Leonardo Francalanci m_li...@yahoo.it wrote: With regards to the naming, I think it would be better if we  kept XLOG_XACT_COMMIT record exactly as it is now, and make the  second record an entirely new record called XLOG_XACT_COMMIT_FASTPATH.  That way we

Re: [HACKERS] Small SSI issues

2011-06-16 Thread Heikki Linnakangas
On 15.06.2011 19:10, Kevin Grittner wrote: There is an unnecessary include of predicate.h in nbtree.c we should delete. That seems safe enough. ... It seems like it might be a good idea to apply pgindent formating to the latest SSI changes, to minimize conflict on back-patching any bug fixes.

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Robert Haas
On Thu, Jun 16, 2011 at 7:25 AM, Simon Riggs si...@2ndquadrant.com wrote: With regards to the naming, I think it would be better if we kept XLOG_XACT_COMMIT record exactly as it is now, and make the second record an entirely new record called XLOG_XACT_COMMIT_FASTPATH. That way we retain

Re: [HACKERS] Small SSI issues

2011-06-16 Thread Heikki Linnakangas
On 15.06.2011 19:10, Kevin Grittner wrote: There is one issue you raised in this post: http://archives.postgresql.org/message-id/4def3194.6030...@enterprisedb.com Robert questioned whether it should be 9.1 material here:

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Robert Haas
On Thu, Jun 16, 2011 at 9:22 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 16, 2011 at 7:25 AM, Simon Riggs si...@2ndquadrant.com wrote: With regards to the naming, I think it would be better if we kept XLOG_XACT_COMMIT record exactly as it is now, and make the second record an

Re: [HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Bernd Helmle
--On 16. Juni 2011 14:30:27 +0200 Radosław Smogura rsmog...@softperience.eu wrote: Hello, I'm sending following patch which disables optimization when --enable-debug is passed. It was nasty (for me, at least) that debug build required passing of CFLAGS with -O0 to get nice traceable

Re: [HACKERS] patch: update README-SSI

2011-06-16 Thread Heikki Linnakangas
On 15.06.2011 23:28, Dan Ports wrote: +SSI is based on the observation [2] that each snapshot isolation +anomaly corresponds to a cycle that contains a dangerous structure +of two adjacent rw-conflict edges: + + Tin -- Tpivot -- Tout +rw rw + +SSI works by

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Simon Riggs
On Thu, Jun 16, 2011 at 2:22 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 16, 2011 at 7:25 AM, Simon Riggs si...@2ndquadrant.com wrote: With regards to the naming, I think it would be better if we kept XLOG_XACT_COMMIT record exactly as it is now, and make the second record an

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Leonardo Francalanci
The important thing is that we retain backwards compatibility with current XLOG_XACT_COMMIT. I'm not worried what we call the other one. Ok, let me see if I got it right: #define XLOG_XACT_COMMIT0x00 should become: #define XLOG_XACT_COMMIT_WITH_INFO 0x00 and I'll add a

Re: [HACKERS] pg_upgrade using appname to lock out other users

2011-06-16 Thread Bruce Momjian
Tom Lane wrote: Ross J. Reedstrom reeds...@rice.edu writes: As an operations guy, the idea of an upgrade using a random, non-repeatable port selection gives me the hebejeebees. Yeah, I agree. The latest version of the patch doesn't appear to have any random component to it, though --- it

Re: [HACKERS] Why polecat and colugos are failing to build back branches

2011-06-16 Thread Robert Creager
On Jun 15, 2011, at 7:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: ... installation paths. About the only good thing to be said about it is that these characters are so troublesome that Unix users are unlikely to use them in directory names anyway. So I'm guessing you don't want this path

Re: [HACKERS] procpid?

2011-06-16 Thread Greg Smith
On 06/15/2011 04:13 AM, Rainer Pruy wrote: I much prefer reading an IDLE in transaction on a quick glance over having to search a column and recognize a t from an f to find out whether there is a transaction pending or not. This is a fair observation. If we provide a second view here

Re: [HACKERS] [Streaming] Datum compression

2011-06-16 Thread Tom Lane
=?utf-8?q?Rados=C5=82aw_Smogura?= rsmog...@softperience.eu writes: I think about following functionality to add to streaming. In some way earlier or later soemone will add possibility for gzip communication. As I try to make streaming, I wonder if it is possible to change TOAST

Re: [HACKERS] psql describe.c cleanup

2011-06-16 Thread Merlin Moncure
On Wed, Jun 15, 2011 at 9:01 AM, Merlin Moncure mmonc...@gmail.com wrote: On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure mmonc...@gmail.com wrote: What I do wonder though is if the ; appending should really be

Re: [HACKERS] pg_upgrade using appname to lock out other users

2011-06-16 Thread Ross J. Reedstrom
On Thu, Jun 16, 2011 at 09:48:12AM -0400, Bruce Momjian wrote: Tom Lane wrote: Ross J. Reedstrom reeds...@rice.edu writes: As an operations guy, the idea of an upgrade using a random, non-repeatable port selection gives me the hebejeebees. Yeah, I agree. The latest version of the

Re: [HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Tom Lane
Florian Pflug f...@phlo.org writes: On Jun16, 2011, at 14:30 , Radosław Smogura wrote: I'm sending following patch which disables optimization when --enable-debug is passed. It was nasty (for me, at least) that debug build required passing of CFLAGS with -O0 to get nice traceable code.

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Heikki Linnakangas
Peter Geoghegan wrote: --- 247,277 * do that), and the select() will return immediately. */ drainSelfPipe(); ! if (latch-is_set (wakeEvents WL_LATCH_SET)) ! { ! result |= WL_LATCH_SET; !

Re: [HACKERS] procpid?

2011-06-16 Thread Greg Smith
Since the CF is upon us and discussion is settling, let's see if I can wrap this bikeshedding up into a more concrete proposal that someone can return to later. The ideas floating around have gelled into: -Add a new pg_stat_sessions function that is implemented similarly to pg_stat_activity.

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Jun 16, 2011 at 7:25 AM, Simon Riggs si...@2ndquadrant.com wrote: With regards to the naming, I think it would be better if we kept XLOG_XACT_COMMIT record exactly as it is now, and make the second record an entirely new record called

Re: [HACKERS] Why polecat and colugos are failing to build back branches

2011-06-16 Thread Tom Lane
Robert Creager rob...@logicalchaos.org writes: On Jun 15, 2011, at 7:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: installation paths. About the only good thing to be said about it is that these characters are so troublesome that Unix users are unlikely to use them in directory names anyway. So

Re: [HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Florian Pflug
On Jun16, 2011, at 16:10 , Tom Lane wrote: Florian Pflug f...@phlo.org writes: I usually use -O1 for debug builds, these are usually still at least somewhat debuggable with gdb. I tend to do that too, but I still think that folding it into --enable-debug would be a mistake. +1. I didn't

Re: [HACKERS] On-the-fly index tuple deletion vs. hot_standby

2011-06-16 Thread Noah Misch
On Thu, Jun 16, 2011 at 12:02:47AM +0100, Simon Riggs wrote: On Tue, Jun 14, 2011 at 5:28 AM, Noah Misch n...@leadboat.com wrote: On Mon, Jun 13, 2011 at 04:16:06PM +0100, Simon Riggs wrote: On Mon, Jun 13, 2011 at 3:11 AM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jun 12, 2011 at

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Peter Geoghegan
On 16 June 2011 15:27, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I don't understand that comment. Why can't e.g postmaster death happen at the same time as a latch is set? I think the code is fine as it is, we just need to document that if there are several events that

Re: [HACKERS] Re: Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Florian Pflug
On May26, 2011, at 11:25 , Peter Geoghegan wrote: I'm a bit disappointed that no one has commented on this yet. I would have appreciated some preliminary feedback. I noticed to your patch doesn't seem to register a SIGIO handler, i.e. it doesn't use async IO machinery (or rather a tiny part

Re: [HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Greg Smith
On 06/16/2011 10:10 AM, Tom Lane wrote: I could see providing some other nonstandard configure switch that changed the default -O level ... but realistically, would that do anything that you couldn't already do by setting CFLAGS, ie ./configure CFLAGS=-O0 -g I think a small

Re: [HACKERS] pg_upgrade using appname to lock out other users

2011-06-16 Thread Christopher Browne
On Thu, Jun 16, 2011 at 1:48 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Ross J. Reedstrom reeds...@rice.edu writes: As an operations guy, the idea of an upgrade using a random, non-repeatable port selection gives me the hebejeebees. Yeah, I agree.  The latest version of the

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Alexey Klyukin
Florian, On Jun 16, 2011, at 2:34 PM, Florian Pflug wrote: Hi On May14, 2011, at 00:49 , Alexey Klyukin wrote: The patch forces the parser to report all errors (max 100) from the ProcessConfigFile/ParseConfigFp. Currently, only the first parse error or an invalid directive is reported.

Re: [HACKERS] procpid?

2011-06-16 Thread Greg Smith
On 06/15/2011 12:41 PM, Robert Haas wrote: But I will note that we had better be darn sure to make all the changes we want to make in one go, because I dowanna have to create pg_sessions2 (or pg_tessions?) in a year or three. I just added a new section to the TODO to start collecting up

[HACKERS] [WIP] [Stream] Preview of pg_type changes

2011-06-16 Thread Radosław Smogura
Hello, Here I would like to expose changes to pg_type and type infrastructure about streaming. Changes are as follows: - added new column typstreamin typestremout - general contract for those is for streamin same as receive (receive use internal), for streamout it is (internal, type) -

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Heikki Linnakangas
This patch breaks silent_mode=on. In silent_mode, postmaster forks early on, to detach from the controlling tty. It uses fork_process() for that, which with patch closes the write end of the postmaster-alive pipe, but that's wrong because the child becomes the postmaster process. On a

Re: [HACKERS] procpid?

2011-06-16 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 Or perhaps pg_connections. Yes, +1 to making things fully backwards compatible by keeping pg_stat_activity around but making a better designed and better named table (view/SRF/whatever). I thought about that too when reading the thread the

Re: [HACKERS] [WIP] [Stream] Preview of pg_type changes

2011-06-16 Thread Pavel Stehule
Hello 2011/6/16 Radosław Smogura rsmog...@softperience.eu: Hello, Here I would like to expose changes to pg_type and type infrastructure about streaming. Changes are as follows: - added new column typstreamin typestremout - general contract for those is for streamin same as receive (receive

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Florian Pflug
On Jun16, 2011, at 17:23 , Alexey Klyukin wrote: On Jun 16, 2011, at 2:34 PM, Florian Pflug wrote: The first problem I ran into when I tried to test this is that it *only* reports multiple errors during config file reload on SIHUP, not during postmaster startup. I guess it's been done that way

[HACKERS] POSIX shared memory patch status

2011-06-16 Thread Heikki Linnakangas
What's the current state of the POSIX shared memory patch? I grabbed the patch from http://archives.postgresql.org/message-id/d9edacf7-53f1-4355-84f8-2e74cd19d...@themactionfaction.com and it doesn't seem to apply cleanly any more. Are you planning to continue working on it? If I understood

Re: [HACKERS] On-the-fly index tuple deletion vs. hot_standby

2011-06-16 Thread Simon Riggs
On Thu, Jun 16, 2011 at 3:47 PM, Noah Misch n...@leadboat.com wrote: On Thu, Jun 16, 2011 at 12:02:47AM +0100, Simon Riggs wrote: On Tue, Jun 14, 2011 at 5:28 AM, Noah Misch n...@leadboat.com wrote: On Mon, Jun 13, 2011 at 04:16:06PM +0100, Simon Riggs wrote: On Mon, Jun 13, 2011 at 3:11 AM,

Re: [HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Alvaro Herrera
Excerpts from Radosław Smogura's message of jue jun 16 08:30:27 -0400 2011: Hello, I'm sending following patch which disables optimization when --enable-debug is passed. It was nasty (for me, at least) that debug build required passing of CFLAGS with -O0 to get nice traceable code. I

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-16 Thread Alvaro Herrera
Excerpts from Peter Geoghegan's message of jue jun 16 08:42:39 -0400 2011: On 16 June 2011 13:15, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Hmm, I'm not sure having the pid in that error message is too useful in the first place. The process was just spawned, and it will

Re: [HACKERS] [WIP] [Stream] Preview of pg_type changes

2011-06-16 Thread Radoslaw Smogura
This is some attempt to make streaming protocol. Difference is that instead of returning bytes it is intended to take stream, and self-stream. I posted, one day, some requirements for streaming, I can't reference it now, as I am away from computer. Regards, Radek -Original Message-

Re: [HACKERS] On-the-fly index tuple deletion vs. hot_standby

2011-06-16 Thread Simon Riggs
On Thu, Jun 16, 2011 at 4:53 PM, Simon Riggs si...@2ndquadrant.com wrote: I agree with your suggested fix. Please ignore the previous patch, which was sent in error. Here's the fix. I'll apply this tomorrow morning if we all still agree. --  Simon Riggs  

Re: [HACKERS] FOREIGN TABLE doc fix

2011-06-16 Thread Ross J. Reedstrom
Right, but I think he needs the it's not easy, here's the whole workflow overview first. Ross -- Ross Reedstrom, Ph.D. reeds...@rice.edu Systems Engineer Admin, Research Scientistphone: 713-348-6166 Connexions http://cnx.org

Re: [HACKERS] On-the-fly index tuple deletion vs. hot_standby

2011-06-16 Thread Noah Misch
On Thu, Jun 16, 2011 at 04:53:41PM +0100, Simon Riggs wrote: On Thu, Jun 16, 2011 at 3:47 PM, Noah Misch n...@leadboat.com wrote: Thanks. ?We still hit a conflict when btpo.xact == RecentGlobalXmin and the standby has a transaction older than any master transaction. ?This happens because

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Alvaro Herrera
Excerpts from Leonardo Francalanci's message of jue jun 16 09:00:15 -0400 2011: Should I also change the struct name from xl_xact_commit to xl_xact_commit_fast_path? Yes, please. -- Álvaro Herrera alvhe...@commandprompt.com The PostgreSQL Company - Command Prompt, Inc. PostgreSQL

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Simon Riggs
On Thu, Jun 16, 2011 at 3:14 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Jun 16, 2011 at 7:25 AM, Simon Riggs si...@2ndquadrant.com wrote: With regards to the naming, I think it would be better if we kept XLOG_XACT_COMMIT record exactly as it is

Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-16 Thread Florian Pflug
On Jun14, 2011, at 17:47 , richhguard-monot...@yahoo.co.uk wrote: This patch makes the intent of each initialization clear by using the constants directly instead of in a comment, and has the effect of being able to verify each line on it's own. The original requires verification of the

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Robert Haas
On Thu, Jun 16, 2011 at 12:12 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, Jun 16, 2011 at 3:14 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Jun 16, 2011 at 7:25 AM, Simon Riggs si...@2ndquadrant.com wrote: With regards to the naming, I

Re: [HACKERS] procpid?

2011-06-16 Thread Tom Lane
Greg Smith g...@2ndquadrant.com writes: The only other item related to this view on the TODO was Have pg_stat_activity display query strings in the correct client encoding. That might be worthwhile to bundle into this rework, but it doesn't seem something that impacts the UI such that it

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Alexey Klyukin
On Jun 16, 2011, at 6:49 PM, Florian Pflug wrote: On Jun16, 2011, at 17:23 , Alexey Klyukin wrote: On Jun 16, 2011, at 2:34 PM, Florian Pflug wrote: The first problem I ran into when I tried to test this is that it *only* reports multiple errors during config file reload on SIHUP, not during

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: That's a reasonable point, but I still don't really like the name fastpath, because it's not faster, and it's not a path. It's just smaller. How about xl_xact_commit_simple or xl_xact_commit_compact or something like that? bikeshed

Re: [HACKERS] POSIX shared memory patch status

2011-06-16 Thread Robert Haas
On Thu, Jun 16, 2011 at 11:51 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: What's the current state of the POSIX shared memory patch? I grabbed the patch from http://archives.postgresql.org/message-id/d9edacf7-53f1-4355-84f8-2e74cd19d...@themactionfaction.com and it

Re: [HACKERS] procpid?

2011-06-16 Thread Bernd Helmle
--On 16. Juni 2011 15:33:35 + Greg Sabino Mullane g...@turnstep.com wrote: No, this is clearly connections, not sessions. At least based on the items in the postgresql.conf file, especially max_connections (probably one of the items most closely associated with pg_stat_activity) Well,

Re: [HACKERS] procpid?

2011-06-16 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: The point is that another backend's entry could be in a different *server* encoding, and what do you do if there's no equivalent character in your encoding? My first thought was that it was just a matter of picking a character to represent the unprintable

Re: [HACKERS] Why polecat and colugos are failing to build back branches

2011-06-16 Thread Robert Haas
On Thu, Jun 16, 2011 at 9:48 AM, Robert Creager rob...@logicalchaos.org wrote: On Jun 15, 2011, at 7:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: ... installation paths.  About the only good thing to be said about it is that these characters are so troublesome that Unix users are unlikely to

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Florian Pflug
On Jun16, 2011, at 18:46 , Alexey Klyukin wrote: On Jun 16, 2011, at 6:49 PM, Florian Pflug wrote: Hm, wouldn't a test for context == PGC_POSTMASTER be more appropriate? In such a case the errors caused by command-line arguments won't stop the postmaster. PGC_S_FILE seems to handle this

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-16 Thread Alvaro Herrera
Thanks, I am looking at the new version from Bernd's git repo. One problem I noticed is that it doesn't really work correctly for all callers of heap_create_with_catalog -- you're only passing the cooked not null constraints in DefineRelation, but there are some other places that call

Re: [HACKERS] Patch - Debug builds without optimization

2011-06-16 Thread Alvaro Herrera
Excerpts from Bernd Helmle's message of jue jun 16 09:37:24 -0400 2011: --On 16. Juni 2011 14:30:27 +0200 Radosław Smogura rsmog...@softperience.eu wrote: Hello, I'm sending following patch which disables optimization when --enable-debug is passed. It was nasty (for me, at

Re: [HACKERS] POSIX shared memory patch status

2011-06-16 Thread A.M.
On Jun 16, 2011, at 11:51 AM, Heikki Linnakangas wrote: What's the current state of the POSIX shared memory patch? I grabbed the patch from http://archives.postgresql.org/message-id/d9edacf7-53f1-4355-84f8-2e74cd19d...@themactionfaction.com and it doesn't seem to apply cleanly any more.

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-16 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: So, question: do we need pg_constraint rows to exist for all NOT NULL constraints, including those in system catalogs, and including those in bootstrap catalogs? If we're going to require that, we're going to need to add a few initial data

Re: [HACKERS] patch: update README-SSI

2011-06-16 Thread Dan Ports
On Thu, Jun 16, 2011 at 04:39:09PM +0300, Heikki Linnakangas wrote: There's no mention on what T1 is. I believe it's supposed to be Tin, in the terminology used in the graph. Yes, I changed the naming after I originally wrote it, and missed a couple spots. T1 should be Tin. I don't see how

Re: [HACKERS] pg_upgrade using appname to lock out other users

2011-06-16 Thread Robert Haas
On Wed, Jun 15, 2011 at 1:35 PM, Bruce Momjian br...@momjian.us wrote: I now believe we are overthinking all this.  pg_upgrade has always supported specification of a port number.  Why not just tell users to specify an unused port number 1023, and not to use the default value? 1. Because it

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-16 Thread Robert Haas
On Thu, Jun 16, 2011 at 1:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Possible solution is to leave bootstrap's behavior alone, and have a step during initdb's post-bootstrap stuff that creates a matching pg_constraint row for every pg_attribute entry that's marked attnotnull. That seems like a

Re: [HACKERS] use less space in xl_xact_commit patch

2011-06-16 Thread Simon Riggs
On Thu, Jun 16, 2011 at 5:34 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 16, 2011 at 12:12 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, Jun 16, 2011 at 3:14 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Jun 16, 2011 at 7:25 AM,

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-16 Thread Robert Haas
On Thu, Jun 16, 2011 at 12:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: We deprecated those names for the geometric operators largely because there wasn't any visual correlation between the commutator pairs. I can't see introducing the same pairing for regex operators if we already decided the

Re: [HACKERS] patch: update README-SSI

2011-06-16 Thread Heikki Linnakangas
On 16.06.2011 20:33, Dan Ports wrote: On Thu, Jun 16, 2011 at 04:39:09PM +0300, Heikki Linnakangas wrote: There's no mention on what T1 is. I believe it's supposed to be Tin, in the terminology used in the graph. Yes, I changed the naming after I originally wrote it, and missed a couple

Re: [HACKERS] planinstr, showing planner time on EXPLAIN

2011-06-16 Thread Robert Haas
On Tue, Jun 14, 2011 at 11:18 PM, Hitoshi Harada umi.tan...@gmail.com wrote: Yesterday on PGXN I just released the first version of planinstr, a plugin module to append planner time to EXPLAIN. I post this here since it is mostly for developers. http://www.pgxn.org/dist/planinstr/ db1=#

Re: [HACKERS] WIP: Fast GiST index build

2011-06-16 Thread Alexander Korotkov
My current idea is to measure number of IO accesses by pg_stat_statements and measure CPU usage by /proc/PID/stat. Any thoughts? -- With best regards, Alexander Korotkov. On Thu, Jun 16, 2011 at 1:33 PM, Alexander Korotkov aekorot...@gmail.comwrote: Actually, I would like to measure CPU

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I'm having trouble avoiding the conclusion that we're trying to shove a round peg into a square hole. The idea that we have to have a commutator for every operator just because we don't handle left and right symmetrically sits poorly with me. I can't

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Alexey Klyukin
On Jun 16, 2011, at 8:01 PM, Florian Pflug wrote: On Jun16, 2011, at 18:46 , Alexey Klyukin wrote: On Jun 16, 2011, at 6:49 PM, Florian Pflug wrote: Hm, wouldn't a test for context == PGC_POSTMASTER be more appropriate? In such a case the errors caused by command-line arguments won't stop

Re: [HACKERS] proposal: a validator for configuration files

2011-06-16 Thread Florian Pflug
On Jun16, 2011, at 20:14 , Alexey Klyukin wrote: On Jun 16, 2011, at 8:01 PM, Florian Pflug wrote: On Jun16, 2011, at 18:46 , Alexey Klyukin wrote: I just recalled a reason for counting the total number of errors. There is a condition that checks that the total number of errors is less than

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-16 Thread Florian Pflug
On Jun16, 2011, at 19:54 , Robert Haas wrote: On Thu, Jun 16, 2011 at 12:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: We deprecated those names for the geometric operators largely because there wasn't any visual correlation between the commutator pairs. I can't see introducing the same pairing

Re: [HACKERS] WIP: Fast GiST index build

2011-06-16 Thread Heikki Linnakangas
On 16.06.2011 21:13, Alexander Korotkov wrote: My current idea is to measure number of IO accesses by pg_stat_statements and measure CPU usage by /proc/PID/stat. Any thoughts? Actually, you get both of those very easily with: set log_statement_stats=on LOG: QUERY STATISTICS DETAIL: !

Re: [HACKERS] time-delayed standbys

2011-06-16 Thread Robert Haas
On Wed, Jun 15, 2011 at 1:58 AM, Fujii Masao masao.fu...@gmail.com wrote: When the replication connection is terminated, the standby tries to read WAL files from the archive. In this case, there is no walreceiver process, so how does the standby calculate the clock difference? Good question.

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-16 Thread Bernd Helmle
--On 16. Juni 2011 13:25:05 -0400 Tom Lane t...@sss.pgh.pa.us wrote: Possible solution is to leave bootstrap's behavior alone, and have a step during initdb's post-bootstrap stuff that creates a matching pg_constraint row for every pg_attribute entry that's marked attnotnull. +1 for this

Re: [HACKERS] WIP: Fast GiST index build

2011-06-16 Thread Alexander Korotkov
Oh, actually it's so easy. Thanks. -- With best regards, Alexander Korotkov. On Thu, Jun 16, 2011 at 10:26 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 16.06.2011 21:13, Alexander Korotkov wrote: My current idea is to measure number of IO accesses by

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-16 Thread Robert Haas
On Thu, Jun 16, 2011 at 2:22 PM, Florian Pflug f...@phlo.org wrote: On Jun16, 2011, at 19:54 , Robert Haas wrote: On Thu, Jun 16, 2011 at 12:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: We deprecated those names for the geometric operators largely because there wasn't any visual correlation

Re: [HACKERS] POSIX shared memory patch status

2011-06-16 Thread Heikki Linnakangas
On 16.06.2011 20:22, A.M. wrote: I don't believe any conclusions were reached because the debate concerned whether or not fcntl locking was sufficient. I thought so while others pointed out that the proposed interlock would not work with mutli-client NFSv3 despite the fact that the current

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-16 Thread Alvaro Herrera
Excerpts from Bernd Helmle's message of jue jun 16 14:30:48 -0400 2011: --On 16. Juni 2011 13:25:05 -0400 Tom Lane t...@sss.pgh.pa.us wrote: Possible solution is to leave bootstrap's behavior alone, and have a step during initdb's post-bootstrap stuff that creates a matching

Re: [HACKERS] procpid?

2011-06-16 Thread Alvaro Herrera
Excerpts from Greg Sabino Mullane's message of jue jun 16 15:33:35 UTC 2011: Hash: RIPEMD160 Or perhaps pg_connections. Yes, +1 to making things fully backwards compatible by keeping pg_stat_activity around but making a better designed and better named table (view/SRF/whatever). I

Re: [HACKERS] Nested CASE-WHEN scoping

2011-06-16 Thread Pavel Stehule
Hello 2011/6/3 Heikki Linnakangas heikki.linnakan...@enterprisedb.com: On 31.05.2011 19:10, Heikki Linnakangas wrote: For index expressions, we could use a function similar to ChangeVarNodes(), that shifts all the paramids in the already-planned expression, preparing it for inclusion within

Re: [HACKERS] Boolean operators without commutators vs. ALL/ANY

2011-06-16 Thread Tom Lane
Florian Pflug f...@phlo.org writes: Well, I think there are basically three choices here, kludge or no kludge. (1) We either decree once and for all that binary operations ought to have commutators, modify CREATE TYPE to issue a warning if you create one without, add the missing ones, and

  1   2   >