[HACKERS] autocomplete - SELECT fx

2012-07-02 Thread Pavel Stehule
Hello I tested Peter's patch and it works well. I don't see any performance problem on my notebook last discussion http://archives.postgresql.org/message-id/CAK3UJRHXgnChP9J5RuOEMEtFB0E9awPhNOV=rqupwk6vx-z...@mail.gmail.com so we can do more - we can join this completation with , too - but it

Re: [HACKERS] Update on the spinlock-pthread_mutex patch experimental: replace s_lock spinlock code with pthread_mutex on linux

2012-07-02 Thread Nils Goroll
Jeff, without further ado: Thank you, I will go away, run pgbench according to your advice and report back. Nils -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH 14/16] Add module to apply changes from an apply-cache using low-level functions

2012-07-02 Thread Andres Freund
Hi, On Sunday, July 01, 2012 05:51:54 PM Alexander Korotkov wrote: On Sun, Jul 1, 2012 at 3:11 PM, Alexander Korotkov aekorot...@gmail.comwrote: 1) Patches don't apply cleanly to head. So I used commit bed88fceac04042f0105eb22a018a4f91d64400d as the base for patches, then all the patches

Re: [HACKERS] Checkpointer on hot standby runs without looking checkpoint_segments

2012-07-02 Thread Kyotaro HORIGUCHI
Ok, I agree to drop this patch from this CF. - What I want to get is similarity of the behaviors between  master and (hot-)standby concerning checkpoint  progression. Specifically, checkpoints for streaming  replication running at the speed governed with  checkpoint_segments. The work

[HACKERS] small bug on 3-digit years in 9.2-dev

2012-07-02 Thread Marc Cousin
Hi, While working on the What's new in 9.2, I think I found a small bug: SELECT to_date('519-07-02','YYY-MM-DD'); to_date 0519-07-02 (1 row) It comes, I think, from the year 519 case not being handled in the following code. Patch attached + if (year 70) +

[HACKERS] [WIP] Patch : Change pg_ident.conf parsing to be the same as pg_hba.conf

2012-07-02 Thread Amit Kapila
Attached is a Patch to change the parsing of pg_ident.conf to make it similar to pg_hba.conf. This is based on Todo Item: http://archives.postgresql.org/pgsql-hackers/2011-06/msg02204.php Purpose - This will allow to catch syntax errors in pg_ident at the startup or reload time. Changes

Re: [HACKERS] Update on the spinlock-pthread_mutex patch experimental: replace s_lock spinlock code with pthread_mutex on linux

2012-07-02 Thread Nils Goroll
just a quick note: I got really interesting results, but the writeup is not done yet. Will get back to this ASAP. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-07-02 Thread Robert Haas
On Wed, Jun 27, 2012 at 6:33 AM, Andres Freund and...@2ndquadrant.com wrote: Will do so. Not sure if I can finish it today though, I am in the midst of redoing the ilist and xlogreader patches. I guess tomorrow will suffice otherwise... Ok, attached are two patches: The first is the rebased

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-07-02 Thread Andres Freund
On Monday, July 02, 2012 03:51:08 PM Robert Haas wrote: On Wed, Jun 27, 2012 at 6:33 AM, Andres Freund and...@2ndquadrant.com wrote: Will do so. Not sure if I can finish it today though, I am in the midst of redoing the ilist and xlogreader patches. I guess tomorrow will suffice

Re: [HACKERS] enhanced error fields

2012-07-02 Thread Peter Geoghegan
On 9 May 2012 14:33, Pavel Stehule pavel.steh...@gmail.com wrote: here is patch with enhancing ErrorData structure. Now constraints errors and RI uses these fields So I took a look at the patch eelog-2012-05-09.diff today. All of the following remarks apply to it alone. The patch has bitrotted

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-07-02 Thread Robert Haas
On Thu, Jun 28, 2012 at 6:01 PM, Daniel Farina dan...@heroku.com wrote: On Thu, Jun 28, 2012 at 2:32 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: On 28 June 2012 22:22, Daniel Farina dan...@heroku.com wrote: All in all, I don't think this can be a very productive discussion unless

Re: [HACKERS] [PATCH] Lazy hashaggregate when no aggregation is needed

2012-07-02 Thread Robert Haas
On Thu, Jun 28, 2012 at 10:22 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Honestly, I'm not sure that it's worth including this, considering the use case... Since nobody seems crazy about pursuing this, I'm marking this patch Rejected. -- Robert Haas EnterpriseDB:

[HACKERS] User-Id Tracking when Portal was started

2012-07-02 Thread Kohei KaiGai
The attached patch is delivered from the discussion around row-level access control feature. A problem Florian pointed out is refcursor declared in security definer function. Even though all the permission checks are applied based on privilege of the owner of security-definer function in case when

[HACKERS] How to extend server side encoding GBK

2012-07-02 Thread Xiong He
I just noticed that PG not support the following encoding: /* followings are for client encoding only */ PG_SJIS,/* Shift JIS (Winindows-932) */ PG_BIG5,/* Big5 (Windows-950) */

Re: [HACKERS] How to extend server side encoding GBK

2012-07-02 Thread Tom Lane
=?ISO-8859-1?B?WGlvbmcgSGU=?= iih...@qq.com writes: I just noticed that PG not support the following encoding: /* followings are for client encoding only */ PG_SJIS,/* Shift JIS (Winindows-932) */ PG_BIG5,

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Thom Brown
On 2 July 2012 15:11, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Dimitri Fontaine dimi...@2ndquadrant.fr writes: https://github.com/dimitri/postgres/compare/f99e8d93b7...8da156dc70 The revised incremental diff is here: https://github.com/dimitri/postgres/compare/f99e8d93b7...74bbeda8

Re: [HACKERS] small bug on 3-digit years in 9.2-dev

2012-07-02 Thread Tom Lane
Marc Cousin cousinm...@gmail.com writes: While working on the What's new in 9.2, I think I found a small bug: Yeah, that code certainly looks wrong, thanks for the report! /* Force 100-519 into the 2000's */ - else if (year = 100 year 519) + else if (year = 100 year = 519)

Re: [HACKERS] [PATCH] Lazy hashaggregate when no aggregation is needed

2012-07-02 Thread Ants Aasma
On Mon, Jul 2, 2012 at 5:33 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 28, 2012 at 10:22 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Honestly, I'm not sure that it's worth including this, considering the use case... Since nobody seems crazy about pursuing this, I'm

Re: [HACKERS] spinlock-pthread_mutex : first results with Jeff's pgbench+plsql

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 11:26 AM, Nils Goroll sl...@schokola.de wrote: Please note that this is with 3.1.7. I understand that many scalability improvements have been implemented in later versions and it would have to be expected that using less synchronization points will imply that spinlock

Re: [HACKERS] spinlock-pthread_mutex : first results with Jeff's pgbench+plsql

2012-07-02 Thread Nils Goroll
3.1.7? Sorry, that was a typo. 9.1.3. Yes, I had mentioned the Version in my initial posting. This version is the one I need to work on as long as 9.2 is beta. A major scalability bottleneck caused by spinlock contention was fixed in 9.2 - see commit b4fbe392f8ff6ff1a66b488eb7197eef9e1770a4.

Re: [HACKERS] spinlock-pthread_mutex : first results with Jeff's pgbench+plsql

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 11:38 AM, Nils Goroll sl...@schokola.de wrote: 3.1.7? Sorry, that was a typo. 9.1.3. Yes, I had mentioned the Version in my initial posting. This version is the one I need to work on as long as 9.2 is beta. A major scalability bottleneck caused by spinlock

Re: [HACKERS] [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread David Fetter
On Mon, Jul 02, 2012 at 10:34:34AM -0400, Tom Lane wrote: Robert Haas rh...@postgresql.org writes: Make walsender more responsive. ... Andres Freund. Review and stylistic cleanup by me. The comments could have used a bit more copy-editing. (I got a good laugh out of the idea of

Re: [HACKERS] Notify system doesn't recover from No space error

2012-07-02 Thread Christoph Berg
Re: Tom Lane 2012-06-29 8308.1340933...@sss.pgh.pa.us in async.c that would try to create the missing page. This error will persist until the server is restarted (thus resetting the state of pg_notify), even if the underlying disk-full condition is cleared. Thanks for digging into this and

Re: [HACKERS] Notify system doesn't recover from No space error

2012-07-02 Thread Tom Lane
Christoph Berg christoph.b...@credativ.de writes: What is still puzzling me is that the customer is repeatedly reporting these issues, even after rebooting the system. Hm. A server restart really ought to clear any problem in this area, since pg_notify gets reset to starting conditions.

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Robert Haas
On Sun, Jul 1, 2012 at 5:11 AM, Alexander Korotkov aekorot...@gmail.com wrote: MULE also looks problematic. The code that you've written isn't symmetric with the opposite conversion, unlike what you did in all other cases, and I don't understand why. I'm also somewhat baffled by the reverse

Re: [HACKERS] spinlock-pthread_mutex : first results with Jeff's pgbench+plsql

2012-07-02 Thread Tom Lane
Nils Goroll sl...@schokola.de writes: How I read this under the assumption that the test was correct and valid _and_ can be reproduced independently: * for very low concurrency, the existing spinlock implementation is ideal - we can't do any better both in terms of resulting sps and

Re: [HACKERS] spinlock-pthread_mutex : first results with Jeff's pgbench+plsql

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 12:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: What this seems to me to show, though, is that pthread mutexes are not fundamentally a better technology than what we have now in spinlocks. The problem is that the spinlock code is not adapting well to very high levels of

Re: [HACKERS] Checkpointer on hot standby runs without looking checkpoint_segments

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 5:08 AM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: I don't know why you hate to decrease checkpoint interval so much despite I proposed to do so only during WAL streaming (and additionaly allowing it to be optional), we have another and enough reason to

Re: [HACKERS] spinlock-pthread_mutex : first results with Jeff's pgbench+plsql

2012-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: The delay code is stupider than it could be, in that it sleeps without regard to what's happening elsewhere in the system. The futex stuff was interesting to me because it potentially provides a way to sleep until something interesting happens rather

Re: [HACKERS] [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Fujii Masao
On Mon, Jul 2, 2012 at 10:49 PM, Robert Haas rh...@postgresql.org wrote: Make walsender more responsive. Per testing by Andres Freund, this improves replication performance and reduces replication latency and latency jitter. I was a bit concerned about moving more work into XLogInsert, but

[HACKERS] away soon - spinlock-pthread_mutex : first results with Jeff's pgbench+plsql

2012-07-02 Thread Nils Goroll
btw, I really need to let go of this topic to catch up before going away at the end of the week. Thanks, Nils -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Andres Freund
On Monday, July 02, 2012 07:19:19 PM Fujii Masao wrote: On Mon, Jul 2, 2012 at 10:49 PM, Robert Haas rh...@postgresql.org wrote: Make walsender more responsive. Per testing by Andres Freund, this improves replication performance and reduces replication latency and latency jitter. I was

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Robert Haas
On Fri, Jun 29, 2012 at 5:38 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Will do a whole warning check pass later. Can you give me your local Makefile trick to turn them into hard errors again please? :) echo COPT=-Werror src/Makefile.custom Your latest patch contains a warning about

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 1:56 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jun 29, 2012 at 5:38 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Will do a whole warning check pass later. Can you give me your local Makefile trick to turn them into hard errors again please? :) echo

Re: [HACKERS] [ADMIN] pg_basebackup blocking all queries with horrible performance

2012-07-02 Thread Fujii Masao
On Mon, Jul 2, 2012 at 4:01 AM, Magnus Hagander mag...@hagander.net wrote: On Sun, Jul 1, 2012 at 7:14 PM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Jun 29, 2012 at 7:22 PM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jun 27, 2012 at 7:24 PM, Fujii Masao masao.fu...@gmail.com

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 10:11 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: [ new patch ] I would really like to start committing parts of this, but there are still a lot of unfinished loose ends in this code. The one that is most immediately bothering me is related to the syntax you've

Re: [HACKERS] [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 1:53 PM, Andres Freund and...@2ndquadrant.com wrote: This commit makes the synchronous replication slow down very much when wal_sync_method is set to open_sync or open_datasync. I think the attached patch needs to be applied. Hm. Yes, definitely. No idea why I placed the

Re: [HACKERS] Ability to listen on two unix sockets

2012-07-02 Thread Tom Lane
Honza Horak hho...@redhat.com writes: On 06/15/2012 05:40 PM, Honza Horak wrote: I realized the patch has some difficulties -- namely the socket path in the data dir lock file, which currently uses one port for socket and the same for interface. So to allow users to use arbitrary port for

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: CREATE EVENT TRIGGER name ON event_name WHEN event_trigger_variable IN (trigger_command_list) EXECUTE PROCEDURE func_name () [...] 1. Do we imagine a situation where a given event_name would allow more than one choice of event_trigger_variable? If so,

Re: [HACKERS] Proof of concept: auto updatable views

2012-07-02 Thread Robert Haas
On Sun, Jul 1, 2012 at 6:35 PM, Dean Rasheed dean.a.rash...@gmail.com wrote: I've been playing around with the idea of supporting automatically updatable views, and I have a working proof of concept. I've taken a different approach than the previous attempts to implement this feature (e.g.,

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Alexander Korotkov
On Mon, Jul 2, 2012 at 8:12 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jul 1, 2012 at 5:11 AM, Alexander Korotkov aekorot...@gmail.com wrote: MULE also looks problematic. The code that you've written isn't symmetric with the opposite conversion, unlike what you did in all other

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 4:10 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: 2. On a related point, do we anticipate that we might eventually want to allow filtering by more than one event_trigger_variable in the same trigger? That is, might we want to do something like this: CREATE EVENT

Re: [HACKERS] Proof of concept: auto updatable views

2012-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sun, Jul 1, 2012 at 6:35 PM, Dean Rasheed dean.a.rash...@gmail.com wrote: Basically what it does is this: in the first stage of query rewriting, just after any non-SELECT rules are applied, the new code kicks in - if the target relation is a view,

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 4:33 PM, Alexander Korotkov aekorot...@gmail.com wrote: On Mon, Jul 2, 2012 at 8:12 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jul 1, 2012 at 5:11 AM, Alexander Korotkov aekorot...@gmail.com wrote: MULE also looks problematic. The code that you've written

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Alexander Korotkov
On Tue, Jul 3, 2012 at 12:37 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jul 2, 2012 at 4:33 PM, Alexander Korotkov aekorot...@gmail.com wrote: On Mon, Jul 2, 2012 at 8:12 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jul 1, 2012 at 5:11 AM, Alexander Korotkov

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: I'd really like to not have to change the catalog again in every patch, because if we do that then we are just saying we're going to rewrite this patch completely every time we want to add a new feature, which kind of defeats the purpose IMHO. Fair

Re: [HACKERS] How to extend server side encoding GBK

2012-07-02 Thread Xiong He
Thanks. UTF8 is good enough although it needs conversion between client GBK and server side UTF8. I didn't notice that there are high risk to introduce GBK and similar other kind of charsets into server side. =?ISO-8859-1?B?WGlvbmcgSGU=?= iih...@qq.com writes: I just noticed that PG not

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 4:53 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: So let's try to hammer something out now. The obvious thing that occurs to me is to have a column in the catalog that is a 2-D array of text, with the first element of each

Re: [HACKERS] enhanced error fields

2012-07-02 Thread Peter Geoghegan
On 2 July 2012 15:19, Peter Geoghegan pe...@2ndquadrant.com wrote: On 9 May 2012 14:33, Pavel Stehule pavel.steh...@gmail.com wrote: here is patch with enhancing ErrorData structure. Now constraints errors and RI uses these fields So I took a look at the patch eelog-2012-05-09.diff today. All

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 4:46 PM, Alexander Korotkov aekorot...@gmail.com wrote: So, I provided such transformation in versions 0.3 and 0.4 based on explanation from Tatsuo Ishii. The problem is that both conversions are nontrivial and it's not evident that they are mirror (understanding that

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: So let's try to hammer something out now. The obvious thing that occurs to me is to have a column in the catalog that is a 2-D array of text, with the first element of each array being something like tag or subtag (i.e. event_trigger_variable) and the

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: I don't foresee more generic needs here, unless you can convince me that we need both a. a full stack of arbitrarily nested commands and b. a way to match and target any level of that stack. Um ... isn't the burden of proof the other way around

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Tatsuo Ishii
Yeah, I did. I think I may be a bit confused here, so let me try to understand this a bit better. It seems like pg_mule2wchar_with_len uses the following algorithm: - If the first character IS_LC1 (0x81-0x8d), decode two bytes, stored with shifts of 16 and 0. - If the first character

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: In the reverse transformation implemented by pg_wchar2mule_with_len, if the byte stored with shift 16 IS_LC1 or IS_LC2, then we decode 2 or 3 bytes, respectively, exactly as I would expect. ASCII decoding is also as I would expect. The case I don't

[HACKERS] Oracle porting sample instr function

2012-07-02 Thread Greg Smith
A web site doc comment from user skong today points out a small issue around the sample INSTR function given in plpgsql-porting.html that I can't confirm (none of those dirty Oracle instances here today), but it sounds legit. A look at Oracle's documentation on the INSTR function at

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Tom Lane
I wrote: Some inspection of pg_wchar.h suggests that the IS_LCPRV1 and IS_LCPRV2 cases are unused: the file doesn't define any encoding labels that match the byte values they accept, nor do the comments suggest that Emacs has any such labels either. Scratch that --- I was misled by the fond

Re: [HACKERS] [DOCS] File format for SSL CRL file

2012-07-02 Thread Alvaro Herrera
Excerpts from Greg Smith's message of lun jul 02 20:30:07 -0400 2012: A documentation comment came in recently about ssl-tcp.html not specifying what format is expected for the CRL file. Seems like something that could be described better now that I look at it, so I'm passing that along

[HACKERS] huge tlb support

2012-07-02 Thread Robert Haas
On Fri, Jun 29, 2012 at 3:52 PM, Andres Freund and...@2ndquadrant.com wrote: Hi All, In a *very* quick patch I tested using huge pages/MAP_HUGETLB for the mmap'ed memory. That gives around 9.5% performance benefit in a read-only pgbench run (-n -S - j 64 -c 64 -T 10 -M prepared, scale 200,

Re: [HACKERS] Posix Shared Mem patch

2012-07-02 Thread Bruce Momjian
On Fri, Jun 29, 2012 at 04:03:40PM -0700, Daniel Farina wrote: On Fri, Jun 29, 2012 at 1:00 PM, Merlin Moncure mmonc...@gmail.com wrote: On Fri, Jun 29, 2012 at 2:52 PM, Andres Freund and...@2ndquadrant.com wrote: Hi All, In a *very* quick patch I tested using huge pages/MAP_HUGETLB

Re: [HACKERS] Posix Shared Mem patch

2012-07-02 Thread Robert Haas
On Fri, Jun 29, 2012 at 2:31 PM, Josh Berkus j...@agliodbs.com wrote: My idea of not dedicated is I can launch a dozen postmasters on this machine, and other services too, and it'll be okay as long as they're not doing too much. Oh, 128MB then? Proposed patch attached. -- Robert Haas

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 6:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: So let's try to hammer something out now. The obvious thing that occurs to me is to have a column in the catalog that is a 2-D array of text, with the first element of each array being

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 7:33 PM, Tatsuo Ishii is...@postgresql.org wrote: Yeah, I did. I think I may be a bit confused here, so let me try to understand this a bit better. It seems like pg_mule2wchar_with_len uses the following algorithm: - If the first character IS_LC1 (0x81-0x8d), decode

Re: [HACKERS] huge tlb support

2012-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Jun 29, 2012 at 3:52 PM, Andres Freund and...@2ndquadrant.com wrote: In a *very* quick patch I tested using huge pages/MAP_HUGETLB for the mmap'ed memory. So, considering that there is required setup, it seems that the obvious thing to do

Re: [HACKERS] Event Triggers reduced, v1

2012-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Jul 2, 2012 at 6:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Um, doesn't that require nonrectangular arrays? Doh. You're right: I keep forgetting that arrays have to be rectangular. Any suggestions on a sensible way to represent this? Are

Re: [HACKERS] Uh, I change my mind about commit_delay + commit_siblings (sort of)

2012-07-02 Thread Bruce Momjian
On Thu, Jun 28, 2012 at 08:17:53PM +0100, Peter Geoghegan wrote: On 28 June 2012 20:00, Tom Lane t...@sss.pgh.pa.us wrote: See VACUUM FULL for a recent counterexample --- we basically jacked it up and drove a new implementation underneath, but we didn't change the name, despite the fact