Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-15 Thread Tom Lane
David Rowley writes: > I guess the answer for the people that complain about slowness could be > that they create their own aggregate function which implements float4pl as > the trans function and float4mi as the negative trans function. They can > call it SUMFASTBUTWRONG() if they like. Perhaps i

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-15 Thread David Rowley
On Sun, Dec 15, 2013 at 3:08 PM, Tom Lane wrote: > I wrote: > > It's not so good with two-row windows though: > > Actually, carrying that example a bit further makes the point even more > forcefully: > > Table correct sum of negative-transition > this + next val

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-15 Thread David Rowley
On Sun, Dec 15, 2013 at 9:29 PM, Tom Lane wrote: > David Rowley writes: > > I guess the answer for the people that complain about slowness could be > > that they create their own aggregate function which implements float4pl > as > > the trans function and float4mi as the negative trans function.

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-15 Thread Tom Lane
David Rowley writes: > I've attached an updated patch which includes some documentation. > I've also added support for negfunc in CREATE AGGREGATE. Hopefully that's > an ok name for the option, but if anyone has any better ideas please let > them be known. I'd be a bit inclined to build the termi

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-15 Thread Ants Aasma
On Dec 15, 2013 6:44 PM, "Tom Lane" wrote: > David Rowley writes: > > I've attached an updated patch which includes some documentation. > > I've also added support for negfunc in CREATE AGGREGATE. Hopefully that's > > an ok name for the option, but if anyone has any better ideas please let > > th

Re: [HACKERS] patch: make_timestamp function

2013-12-15 Thread Pavel Stehule
Hello 2013/12/13 Jim Nasby > On 12/13/13 1:49 PM, Fabrízio de Royes Mello wrote: > >> >> On Fri, Dec 13, 2013 at 5:35 PM, Tom Lane > t...@sss.pgh.pa.us>> wrote: >> >> > >> > =?ISO-8859-1?Q?Fabr=EDzio_de_Royes_Mello?= >> > fabriziome...@gmail.com>> writes: >> > > I think the goal of the "mak

Re: [HACKERS] SSL: better default ciphersuite

2013-12-15 Thread James Cloos
> "MK" == Marko Kreen writes: > "PE" == Peter Eisentraut writes: MK>> Well, we should - the DEFAULT is clearly a client-side default MK>> for compatibility only. No server should ever run with it. PE> Any other opinions on this out there? For reference, see: https://wiki.mozilla.or

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2013-12-15 Thread Amit Kapila
On Thu, Dec 12, 2013 at 4:43 PM, MauMau wrote: > Hi, Amit san, > > From: "Amit Kapila" >>> >>> [elog.c] >>> Writing the default value in this file was redundant, because >>> event_source >>> cannot be NULL. So change >>> >> I think this change might not be safe as write_eventlog() gets called >>

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2013-12-15 Thread Shigeru Hanada
Hi Kaigai-san, 2013/12/11 Kohei KaiGai : > 2013/12/10 Shigeru Hanada : >> The patches could be applied cleanly, but I saw a compiler warning >> about get_rel_relkind() in foreign.c, but it's minor issue. Please >> just add #include of utils/lsyscache.h there. >> > Fixed, Check. >> I have some m

Re: [HACKERS] logical changeset generation v6.8

2013-12-15 Thread Robert Haas
On Wed, Dec 11, 2013 at 7:08 PM, Andres Freund wrote: >> I don't think there's much point in including "remapping" in all of >> the error messages. It adds burden for translators and users won't >> know what a remapping file is anyway. > > It helps in locating wich part of the code caused a probl

Re: [HACKERS] Extension Templates S03E11

2013-12-15 Thread Jeff Davis
On Sat, 2013-12-14 at 13:46 -0800, Josh Berkus wrote: > All: > > Can someone summarize the issues with this patch for those of us who > haven't been following it closely? I was just chatting with a couple > other contributors, and at this point none of just know what it > implements, what it does

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-15 Thread David Rowley
On Mon, Dec 16, 2013 at 6:00 AM, Ants Aasma wrote: > On Dec 15, 2013 6:44 PM, "Tom Lane" wrote: > > David Rowley writes: > > > I've attached an updated patch which includes some documentation. > > > I've also added support for negfunc in CREATE AGGREGATE. Hopefully > that's > > > an ok name for

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-15 Thread David Fetter
On Mon, Dec 16, 2013 at 08:39:33PM +1300, David Rowley wrote: > On Mon, Dec 16, 2013 at 6:00 AM, Ants Aasma wrote: > > > On Dec 15, 2013 6:44 PM, "Tom Lane" wrote: > > > David Rowley writes: > > > > I've attached an updated patch which includes some documentation. > > > > I've also added suppor