Re: [HACKERS] Typo in a comment?

2014-02-07 Thread Heikki Linnakangas
On 02/07/2014 08:15 AM, Amit Langote wrote: In src/backend/storage/freespace/freespace.c, * * MaxFSMRequestSize depends on the architecture and BLCKSZ, but assuming * default 8k BLCKSZ, and that MaxFSMRequestSize is 24 bytes, the categories * look like this * Is "24 bytes" a typo cons

Re: [HACKERS] [GENERAL] client encoding that psql command sets

2014-02-07 Thread Albe Laurenz
[CC'ed -hackers] Tsubasa Sakamoto wrote: >> Not sure that it makes a difference but the docs say psql looks at >> LC_CTYPE not LANG for Unix systems. You did not say what OS you are >> working on though from the examples I am guessing some form of Unix. > The LC_CTYPE environment variable was set

Re: [HACKERS] Inconsistency between pg_stat_activity and log_duration

2014-02-07 Thread Tatsuo Ishii
>> One idea is, calling pgstat_report_activity(STATE_IDLE) in >> exec_execute_message() of postgres.c. The function has already called >> pgstat_report_activity(STATE_RUNNING) which shows "active" state in >> pg_stat_actviity view. So why cann't we call >> pgstat_report_activity(STATE_IDLE) here. >

Re: [HACKERS] specifying repeatable read in PGOPTIONS

2014-02-07 Thread Andres Freund
Hi Tom, On 2014-02-04 12:02:45 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2014-02-04 11:36:22 -0500, Tom Lane wrote: > >> -1. This is not a general solution to the problem. There are other > >> GUCs for which people might want spaces in the value. > > > Sure, I didn't say it was. Bu

Re: [HACKERS] Recovery inconsistencies, standby much larger than primary

2014-02-07 Thread Andres Freund
On 2014-02-06 20:06:03 -0500, Tom Lane wrote: > Andres Freund writes: > > That reminds me, not that I directly see how it could be responsible, > > there's still 20131029011623.gj20...@awork2.anarazel.de ff. around. I > > don't think we came to a agreement in that thread how to fix the > > problem

Re: [HACKERS] INSERT...ON DUPLICATE KEY LOCK FOR UPDATE

2014-02-07 Thread Peter Geoghegan
On Thu, Jan 16, 2014 at 12:35 AM, Heikki Linnakangas wrote: >> I think you should consider breaking off the relcache parts of my >> patch and committing them, because they're independently useful. > > Makes sense. Can you extract that into a separate patch, please? Perhaps you can take a look at

Re: [HACKERS] inherit support for foreign tables

2014-02-07 Thread Etsuro Fujita
Hi Hanada-san, Sorry for the delay. (2014/01/30 14:01), Shigeru Hanada wrote: 2014-01-27 Etsuro Fujita : While still reviwing this patch, I feel this patch has given enough consideration to interactions with other commands, but found the following incorrect? behabior: postgres=# CREATE TABLE

[HACKERS] Breaking compile-time dependency cycles of Postgres subdirs?

2014-02-07 Thread Christian Convey
This question is mostly just curiosity... There are build-time dependency cycles between some of Postgres' code subdirectories. For example, "storage" and "access" have such a cycle: storage/buffpage.h #includes access/xlogdefs.h access/visibilitymap.h #includes storage/block.h Has there been an

Re: [HACKERS] extension_control_path

2014-02-07 Thread Christian Kruse
Hi, On 06/02/14 18:14, Greg Stark wrote: > Installing into /usr/local is a global system change. Only root should > be able to do that and any user that can do that can easily acquire > root privileges. The idea behind Homebrew is copied from FreeBSD, where you also install 3rd party software to

Re: [HACKERS] GIN improvements part2: fast scan

2014-02-07 Thread Heikki Linnakangas
On 02/06/2014 01:22 PM, Alexander Korotkov wrote: Difference is very small. For me, it looks ready for commit. Great, committed! Now, to review the catalog changes... - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://

Re: [HACKERS] Inconsistency between pg_stat_activity and log_duration

2014-02-07 Thread Tom Lane
Tatsuo Ishii writes: >> The argument here could be do we really need a new state for such a short >> window between completion of 'E' message and processing of 'S' sync >> message considering updation of state is not a very light call which can >> be called between processing of 2 messages. It mig

Re: [HACKERS] open and close columns in the NEW record not allowed

2014-02-07 Thread Robert Haas
On Thu, Feb 6, 2014 at 10:27 AM, k...@rice.edu wrote: >> Thanks for the feedback. >> >> Our problem is that an application decides the name of the columns in >> the tables and "XDB replication" from EnterpriseDB decides the triggers. >> We have no control over the code :-( >> > > It sounds like a

Re: [HACKERS] dynamic shared memory and locks

2014-02-07 Thread Robert Haas
On Tue, Jan 21, 2014 at 11:37 AM, Robert Haas wrote: > One idea I just had is to improve the dsm_toc module so that it can > optionally set up a tranche of lwlocks for you, and provide some > analogues of RequestAddinLWLocks and LWLockAssign for that case. That > would probably make this quite a

Re: [HACKERS] GiST support for inet datatypes

2014-02-07 Thread Robert Haas
On Thu, Feb 6, 2014 at 12:14 PM, Emre Hasegeli wrote: > I have misread the name, rename was not necessary. I removed the DEFAULT > keywords for the inet and the cidr operator classes from btree_gist--1.0.sql > on the inet-gist patch. Generally, modifying already-release .sql files for extensions

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 20:58, Thom Brown wrote: > On 7 February 2014 19:35, Andres Freund wrote: >> 0004: wal_decoding: Documentation for replication slots and changeset >> extraction > > The usage of pg_create_decoding_replication_slot does show the "(1 row)" line. I mean "doesn't show" of course.

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Andres Freund
On February 7, 2014 9:58:14 PM CET, Thom Brown wrote: >On 7 February 2014 19:35, Andres Freund wrote: >> 0004: wal_decoding: Documentation for replication slots and changeset >extraction > >The usage of pg_create_decoding_replication_slot does show the "(1 >row)" line. > >The output of "SELECT *

Re: [HACKERS] Release schedule for 9.3.3?

2014-02-07 Thread Tom Lane
Greg Stark writes: > On Thu, Feb 6, 2014 at 10:55 PM, Sean Chittenden wrote: >> Are there any tentative plans for the 9.3.3 release date? 9.3.2 was released >> in December and it's getting close to the two month mark for another micro >> release, or at least one seems like one should be right a

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 21:04, Andres Freund wrote: > On February 7, 2014 9:58:14 PM CET, Thom Brown wrote: >>On 7 February 2014 19:35, Andres Freund wrote: >>> 0004: wal_decoding: Documentation for replication slots and changeset >>extraction >> >>The usage of pg_create_decoding_replication_slot doe

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 19:35, Andres Freund wrote: > 0004: wal_decoding: Documentation for replication slots and changeset > extraction The usage of pg_create_decoding_replication_slot does show the "(1 row)" line. The output of "SELECT * FROM pg_replication_slots;" is out-of-date. There appears t

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Erik Rijkers
On Fri, February 7, 2014 22:09, Thom Brown wrote: >>The example also shows output from pg_decoding_slot_get_changes after >>inserting 2 rows, but when I run the same example, there are no rows FWIW, works for me: testdb=# SELECT * FROM pg_decoding_slot_get_changes('regression_slot', 'now', 'inc

Re: [HACKERS] Minor performance improvement in transition to external sort

2014-02-07 Thread Jeremy Harris
On 06/02/14 22:12, Jeremy Harris wrote: Did you try sorting already-sorted, reverse sorted, or pipe-organ shaped data sets? Summary (low numbers better): Random ints: 83% compares, level on time. Sorted ints: level compares, 70% time. Reverse-sorted ints: 10% compares, 15% tim

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 21:28, Erik Rijkers wrote: > On Fri, February 7, 2014 22:09, Thom Brown wrote: > >>>The example also shows output from pg_decoding_slot_get_changes after >>>inserting 2 rows, but when I run the same example, there are no rows > > FWIW, works for me: Can you confirm you're runni

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Erik Rijkers
On Fri, February 7, 2014 22:29, Thom Brown wrote: > On 7 February 2014 21:28, Erik Rijkers wrote: >> On Fri, February 7, 2014 22:09, Thom Brown wrote: >> The example also shows output from pg_decoding_slot_get_changes after inserting 2 rows, but when I run the same example, there are no ro

Review of RLS on inheritance schema HL7 RIM (was Re: [HACKERS] Row-security on updatable s.b. views)

2014-02-07 Thread Yeb Havinga
On 06/02/14 15:19, Craig Ringer wrote: Thanks to the simplified requirements for inheritance, this turns out to be fairly easy. There's a version rewritten to use the rewriter in the tag: rls-9.4-upd-sb-views-v6 on https://github.com/ringerc/postgres.git Hi Craig, list, This is review o

Re: [HACKERS] Inconsistency between pg_stat_activity and log_duration

2014-02-07 Thread Tatsuo Ishii
>> The query is piggy backed on the same connection to PostgreSQL opend >> by user (pgpool-II cannot issue "sync" because it closes the >> transaction, which in turn closes user's unnamed portal). > > This argument (and usage) seems pretty broken. If you don't issue > sync then how do you know yo

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Andres Freund
On 2014-02-07 20:58:14 +, Thom Brown wrote: > On 7 February 2014 19:35, Andres Freund wrote: > > 0004: wal_decoding: Documentation for replication slots and changeset > > extraction > > The usage of pg_create_decoding_replication_slot does show the "(1 row)" line. > > The output of "SELECT

Re: [HACKERS] Changeset Extraction v7.5

2014-02-07 Thread Thom Brown
On 7 February 2014 23:43, Andres Freund wrote: > On 2014-02-07 20:58:14 +, Thom Brown wrote: >> On 7 February 2014 19:35, Andres Freund wrote: >> > 0004: wal_decoding: Documentation for replication slots and changeset >> > extraction >> >> The usage of pg_create_decoding_replication_slot doe

[HACKERS] commit fest 2014-01 week 3 report

2014-02-07 Thread Peter Eisentraut
Last week: Status Summary. Needs Review: 49, Waiting on Author: 18, Ready for Committer: 9, Committed: 33, Returned with Feedback: 3, Rejected: 1. Total: 113. This week: Status Summary. Needs Review: 47, Waiting on Author: 15, Ready for Committer: 12, Committed: 37, Returned with Feedback: 3, Re

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-02-07 Thread Peter Eisentraut
On 1/29/14, 7:37 PM, Haribabu Kommi wrote: > > On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote: > > On 11/30/13, 6:59 AM, Haribabu kommi wrote: > > To detect provided data and xlog directories are same or not, I > reused the > > Existing make_absolute_path() code as follow

Re: [HACKERS] [PATCH] Relocation of tablespaces in pg_basebackup

2014-02-07 Thread Peter Eisentraut
On 1/29/14, 12:07 PM, Steeve Lennmark wrote: > We need to think about how to handle this on platforms without > symlinks. > I don't like just printing an error message and moving on. It > should be > either pass or fail or an option to choose between them. >

Re: [HACKERS] Move unused buffers to freelist

2014-02-07 Thread Jason Petersen
Bump. I’m interested in many of the issues that were discussed in this thread. Was this patch ever wrapped up (I can’t find it in any CF), or did this thread die off? —Jason On Aug 6, 2013, at 12:18 AM, Amit Kapila wrote: > On Friday, June 28, 2013 6:20 PM Robert Haas wrote: >> On Fri, Jun 2

Re: [HACKERS] Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-07 Thread Peter Eisentraut
On 2/3/14, 8:48 PM, Tom Lane wrote: > That's a very fair question. It's a reasonable bet that pretty much > nobody actually looks at the text versions of either HISTORY or > regress_README anymore. It's conceivable that somebody somewhere makes > use of the text version of INSTALL when trying to

[HACKERS] Re: [DOCS] Re: Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-07 Thread Peter Eisentraut
On 2/4/14, 3:28 PM, Robert Haas wrote: > Right. I mean, a lot of the links say things like "Section 26.2" > which obviously makes no sense in a standalone text file. The man pages have the same issue. For example from man postgres: Other possible file layouts are discussed in Section 18.2,

Re: [HACKERS] Move unused buffers to freelist

2014-02-07 Thread Amit Kapila
On Sat, Feb 8, 2014 at 7:16 AM, Jason Petersen wrote: > Bump. > > I'm interested in many of the issues that were discussed in this thread. Was > this patch ever wrapped up (I can't find it in any CF), or did this thread > die off? This and variant of this patch have been discussed multiple time

Re: [HACKERS] Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-07 Thread Tom Lane
Peter Eisentraut writes: > On 2/3/14, 8:48 PM, Tom Lane wrote: >> That's a very fair question. It's a reasonable bet that pretty much >> nobody actually looks at the text versions of either HISTORY or >> regress_README anymore. It's conceivable that somebody somewhere makes >> use of the text ve

Re: [HACKERS] Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-07 Thread Gavin Flower
On 08/02/14 19:05, Tom Lane wrote: Peter Eisentraut writes: On 2/3/14, 8:48 PM, Tom Lane wrote: That's a very fair question. It's a reasonable bet that pretty much nobody actually looks at the text versions of either HISTORY or regress_README anymore. It's conceivable that somebody somewhere

Re: [HACKERS] Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-07 Thread Tom Lane
Gavin Flower writes: > How about adding URL's for the online versions of HISTORY & README's (or > their rough equivalents - perhaps the online version of the latest > 'Appendix E. Release Notes' would be sufficient?) to the INSTALL file? Actually, what I had in mind was to replace the dynamical

Re: [HACKERS] Retain dynamic shared memory segments for postmaster lifetime

2014-02-07 Thread Amit Kapila
> On Thu, Feb 6, 2014 at 3:42 PM, Kyotaro HORIGUCHI > wrote: >> Hello, I've understood how this works and seems working as >> expected. >> >> >> The orphan section handles on postmaster have become a matter of >> documentation. I had explained this in function header of dsm_keep_segment(). >> Be