Re: [HACKERS] On partitioning

2014-12-06 Thread Amit Kapila
On Fri, Dec 5, 2014 at 10:03 PM, Robert Haas wrote: > On Tue, Dec 2, 2014 at 10:43 PM, Amit Langote > wrote: > > > I wonder if your suggestion of pg_node_tree plays well here. This then could be a list of CONSTs or some such... And I am thinking it's a concern only for range partitions, no? (that

Re: [HACKERS] On partitioning

2014-12-06 Thread Amit Kapila
On Fri, Dec 5, 2014 at 10:12 PM, Robert Haas wrote: > On Fri, Dec 5, 2014 at 2:18 AM, Amit Kapila wrote: > > Do we really need to support dml or pg_dump for individual partitions? > > I think we do. It's quite reasonable for a DBA (or developer or > whatever) to want to dump all the data that's

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-12-06 Thread Amit Kapila
On Mon, Dec 1, 2014 at 12:18 PM, Dilip kumar wrote: > > On 24 November 2014 11:29, Amit Kapila Wrote, > I have verified that all previous comments are addressed and the new version is much better than previous version. > > here we are setting each target once and doing for all the tables.. > Hm

Re: [HACKERS] Parallel Seq Scan

2014-12-06 Thread Stephen Frost
* Amit Kapila (amit.kapil...@gmail.com) wrote: > 1. As the patch currently stands, it just shares the relevant > data (like relid, target list, block range each worker should > perform on etc.) to the worker and then worker receives that > data and form the planned statement which it will execute a

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-06 Thread Michael Paquier
On Sat, Dec 6, 2014 at 12:17 AM, Andres Freund wrote: > On 2014-12-06 00:10:11 +0900, Michael Paquier wrote: > > On Sat, Dec 6, 2014 at 12:06 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > > > > > > > > > > > > > > On Fri, Dec 5, 2014 at 11:10 PM, Rahila Syed > > > wrote: > > >

Re: [HACKERS] superuser() shortcuts

2014-12-06 Thread Peter Eisentraut
On 12/4/14 3:32 PM, Stephen Frost wrote: > On reflection, this seemed odd because of how the code was written but > perhaps it was intentional after all. In general, superuser should be > able to bypass permissions restrictions and I don't see why this case > should be different. > In general, I

Re: [HACKERS] Role Attribute Bitmask Catalog Representation

2014-12-06 Thread Stephen Frost
Adam, * Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote: > Attached is an updated patch. Awesome, thanks! > diff --git a/src/backend/catalog/aclchk.c b/src/backend/catalog/aclchk.c > *** pg_extension_ownercheck(Oid ext_oid, Oid > *** 5051,5102 > } > > /*

Re: [HACKERS] [v9.5] Custom Plan API

2014-12-06 Thread Simon Riggs
On 27 November 2014 at 20:48, Simon Riggs wrote: > On 27 November 2014 at 10:33, Kouhei Kaigai wrote: > >> The reason why documentation portion was not yet committed is, sorry, it >> is due to quality of documentation from the standpoint of native English >> speaker. >> Now, I'm writing up a docu

Re: [HACKERS] inherit support for foreign tables

2014-12-06 Thread Noah Misch
On Thu, Dec 04, 2014 at 10:00:14AM +0530, Ashutosh Bapat wrote: > On Thu, Dec 4, 2014 at 9:05 AM, Etsuro Fujita > wrote: > > (2014/12/03 19:35), Ashutosh Bapat wrote: > >> On Tue, Dec 2, 2014 at 8:29 AM, Etsuro Fujita > >> mailto:fujita.ets...@lab.ntt.co.jp>> wrote: > > IIUC, even the transa

Re: [HACKERS] Role Attribute Bitmask Catalog Representation

2014-12-06 Thread Adam Brightwell
Stephen, The comment above is pretty big and I don't think we want to completely > remove it. Can you add it as another 'Note' in the 'has_role_attribute' > comment and reword it accordingly? > Ok, agreed. Will address. Whitespace issue that should be fixed- attributes should line up with > ro

Re: [HACKERS] Role Attribute Bitmask Catalog Representation

2014-12-06 Thread Stephen Frost
* Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote: > > I don't see any changes to the regression test files, were they > > forgotten in the patch? I would think that at least the view definition > > changes would require updates to the regression tests, though perhaps > > nothing

Re: [HACKERS] inherit support for foreign tables

2014-12-06 Thread David Fetter
On Thu, Dec 04, 2014 at 12:35:54PM +0900, Etsuro Fujita wrote: > (2014/12/03 19:35), Ashutosh Bapat wrote: > >On Tue, Dec 2, 2014 at 8:29 AM, Etsuro Fujita > >mailto:fujita.ets...@lab.ntt.co.jp>> wrote: > > >This is not exactly extension of non-inheritance case. non-inheritance > >case doesn't sho

Re: [HACKERS] excessive amounts of consumed memory (RSS), triggering OOM killer

2014-12-06 Thread Tomas Vondra
On 2.12.2014 02:52, Tom Lane wrote: > Tomas Vondra writes: >> On 2.12.2014 01:33, Tom Lane wrote: >>> What I suspect you're looking at here is the detritus of creation >>> of a huge number of memory contexts. mcxt.c keeps its own state >>> about existing contents in TopMemoryContext. So, if we pos

Re: [HACKERS] [v9.5] Custom Plan API

2014-12-06 Thread Kouhei Kaigai
Simon, > > Yes please. We have other contrib modules that exist as tests, so this > > seems reasonable to me. > > I can't improve the docs without the example code. Is that available now? > Please wait for a few days. The ctidscan module is not adjusted for the latest interface yet. -- NEC OSS P

[HACKERS] PATCH: adaptive ndistinct estimator v3 (WAS: Re: [PERFORM] Yet another abort-early plan disaster on 9.3)

2014-12-06 Thread Tomas Vondra
Hi! This was initially posted to pgsql-performance in this thread: http://www.postgresql.org/message-id/5472416c.3080...@fuzzy.cz but pgsql-hackers seems like a more appropriate place for further discussion. Anyways, attached is v3 of the patch implementing the adaptive ndistinct estimator. J

[HACKERS] PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching

2014-12-06 Thread Tomas Vondra
Hi, back when we were discussing the hashjoin patches (now committed), Robert proposed that maybe it'd be a good idea to sometimes increase the number of tuples per bucket instead of batching. That is, while initially sizing the hash table - if the hash table with enough buckets to satisfy NTUP_P

Re: [HACKERS] Testing DDL deparsing support

2014-12-06 Thread Bruce Momjian
On Tue, Dec 2, 2014 at 03:13:07PM -0300, Alvaro Herrera wrote: > Robert Haas wrote: > > On Thu, Nov 27, 2014 at 11:43 PM, Ian Barwick wrote: > > > > A simple schedule to demonstrate this is available; execute from the > > > src/test/regress/ directory like this: > > > > > > ./pg_regress \ >