On Fri, Apr 3, 2015 at 5:57 AM, Alvaro Herrera wrote:
You added this in the worker loop processing each table:
/*
* Check for config changes before processing each collected
table.
*/
if (got_SIGHUP)
{
Thanks for your input, Noah.
On Fri, Apr 3, 2015 at 3:22 PM, Noah Misch n...@leadboat.com wrote:
Each Windows patch should cover all Windows build systems; patches that fix a
problem in the src/tools/msvc build while leaving it broken in the GNU make
build are a bad trend. In this case, I
On 03-04-2015 PM 03:58, Amit Langote wrote:
Index childRTindex;
AppendRelInfo *appinfo;
-/* Open rel if needed; we already have required locks */
+/* Open rel if needed; we already have acquired locks */
if (childOID != parentOID)
newrelation =
On Thu, Apr 2, 2015 at 2:46 AM, David Steele da...@pgmasters.net wrote:
Hi Sawada,
On 3/25/15 9:24 AM, David Steele wrote:
On 3/25/15 7:46 AM, Sawada Masahiko wrote:
2.
I got ERROR when executing function uses cursor.
1) create empty table (hoge table)
2) create test function as follows.
On 2 April 2015 at 22:23, Robert Haas robertmh...@gmail.com wrote:
On Thu, Apr 2, 2015 at 5:02 PM, Andres Freund and...@anarazel.de wrote:
I think the upshot is that INSTEAD OF triggers work in a particular way
because that's what is needed to support updatable views. If triggers
on tables
Hi,
Attached does:
Index childRTindex;
AppendRelInfo *appinfo;
-/* Open rel if needed; we already have required locks */
+/* Open rel if needed; we already have acquired locks */
if (childOID != parentOID)
newrelation = heap_open(childOID, NoLock);
On 2015/03/25 4:56, Tom Lane wrote:
Etsuro Fujita fujita.ets...@lab.ntt.co.jp writes:
Let me explain further. Here is the comment in ExecOpenScanRelation:
* Determine the lock type we need. First, scan to see if target
relation
* is a result relation. If not, check if it's
On Fri, Apr 3, 2015 at 2:30 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Apr 3, 2015 at 12:56 PM, Fujii Masao wrote:
The first patch looks good to me basically. But I have one comment:
shouldn't we expose pg_malloc_extended as a global function like
we did pg_malloc? Some
Each Windows patch should cover all Windows build systems; patches that fix a
problem in the src/tools/msvc build while leaving it broken in the GNU make
build are a bad trend. In this case, I expect you'll need few additional
changes to cover both.
On Thu, Apr 02, 2015 at 06:30:02PM +0900,
On Fri, Apr 3, 2015 at 6:35 PM, Fujii Masao wrote:
Regarding the second patch, you added the checks of the return value of
XLogReaderAllocate(). But it seems half-baked. XLogReaderAllocate() still
uses palloc(), but don't we need to replace it with palloc_extended(), too?
Doh, you are right. I
On 2015/03/13 0:50, Tom Lane wrote:
I think the real fix as far as postgres_fdw is concerned is in fact
to let it adopt a different ROW_MARK strategy, since it has meaningful
ctid values. However, that is not a one-size-fits-all answer.
The tableoid problem can be fixed much less invasively
On Mon, Feb 23, 2015 at 7:44 PM, Peter Geoghegan p...@heroku.com wrote:
On Mon, Feb 23, 2015 at 4:41 PM, Tomas Vondra
tomas.von...@2ndquadrant.com wrote:
Are you going to add this into the CF? Would be nice to get this into
9.5. Strictly speaking it should go to 2015-06 I guess, but I'd
On Fri, Apr 3, 2015 at 8:37 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Apr 3, 2015 at 6:35 PM, Fujii Masao wrote:
Regarding the second patch, you added the checks of the return value of
XLogReaderAllocate(). But it seems half-baked. XLogReaderAllocate() still
uses palloc(),
Peter Eisentraut writes:
On 4/2/15 4:32 AM, Jan Urbański wrote:
Peter Eisentraut writes:
I don't think this patch would actually fix the problem that was
described after the original bug report
(http://www.postgresql.org/message-id/5436991b.5020...@vmware.com),
namely that another thread
On Thu, Apr 2, 2015 at 7:02 PM, Peter Geoghegan p...@heroku.com wrote:
On Thu, Apr 2, 2015 at 11:21 PM, Robert Haas robertmh...@gmail.com wrote:
The changes that Andrew
took issue with are utterly insignificant.
Great. Then you will be utterly indifferent to which version gets committed.
On Fri, Apr 3, 2015 at 1:17 PM, Stephen Frost sfr...@snowman.net wrote:
but even I'm not willing to
expend the amount of ink and emotional energy you have on whether a
variable that holds +1, 0, or -1 ought to be declared as int or
int32. Does it matter? Yeah. Is it worth this much
On 4/3/15 3:59 AM, Sawada Masahiko wrote:
On Thu, Apr 2, 2015 at 2:46 AM, David Steele da...@pgmasters.net wrote:
Let me know if you see any other issues.
I pulled HEAD, and then tried to compile source code after applied
following deparsing utility command patch without #0001 and #0002.
On Thu, Apr 2, 2015 at 10:41 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
Robert - Changed some definitions to depend on SIZEOF_DATUM rather
Robert than USE_FLOAT8_BYVAL. Hopefully I didn't muff this; please
Robert check it.
No, that's wrong; it must use USE_FLOAT8_BYVAL since
On Fri, Apr 3, 2015 at 1:07 PM, Robert Haas robertmh...@gmail.com wrote:
I'm about as much
of a stickler for the details as you will find on this mailing list,
or possibly, in the observable universe, but even I'm not willing to
expend the amount of ink and emotional energy you have on whether
* Robert Haas (robertmh...@gmail.com) wrote:
I'm about as much
of a stickler for the details as you will find on this mailing list,
or possibly, in the observable universe,
This made me laugh. :)
but even I'm not willing to
expend the amount of ink and emotional energy you have on whether a
On Thu, Mar 12, 2015 at 8:43 PM, Stas Kelvich stas.kelv...@gmail.com
wrote:
Documentation along with style fix.
Since we change the interface of extension we have to change it version and
create a migration script.
E.g. you have to rename cube--1.0.sql to cube--1.1.sql and create
On Fri, Apr 3, 2015 at 1:49 PM, Robert Haas robertmh...@gmail.com wrote:
Committed. For future reference, I'd prefer to have things like this
added to the next CF rather than no CF at all.
I'll bear that in mind. Thanks.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list
Robert == Robert Haas robertmh...@gmail.com writes:
No, that's wrong; it must use USE_FLOAT8_BYVAL since that's what the
definitions of Int64GetDatum / DatumGetInt64 are conditional on. As
you have it now, it'll break if you build with
--disable-float8-byval on a 64bit platform.
Robert
Michael Paquier wrote:
On Fri, Apr 3, 2015 at 3:26 PM, Michael Paquier wrote:
[...]
Fine for me.
And here are the correct patches. Sorry for that.
Thanks, pushed. I added one extra comment to the SIGHUP patch in the
place where you previously had the exit.
--
Álvaro Herrera
Abhijit Menon-Sen wrote:
At 2015-01-15 14:32:45 +0100, and...@2ndquadrant.com wrote:
Patch attached.
Changes:
1. Renamed perform_fsync to fsync_recursively (otherwise it would read
fsync_pgdata(pg_data))
Okay, but as far as I can tell this function is very specific to
PGDATA; you
Robert == Robert Haas robertmh...@gmail.com writes:
I don't consider it appropriate to override ./configure in this way.
Robert I don't see how that's overriding configure. Commit
Robert 8472bf7a73487b0535c95e299773b882f7523463, which introduced
Robert --disable-float8-byval in 2008,
On Fri, Apr 3, 2015 at 1:39 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
It already does; it changes how int64 values are expected to be stored
in Datum variables. _Everything_ that currently stores an int64 value in
a Datum is affected.
But this isn't a value of the SQL type int64.
Hi All
I am getting compile warnings on OSX 10.10 from clang 6.0:
clang: warning: argument unused during compilation: '-pthread'
The 5 warnings are where we are making a -dynamiclib and
the -pthread argument is not necessary:
./src/interfaces/libpq/
./src/interfaces/ecpg/pgtypeslib/
Peter Eisentraut pete...@gmx.net writes:
On 4/3/15 4:02 PM, John Gorman wrote:
I am getting compile warnings on OSX 10.10 from clang 6.0:
clang: warning: argument unused during compilation: '-pthread'
The 5 warnings are where we are making a -dynamiclib and
the -pthread argument is not
I wrote:
Peter Eisentraut pete...@gmx.net writes:
These warnings also happen with older versions of clang. Now idea how
to fix yet. I'm thinking that clang should be fixed, because these
warnings are stupid.
Yeah, they're utterly stupid; whoever put them in obviously doesn't
have a clue
On Fri, Apr 3, 2015 at 11:59 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Michael Paquier wrote:
On Fri, Apr 3, 2015 at 3:26 PM, Michael Paquier wrote:
[...]
Fine for me.
And here are the correct patches. Sorry for that.
Thanks, pushed. I added one extra comment to the SIGHUP
... btw, has anyone noticed that this patch broke hamerkop and
bowerbird? Or at least, it's hard to see what other recent commit
would explain the failures they're showing.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On 4/3/15 4:02 PM, John Gorman wrote:
I am getting compile warnings on OSX 10.10 from clang 6.0:
clang: warning: argument unused during compilation: '-pthread'
The 5 warnings are where we are making a -dynamiclib and
the -pthread argument is not necessary:
./src/interfaces/libpq/
On Fri, Apr 3, 2015 at 9:57 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Fri, Apr 3, 2015 at 8:37 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Apr 3, 2015 at 6:35 PM, Fujii Masao wrote:
Regarding the second patch, you added the checks of the return value of
Petr Jelinek p...@2ndquadrant.com writes:
my compiler complains about unused variable nblkno in _hash_splitbucket
in no-assert build. It looks like relic of commit ed9cc2b5d which
removed the only use of that variable besides the Assert.
Fixed, thanks!
regards, tom
I wrote:
FWIW, I think it's sensible to define NumericAbbrevGetDatum and the
converse, but I'd suggest you just do it like
#define NumericAbbrevGetDatum(X) Int64GetDatum(X)
or
#define NumericAbbrevGetDatum(X) Int32GetDatum(X)
Oh, scratch that, I'd failed to look at the upthread messages.
Robert == Robert Haas robertmh...@gmail.com writes:
It already does; it changes how int64 values are expected to be
stored in Datum variables. _Everything_ that currently stores an
int64 value in a Datum is affected.
Robert But this isn't a value of the SQL type int64. It's just a
I have confirmed that -Wno-unused-command-line-argument
suppresses the -pthread warning for clang 6.0 and does not
trigger a warning in gcc 4.9.
Works for me!
John
On Fri, Apr 3, 2015 at 5:21 PM, Tom Lane t...@sss.pgh.pa.us wrote:
I wrote:
Peter Eisentraut pete...@gmx.net writes:
These
Robert Haas robertmh...@gmail.com writes:
On Fri, Apr 3, 2015 at 1:39 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
If you're determined to go this route - over my protest - then you need
to do something like define a NumericAbbrevGetDatum(x) macro and use it
in place of the
Robert Haas robertmh...@gmail.com writes:
For those following along at home, the failures are on these queries:
SELECT 1.1 AS two UNION SELECT 2.2;
SELECT 1.1 AS two UNION SELECT 2;
SELECT 1 AS two UNION SELECT 2.2;
SELECT 1.1 AS three UNION SELECT 2 UNION ALL SELECT 2;
In each case, the
The symptom is that the same join query yield different results with
MJ and NLJ/HJ. Here is a repro:
---
create table t1(a int);create table t2(b int);
insert into t1 values(10); insert into t2 values(2);
analyze t1; analyze t2;
set enable_mergejoin=on; set enable_nestloop=off; set
On Fri, Apr 3, 2015 at 5:45 PM, Tom Lane t...@sss.pgh.pa.us wrote:
... btw, has anyone noticed that this patch broke hamerkop and
bowerbird? Or at least, it's hard to see what other recent commit
would explain the failures they're showing.
I noticed the failure on bowerbird today and I agree
On Thu, Apr 02, 2015 at 07:31:52AM -0400, Bruce Momjian wrote:
On Thu, Apr 2, 2015 at 01:44:59AM -0400, Noah Misch wrote:
On Wed, Apr 01, 2015 at 10:49:01PM -0400, Bruce Momjian wrote:
On Sat, Jan 10, 2015 at 02:53:13PM -0500, Tom Lane wrote:
While looking at fe-auth.c I noticed quite a
Hi
2015-03-31 14:38 GMT+02:00 Haribabu Kommi kommi.harib...@gmail.com:
On Mon, Mar 30, 2015 at 4:34 AM, Pavel Stehule pavel.steh...@gmail.com
wrote:
Hi
I checked this patch. I like the functionality and behave.
Thanks for the review.
Here I attached updated patch with the following
On Fri, Apr 3, 2015 at 3:46 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
(This does rather suggest to me that some better regression tests for
sorting would be a good idea, possibly even including on-disk sorts.)
Yeah. I've been unpleasantly surprised by how easy it is to pass the
On Fri, Apr 3, 2015 at 9:06 AM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
Robert == Robert Haas robertmh...@gmail.com writes:
No, that's wrong; it must use USE_FLOAT8_BYVAL since that's what the
definitions of Int64GetDatum / DatumGetInt64 are conditional on. As
you have it now,
Amit Langote langote_amit...@lab.ntt.co.jp writes:
Attached does:
-/* Open rel if needed; we already have required locks */
+/* Open rel if needed; we already have acquired locks */
Does that make sense?
No, not particularly. It could be made to say the locks we require
but I don't
The simple workaround for this was adding a fallback to GEE when f[1] or
f[2] is 0. GEE is another estimator described in the paper, behaving much
better in those cases.
For completeness, what's the downside in just always using GEE?
At 2015-03-31 22:43:49 +0530, a...@2ndquadrant.com wrote:
I'm just posting this WIP patch where I've renamed fastbloat to
pgstatbloat as suggested by Tomas, and added in the documentation, and
so on.
Here's the revised version that also adds the count of RECENTLY_DEAD and
49 matches
Mail list logo
