This is a review of the phypot - Pygmy Hippotause patch:
http://archives.postgresql.org/message-id/4a9897e1.8090...@netspace.net.au
submitted by Paul Matthews.
Contents Purpose
==
The purpose of the patch is to compute a hypotenuse with higher
precision than the current
It looks good to me: (0) new patch applies cleanly to CVS HEAD; (1)
the formating of the code was changed; (2) definition of the HYPOT
macro was changed to use phypot rather than being removed; (3) the
phypot function was declared to be extern; (4) the comments to the
phypot function were changed
Reference: https://commitfest.postgresql.org/action/patch_view?id=312
The patch from
http://archives.postgresql.org/message-id/ca2e4c4762eae28d68404...@amenophis
does not apply cleanly to the current git master:
$ patch -p1 extend_not_null.patch
patching file src/backend/catalog/heap.c
Ok -- I've updated the commitfest page linking in this review and
changing the status to waiting on a new patch from you.
Thanks
Andrew
On Thu, Sep 30, 2010 at 4:12 AM, Bernd Helmle maili...@oopsware.de wrote:
--On 29. September 2010 23:05:11 -0400 Andrew Geery andrew.ge...@gmail.com
wrote
documentation updates). I hope i haven't introduced nasty bugs
and broke something badly, some deeper testing is welcome.
This appears to be waiting on further review from Andrew Geery.
Andrew, will you be posting a new review soon?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
13, 2010 at 9:41 PM, Andrew Geery andrew.ge...@gmail.com wrote:
I'll post it sometime tomorrow...
Thanks
Andrew
On Wed, Oct 13, 2010 at 9:25 PM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Oct 5, 2010 at 4:57 PM, Bernd Helmle maili...@oopsware.de wrote:
--On 30. September 2010 10:12:48
The new patch applies cleanly to head, there are no compile errors and
all the make check tests pass (linux).
Thanks
Andrew
On Thu, Oct 14, 2010 at 4:35 PM, Bernd Helmle maili...@oopsware.de wrote:
--On 14. Oktober 2010 16:28:51 -0300 Alvaro Herrera
alvhe...@commandprompt.com wrote:
