Re: [HACKERS] [PATCH] pg_filedump is broken

2016-10-14 Thread Christoph Berg
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested pg_filedump is a separate git repo, so the commitfest app won't let me mark

Re: [HACKERS] [PATCH] pg_filedump is broken

2016-10-14 Thread Christoph Berg
Re: Aleksander Alekseev 2016-10-12 <20161012111527.GA17916@e733.localdomain> > Hello. > > First patch fixes: > > ``` > pg_filedump.c: In function ‘FormatItem’: > pg_filedump.c:994:18: error: ‘SizeOfIptrData’ undeclared (first use in > this function) >if (numBytes < SizeO

[HACKERS] [PATCH] pg_filedump is broken

2016-10-12 Thread Aleksander Alekseev
Hello. First patch fixes: ``` pg_filedump.c: In function ‘FormatItem’: pg_filedump.c:994:18: error: ‘SizeOfIptrData’ undeclared (first use in this function) if (numBytes < SizeOfIptrData) ``` After 8023b582 there is no more SizeOfIptrData macro. Second patch fixes Makef