Short reads in hash indexes (was: [HACKERS] [sqlsmith] Failed assertion in _hash_splitbucket_guts)

2016-12-06 Thread Andreas Seltenreich
Amit Kapila writes: > On Sat, Dec 3, 2016 at 3:44 PM, Andreas Seltenreich > wrote: >> Amit Kapila writes: >> >>> [2. text/x-diff; fix_hash_bucketsplit_sqlsmith_v1.patch] >> Ok, I'll do testing with the patch applied. Good news: the assertion hasn't fired since the patch is

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_splitbucket_guts

2016-12-05 Thread Robert Haas
On Fri, Dec 2, 2016 at 10:04 PM, Amit Kapila wrote: >> Here we shouldn't be accessing meta page after releasing the lock as >> concurrent activity can change these values. This can be fixed by >> storing these values in local variables before releasing the lock and >>

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_splitbucket_guts

2016-12-03 Thread Amit Kapila
On Sat, Dec 3, 2016 at 3:44 PM, Andreas Seltenreich wrote: > Amit Kapila writes: > >> How should I connect to this database? If I use the user fdw >> mentioned in pg_hba.conf (changed authentication method to trust in >> pg_hba.conf), it says the user doesn't exist. Can you

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_splitbucket_guts

2016-12-03 Thread Andreas Seltenreich
Amit Kapila writes: > How should I connect to this database? If I use the user fdw > mentioned in pg_hba.conf (changed authentication method to trust in > pg_hba.conf), it says the user doesn't exist. Can you create a user > in the database which I can use? There is also a superuser "postgres"

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_splitbucket_guts

2016-12-02 Thread Amit Kapila
On Sat, Dec 3, 2016 at 6:58 AM, Amit Kapila wrote: > On Sat, Dec 3, 2016 at 2:06 AM, Andreas Seltenreich > wrote: >> Hi, >> >> the new hash index code on 11003eb failed an assertion yesterday: >> >> TRAP: FailedAssertion("!(bucket == obucket)",

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_splitbucket_guts

2016-12-02 Thread Amit Kapila
On Sat, Dec 3, 2016 at 2:06 AM, Andreas Seltenreich wrote: > Hi, > > the new hash index code on 11003eb failed an assertion yesterday: > > TRAP: FailedAssertion("!(bucket == obucket)", File: "hashpage.c", Line: > 1037) > This can happen if we start new split before

[HACKERS] [sqlsmith] Failed assertion in _hash_splitbucket_guts

2016-12-02 Thread Andreas Seltenreich
Hi, the new hash index code on 11003eb failed an assertion yesterday: TRAP: FailedAssertion("!(bucket == obucket)", File: "hashpage.c", Line: 1037) Statement was update public.hash_i4_heap set seqno = public.hash_i4_heap.random; It can be reproduced with the data directory (Debian