Re: [HACKERS] A couple of tsearch loose ends

2007-08-22 Thread Dimitri Fontaine
Hi list, Le mardi 21 août 2007, Tom Lane a écrit : CREATE TEXT SEARCH DICTIONARY swedish ( TEMPLATE = snowball, LANGUAGE = swedish, STOPWORDS = swedish ); ALTER TEXT SEARCH DICTIONARY swedish ( STOPWORDS ); this dictionary would have LANGUAGE = swedish and no stopwords

Re: [HACKERS] A couple of tsearch loose ends

2007-08-22 Thread Tom Lane
Dimitri Fontaine [EMAIL PROTECTED] writes: I don't understand why this ALTER variation is so different from existing=20 ones, but maybe the following syntax can't work: ALTER TEXT SEARCH DICTIONARY swedish ALTER STOPWORDS SET swedish; You'd have to repeat the whole command for each option to

Re: [HACKERS] A couple of tsearch loose ends

2007-08-22 Thread Stefan Kaltenbrunner
Tom Lane wrote: Dimitri Fontaine [EMAIL PROTECTED] writes: I don't understand why this ALTER variation is so different from existing=20 ones, but maybe the following syntax can't work: ALTER TEXT SEARCH DICTIONARY swedish ALTER STOPWORDS SET swedish; You'd have to repeat the whole command

[HACKERS] A couple of tsearch loose ends

2007-08-21 Thread Tom Lane
There are a couple of naming issues that I left untouched while reviewing the tsearch patch, but wanted to bring up for discussion. One thing that had me confused for awhile is that the patch uses the word template in two different ways. The main use is that a template is an object encapsulating

Re: [HACKERS] A couple of tsearch loose ends

2007-08-21 Thread Pavel Stehule
Hello The other thing that was bugging me was that a lot of the dictionary types have init options that are named things like DictFile, AffFile, etc. As I mentioned before, I dislike the fact that these things are out in the filesystem rather than inside the database, and hope that that

Re: [HACKERS] A couple of tsearch loose ends

2007-08-21 Thread Teodor Sigaev
COPY instead of TEMPLATE. Another thought here is that I'm inclined to drop the with map option and just always copy the source configuration exactly. If you don't want the map, the only other information the source can provide is a parser name, which you might as well just give directly. I

Re: [HACKERS] A couple of tsearch loose ends

2007-08-21 Thread Tom Lane
Teodor Sigaev [EMAIL PROTECTED] writes: I havn't any objections. with map was introduced when another options was existed - locale and default flag. OK, I'll make that happen. The other thing that was bugging me was that a lot of the dictionary types have init options that are named

Re: [HACKERS] A couple of tsearch loose ends

2007-08-21 Thread Bruce Momjian
Tom Lane wrote: There are a couple of naming issues that I left untouched while reviewing the tsearch patch, but wanted to bring up for discussion. One thing that had me confused for awhile is that the patch uses the word template in two different ways. The main use is that a template is

Re: [HACKERS] A couple of tsearch loose ends

2007-08-21 Thread Oleg Bartunov
On Tue, 21 Aug 2007, Tom Lane wrote: When you look at it, this is downright silly. Why don't we flatten the two levels together and write something like CREATE TEXT SEARCH DICTIONARY swedish ( TEMPLATE = snowball, LANGUAGE = swedish, STOPWORDS = swedish ); Dictionary is a program