On Wed, Feb 15, 2017 at 7:45 PM, Amit Langote
wrote:
> You're right. Took this one out (except slightly tweaking the comment) in
> the attached updated patch.
Committed after tweaking the other comment in that function.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Po
On 2017/02/15 2:37, Robert Haas wrote:
> On Mon, Feb 13, 2017 at 2:30 AM, Amit Langote
> wrote:
>> I noticed that running ALTER TABLE table_name DETACH PARTITION crashes, if
>> table_name is not a partitioned table. That's because of an Assert in
>> ATExecDetachPartition(). We really should err
On Mon, Feb 13, 2017 at 2:30 AM, Amit Langote
wrote:
> I noticed that running ALTER TABLE table_name DETACH PARTITION crashes, if
> table_name is not a partitioned table. That's because of an Assert in
> ATExecDetachPartition(). We really should error out much sooner in this
> case, IOW during
I noticed that running ALTER TABLE table_name DETACH PARTITION crashes, if
table_name is not a partitioned table. That's because of an Assert in
ATExecDetachPartition(). We really should error out much sooner in this
case, IOW during transformAlterTableStmt(), as is done in the case of
ATTACH PA