Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 2017-06-06 12:53:21 -0700, Andres Freund wrote: > On 2017-06-06 15:48:42 -0400, Robert Haas wrote: > > On Fri, Jun 2, 2017 at 3:24 PM, Andres Freund wrote: > > > Latches work in single user mode, it's just that the new code for some > > > reason uses uninitialized memory as

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 2017-06-06 15:48:42 -0400, Robert Haas wrote: > On Fri, Jun 2, 2017 at 3:24 PM, Andres Freund wrote: > > Latches work in single user mode, it's just that the new code for some > > reason uses uninitialized memory as the latch. As I pointed out above, > > the new code

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On Fri, Jun 2, 2017 at 3:24 PM, Andres Freund wrote: > Latches work in single user mode, it's just that the new code for some > reason uses uninitialized memory as the latch. As I pointed out above, > the new code really should just use MyLatch instead of > MyProc->procLatch.

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 6/2/17 23:06, Peter Eisentraut wrote: > On 6/2/17 15:41, Tom Lane wrote: >> It's certainly plausible that we could have the latch code just ignore >> WL_POSTMASTER_DEATH if not IsUnderPostmaster. I think that the original >> reasoning for not doing that was that the calling code should know

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 6/2/17 15:24, Andres Freund wrote: > but that doesn't really solve the issue that > logical rep pretty essentially requires multiple processes. But it may be sensible to execute certain DDL commands for repair, which is why I'm arguing for a finer-grained approach than just prohibiting

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 6/2/17 15:41, Tom Lane wrote: > It's certainly plausible that we could have the latch code just ignore > WL_POSTMASTER_DEATH if not IsUnderPostmaster. I think that the original > reasoning for not doing that was that the calling code should know which > environment it's in, and not pass an

Re: [HACKERS] Error while creating subscription when server is running in single user mode

Peter Eisentraut writes: > My point is that we shouldn't be putting checks into DDL commands about > single-user mode if the actual cause of the issue is in a lower-level > system. Not all uses of a particular DDL command necessary use a latch, > for example.

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 2017-06-02 15:00:21 -0400, Peter Eisentraut wrote: > On 6/1/17 21:55, Andres Freund wrote: > > On 2017-06-01 21:42:41 -0400, Peter Eisentraut wrote: > >> We should look at what the underlying problem is before we prohibit > >> anything at a high level. > > > > I'm not sure there's any

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 6/1/17 21:55, Andres Freund wrote: > On 2017-06-01 21:42:41 -0400, Peter Eisentraut wrote: >> We should look at what the underlying problem is before we prohibit >> anything at a high level. > > I'm not sure there's any underlying issue here, except being in single > user mode. My point is

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 2017-06-01 21:42:41 -0400, Peter Eisentraut wrote: > We should look at what the underlying problem is before we prohibit > anything at a high level. I'm not sure there's any underlying issue here, except being in single user mode. > When I try it, I get a > > TRAP:

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On 6/1/17 04:49, Dilip Kumar wrote: > On Thu, Jun 1, 2017 at 1:02 PM, Michael Paquier > wrote: >> Thanks, this looks correct to me at quick glance. >> >> +if (!IsUnderPostmaster) >> +ereport(FATAL, >> +(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On Thu, Jun 1, 2017 at 1:02 PM, Michael Paquier wrote: > Thanks, this looks correct to me at quick glance. > > +if (!IsUnderPostmaster) > +ereport(FATAL, > +(errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > +errmsg("subscription commands

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On Wed, May 31, 2017 at 10:49 PM, Dilip Kumar wrote: > On Wed, May 31, 2017 at 2:20 PM, Michael Paquier > wrote: >> Yeah, see 0e0f43d6 for example. A simple fix is to look at >> IsUnderPostmaster when creating, altering or dropping a subscription

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On Wed, May 31, 2017 at 2:20 PM, Michael Paquier wrote: > Yeah, see 0e0f43d6 for example. A simple fix is to look at > IsUnderPostmaster when creating, altering or dropping a subscription > in subscriptioncmds.c. Yeah, below patch fixes that. -- Regards, Dilip Kumar

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On Wed, May 31, 2017 at 7:01 AM, Dilip Kumar wrote: > On Wed, May 31, 2017 at 7:54 AM, tushar wrote: >> centos@centos-cpula bin]$ ./postgres --single postgres -D m1data >> PostgreSQL stand-alone backend 10beta1 >> backend> create subscription

Re: [HACKERS] Error while creating subscription when server is running in single user mode

On Wed, May 31, 2017 at 7:54 AM, tushar wrote: > centos@centos-cpula bin]$ ./postgres --single postgres -D m1data > PostgreSQL stand-alone backend 10beta1 > backend> create subscription sub connection 'dbname=postgres port=5433 > user=centos' publication p with

[HACKERS] Error while creating subscription when server is running in single user mode

Hi, There is an error while creating subscription when server is running in single user mode centos@centos-cpula bin]$ ./postgres --single postgres -D m1data PostgreSQL stand-alone backend 10beta1 backend> create subscription sub connection 'dbname=postgres port=5433 user=centos' publication