Re: [HACKERS] Help text for pg_basebackup -R

2017-02-18 Thread Magnus Hagander
On Fri, Feb 17, 2017 at 5:21 PM, Tom Lane wrote: > Stephen Frost writes: > > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > >> Magnus Hagander wrote: > >>> I'm guessing if we backpatch something like that, it would cause > issues for > >>>

Re: [HACKERS] Help text for pg_basebackup -R

2017-02-17 Thread Tom Lane
Stephen Frost writes: > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: >> Magnus Hagander wrote: >>> I'm guessing if we backpatch something like that, it would cause issues for >>> translations, right? So we should make it head only? >> We've had the argument a number of

Re: [HACKERS] Help text for pg_basebackup -R

2017-02-17 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Magnus Hagander wrote: > > On Wednesday, February 15, 2017, Alvaro Herrera > > wrote: > > > > > Magnus Hagander wrote: > > > > > > > printf(_(" -R, --write-recovery-conf\n" > > > > - "

Re: [HACKERS] Help text for pg_basebackup -R

2017-02-17 Thread Alvaro Herrera
Magnus Hagander wrote: > On Wednesday, February 15, 2017, Alvaro Herrera > wrote: > > > Magnus Hagander wrote: > > > > > printf(_(" -R, --write-recovery-conf\n" > > > - " write recovery.conf > > after backup\n")); > >

Re: [HACKERS] Help text for pg_basebackup -R

2017-02-17 Thread Magnus Hagander
On Wednesday, February 15, 2017, Alvaro Herrera wrote: > Magnus Hagander wrote: > > > printf(_(" -R, --write-recovery-conf\n" > > - " write recovery.conf > after backup\n")); > > + "

Re: [HACKERS] Help text for pg_basebackup -R

2017-02-15 Thread Alvaro Herrera
Magnus Hagander wrote: > printf(_(" -R, --write-recovery-conf\n" > - " write recovery.conf after > backup\n")); > + " write recovery.conf for > replication\n")); > printf(_(" -S,

[HACKERS] Help text for pg_basebackup -R

2017-02-15 Thread Magnus Hagander
The current help text for pg_basebackup -R is "write recovery.conf after backup". This says nothing about what it actually does. I've had a number of people ask me now why that's not default "because you need a recovery.conf to restore from backup". The point being that it doesn't say anything