Re: [HACKERS] Leftover member in openssl part of Port struct
> On 31 Aug 2016, at 15:12, Tom Lane wrote: > > Daniel Gustafsson writes: >> When SSL renegotiation was removed in 426746b9 the only consumer of the >> openssl >> specific count member in the Port struct was removed, but the member was left >> together with a few updates to it which are unused. Attached patch removes >> the >> leftovers which now serves no purpose unless I’m missing something. > > Hm, well, we can't remove those case labels as control would then end > up in the default case which throws an error. Doh, I’ll go stand in the corner. > But otherwise this seems > sound. Without renegotiation the count is not very useful anyway > since it's likely to overflow (at least if long is 32 bits). Yeah. Thanks for applying. cheers ./daniel -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Leftover member in openssl part of Port struct
Daniel Gustafsson writes: > When SSL renegotiation was removed in 426746b9 the only consumer of the > openssl > specific count member in the Port struct was removed, but the member was left > together with a few updates to it which are unused. Attached patch removes > the > leftovers which now serves no purpose unless Iâm missing something. Hm, well, we can't remove those case labels as control would then end up in the default case which throws an error. But otherwise this seems sound. Without renegotiation the count is not very useful anyway since it's likely to overflow (at least if long is 32 bits). regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Leftover member in openssl part of Port struct
When SSL renegotiation was removed in 426746b9 the only consumer of the openssl specific count member in the Port struct was removed, but the member was left together with a few updates to it which are unused. Attached patch removes the leftovers which now serves no purpose unless I’m missing something. cheers ./daniel 0001-Remove-leftover-member-count-in-Port.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
