Re: [HACKERS] Minor comment improvement to create_foreignscan_plan

2015-11-18 Thread Robert Haas
On Tue, Nov 17, 2015 at 9:29 PM, Etsuro Fujita wrote: > On 2015/11/18 2:57, Robert Haas wrote: >> On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita >> wrote: >>> >>> Oops, I've found another one. I think we should update a comment in >>>

Re: [HACKERS] Minor comment improvement to create_foreignscan_plan

2015-11-18 Thread Etsuro Fujita
On 2015/11/19 5:29, Robert Haas wrote: On Tue, Nov 17, 2015 at 9:29 PM, Etsuro Fujita wrote: On 2015/11/18 2:57, Robert Haas wrote: On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita wrote: Oops, I've found another one. I think we

Re: [HACKERS] Minor comment improvement to create_foreignscan_plan

2015-11-17 Thread Robert Haas
On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita wrote: > Oops, I've found another one. I think we should update a comment in > postgresGetForeignPlan, too; add remote filtering expressions to the list of > information needed to create a ForeignScan node. Instead of

Re: [HACKERS] Minor comment improvement to create_foreignscan_plan

2015-11-17 Thread Etsuro Fujita
On 2015/11/18 2:57, Robert Haas wrote: On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita wrote: Oops, I've found another one. I think we should update a comment in postgresGetForeignPlan, too; add remote filtering expressions to the list of information needed to

Re: [HACKERS] Minor comment improvement to create_foreignscan_plan

2015-11-15 Thread Etsuro Fujita
On 2015/11/12 19:02, Etsuro Fujita wrote: On 2015/11/10 3:53, Robert Haas wrote: On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita wrote: Here is a small patch to update an comment in create_foreignscan_plan; add fdw_recheck_quals to the list of expressions that need

Re: [HACKERS] Minor comment improvement to create_foreignscan_plan

2015-11-12 Thread Etsuro Fujita
On 2015/11/10 3:53, Robert Haas wrote: On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita wrote: Here is a small patch to update an comment in create_foreignscan_plan; add fdw_recheck_quals to the list of expressions that need the replace_nestloop_params processing. I

Re: [HACKERS] Minor comment improvement to create_foreignscan_plan

2015-11-09 Thread Robert Haas
On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita wrote: > Here is a small patch to update an comment in create_foreignscan_plan; > add fdw_recheck_quals to the list of expressions that need the > replace_nestloop_params processing. I should have updated the comment >

[HACKERS] Minor comment improvement to create_foreignscan_plan

2015-11-09 Thread Etsuro Fujita
Hi, Here is a small patch to update an comment in create_foreignscan_plan; add fdw_recheck_quals to the list of expressions that need the replace_nestloop_params processing. I should have updated the comment when I proposed the patch for the fdw_recheck_quals. Best regards, Etsuro Fujita ***