On Wed, Oct 25, 2017 at 5:32 PM, Michael Paquier
wrote:
> On Mon, Oct 23, 2017 at 6:50 AM, Michael Paquier
> wrote:
> > Okay, attached is what I think a fully implemented patch should look
> > like. On top of what Andrew has done, I added and reworked the
> > following:
> > - removed duplicate e
On Mon, Oct 23, 2017 at 6:50 AM, Michael Paquier
wrote:
> Okay, attached is what I think a fully implemented patch should look
> like. On top of what Andrew has done, I added and reworked the
> following:
> - removed duplicate error handling.
> - documented the function in funcapi.h and funcapi.c.
On Mon, Oct 23, 2017 at 7:03 AM, Michael Paquier
wrote:
>> Looks good otherwise.
>
> My set of diffs for funcapi.h are actually that:
> * funcapi.h
> * Definitions for functions which return composite type and/or sets
> + * or work on VARIADIC inputs.
> [...]
> +/*--
> + * Support
On Mon, Oct 23, 2017 at 6:11 AM, Tom Lane wrote:
> This comment is neither correct nor intelligible:
>
> /* important for value, key cannot being NULL */
>
> I'd say just drop it.
Yep.
> The checks for "could not determine data type" errors seem
> rather duplicative, too.
Yep.
>
> The
On 10/22/2017 04:35 PM, Michael Paquier wrote:
> On Mon, Oct 23, 2017 at 1:44 AM, Andrew Dunstan
> wrote:
>
>> here's a patch that works that way, based on Michael's code.
> Patch not attached :)
> I still have a patch half-cooked, that I can send if necessary, but
> you are on it, right?
Sorr
On Mon, Oct 23, 2017 at 1:44 AM, Andrew Dunstan
wrote:
>
>
> On 10/22/2017 12:11 PM, Andrew Dunstan wrote:
>>
>> On 10/21/2017 07:33 PM, Michael Paquier wrote:
>>> On Sun, Oct 22, 2017 at 1:43 AM, Tom Lane wrote:
I don't think collecting all the arguments is particularly special ---
for
On 10/22/2017 12:11 PM, Andrew Dunstan wrote:
>
> On 10/21/2017 07:33 PM, Michael Paquier wrote:
>> On Sun, Oct 22, 2017 at 1:43 AM, Tom Lane wrote:
>>> I don't think collecting all the arguments is particularly special ---
>>> format() or concat() for instance could possibly use this. You migh
