Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

2017-04-12 Thread Amit Langote 
On 2017/04/13 12:11, Fujii Masao wrote:
> On Wed, Apr 12, 2017 at 10:32 AM, Amit Langote
>  wrote:
>> On 2017/04/12 0:22, Fujii Masao wrote:
>>> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote
>>>  wrote:
 On 2017/04/07 0:56, Fujii Masao wrote:
> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
>  wrote:
>> It seems pg_stat_progress_vacuum is not supposed to appear in the table
>> titled "Collected Statistics Views".  It was added by c16dc1aca.  
>> Attached
>> patch fixes that.
>
> Instead, it should appear in the table of "Dynamic Statistics Views"
> because it reports dynamic info, i.e., progress, about VACUUM activity?

 I thought the same at first, but then realized we have a entirely separate
 section 28.4. Progress Reporting.
>>>
>>> Yes, but I don't think that removing that from 28.2 is an improvement
>>> for users.
>>
>> Perhaps you're right.  Here's a patch that moves pg_stat_progress_vacuum
>> to the Dynamic Statistics Views table.
> 
> Thanks for the patch! Pushed.

Thanks,

Regards,
Amit



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

2017-04-12 Thread Fujii Masao 
On Wed, Apr 12, 2017 at 10:32 AM, Amit Langote
 wrote:
> On 2017/04/12 0:22, Fujii Masao wrote:
>> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote
>>  wrote:
>>> On 2017/04/07 0:56, Fujii Masao wrote:
 On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
  wrote:
> It seems pg_stat_progress_vacuum is not supposed to appear in the table
> titled "Collected Statistics Views".  It was added by c16dc1aca.  Attached
> patch fixes that.

 Instead, it should appear in the table of "Dynamic Statistics Views"
 because it reports dynamic info, i.e., progress, about VACUUM activity?
>>>
>>> I thought the same at first, but then realized we have a entirely separate
>>> section 28.4. Progress Reporting.
>>
>> Yes, but I don't think that removing that from 28.2 is an improvement
>> for users.
>
> Perhaps you're right.  Here's a patch that moves pg_stat_progress_vacuum
> to the Dynamic Statistics Views table.

Thanks for the patch! Pushed.

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

2017-04-11 Thread Amit Langote 
On 2017/04/12 0:22, Fujii Masao wrote:
> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote
>  wrote:
>> On 2017/04/07 0:56, Fujii Masao wrote:
>>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
>>>  wrote:
 It seems pg_stat_progress_vacuum is not supposed to appear in the table
 titled "Collected Statistics Views".  It was added by c16dc1aca.  Attached
 patch fixes that.
>>>
>>> Instead, it should appear in the table of "Dynamic Statistics Views"
>>> because it reports dynamic info, i.e., progress, about VACUUM activity?
>>
>> I thought the same at first, but then realized we have a entirely separate
>> section 28.4. Progress Reporting.
> 
> Yes, but I don't think that removing that from 28.2 is an improvement
> for users.

Perhaps you're right.  Here's a patch that moves pg_stat_progress_vacuum
to the Dynamic Statistics Views table.

Thanks,
Amit
>From adfdaaa612c15cfa5c9d63cc80846336fe0bc0ca Mon Sep 17 00:00:00 2001
From: amit 
Date: Wed, 12 Apr 2017 10:27:41 +0900
Subject: [PATCH] Move pg_stat_progress_vacuum to Table 28.1

Because, it sounds more like a Dynamic Statistics View than a Collected
Statistics view.
---
 doc/src/sgml/monitoring.sgml | 14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index d42a461ad9..2a83671b53 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -324,6 +324,14 @@ postgres   27093  0.0  0.0  30096  2752 ?Ss   11:34   0:00 postgres: ser
   
  
 
+ 
+  pg_stat_progress_vacuumpg_stat_progress_vacuum
+  One row for each backend (including autovacuum worker processes) running
+   VACUUM, showing current progress.
+   See .
+  
+ 
+
 

   
@@ -515,12 +523,6 @@ postgres   27093  0.0  0.0  30096  2752 ?Ss   11:34   0:00 postgres: ser
   yet included in pg_stat_user_functions).
  
 
- 
-  pg_stat_progress_vacuumpg_stat_progress_vacuum
-  One row for each backend (including autovacuum worker processes) running
-  VACUUM, showing current progress.
-  See .
- 
 

   
-- 
2.11.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

2017-04-11 Thread Fujii Masao 
On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote
 wrote:
> On 2017/04/07 0:56, Fujii Masao wrote:
>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
>>  wrote:
>>> It seems pg_stat_progress_vacuum is not supposed to appear in the table
>>> titled "Collected Statistics Views".  It was added by c16dc1aca.  Attached
>>> patch fixes that.
>>
>> Instead, it should appear in the table of "Dynamic Statistics Views"
>> because it reports dynamic info, i.e., progress, about VACUUM activity?
>
> I thought the same at first, but then realized we have a entirely separate
> section 28.4. Progress Reporting.

Yes, but I don't think that removing that from 28.2 is an improvement
for users.

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

2017-04-06 Thread Amit Langote 
On 2017/04/07 0:56, Fujii Masao wrote:
> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
>  wrote:
>> It seems pg_stat_progress_vacuum is not supposed to appear in the table
>> titled "Collected Statistics Views".  It was added by c16dc1aca.  Attached
>> patch fixes that.
> 
> Instead, it should appear in the table of "Dynamic Statistics Views"
> because it reports dynamic info, i.e., progress, about VACUUM activity?

I thought the same at first, but then realized we have a entirely separate
section 28.4. Progress Reporting.  So it may not be necessary to keep it
anywhere in 28.2.

In fact I also proposed [1] to move the descriptions of "Dynamic
Statistics Views" to a new section within the same chapter.

Thanks,
Amit

[1]
https://www.postgresql.org/message-id/70cd6b98-7c3f-e368-04ed-e053d18b7d81%40lab.ntt.co.jp




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

2017-04-06 Thread Fujii Masao 
On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
 wrote:
> It seems pg_stat_progress_vacuum is not supposed to appear in the table
> titled "Collected Statistics Views".  It was added by c16dc1aca.  Attached
> patch fixes that.

Instead, it should appear in the table of "Dynamic Statistics Views"
because it reports dynamic info, i.e., progress, about VACUUM activity?

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

2017-04-03 Thread Amit Langote 
It seems pg_stat_progress_vacuum is not supposed to appear in the table
titled "Collected Statistics Views".  It was added by c16dc1aca.  Attached
patch fixes that.

Thanks,
Amit
>From 779fd54f0e30455e0393252a4ba4514d23e0af15 Mon Sep 17 00:00:00 2001
From: amit 
Date: Tue, 4 Apr 2017 10:16:53 +0900
Subject: [PATCH] Remove pg_stat_progress_vacuum from Table 28.2

---
 doc/src/sgml/monitoring.sgml | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 9856968997..dbd4d54120 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -514,13 +514,6 @@ postgres   27093  0.0  0.0  30096  2752 ?Ss   11:34   0:00 postgres: ser
   calls during the current transaction (which are not
   yet included in pg_stat_user_functions).
  
-
- 
-  pg_stat_progress_vacuumpg_stat_progress_vacuum
-  One row for each backend (including autovacuum worker processes) running
-  VACUUM, showing current progress.
-  See .
- 
 

   
-- 
2.11.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers