Re: [HACKERS] contrib uninstall scripts need some love

2006-09-28 Thread Bruce Momjian
Joshua D. Drake wrote: Guido Barosio wrote: Let me know if you need an extra pair of eyes. O.k. I do :) Writing the scripts up are easy enough, but I am unsure how the whole make file foo works... OK, are all the uninstall scripts done?

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-28 Thread Joshua D. Drake
Bruce Momjian wrote: Joshua D. Drake wrote: Guido Barosio wrote: Let me know if you need an extra pair of eyes. O.k. I do :) Writing the scripts up are easy enough, but I am unsure how the whole make file foo works... OK, are all the uninstall scripts done? Crap... yes they are, at least

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-14 Thread Joshua D. Drake
Guido Barosio wrote: Let me know if you need an extra pair of eyes. O.k. I do :) Writing the scripts up are easy enough, but I am unsure how the whole make file foo works... Joshua D. Drake G.- On 9/10/06, Joshua D. Drake [EMAIL PROTECTED] wrote: Tom Lane wrote: Joshua D. Drake

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-14 Thread Tom Lane
Joshua D. Drake [EMAIL PROTECTED] writes: O.k. I do :) Writing the scripts up are easy enough, but I am unsure how the whole make file foo works... About all you have to do is add the uninstall script to the DATA = line in the makefile. regards, tom lane

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-13 Thread Tom Lane
Joshua D. Drake [EMAIL PROTECTED] writes: I have seen some patches come across with this. Is this done, or do I still need to work on it? Teodor added an uninstall for hstore, and I think Michael has fixed all the problems in the existing scripts, but we still lack uninstall scripts for the

[HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Tom Lane
Awhile back, someone went around and made sure that all the contrib modules had uninstall scripts, but most of the new contributions since then don't have 'em: adminpack hstore pg_freespacemap pgrowlocks sslinfo all seem to need one. Also, I tested a few of the existing uninstall scripts

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Joshua D. Drake
Tom Lane wrote: Awhile back, someone went around and made sure that all the contrib modules had uninstall scripts, but most of the new contributions since then don't have 'em: adminpack hstore pg_freespacemap pgrowlocks sslinfo all seem to need one. Also, I tested a few of the existing

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Michael Fuhr
On Sun, Sep 10, 2006 at 12:09:24PM -0700, Joshua D. Drake wrote: Tom Lane wrote: Awhile back, someone went around and made sure that all the contrib modules had uninstall scripts, but most of the new contributions since then don't have 'em: adminpack hstore pg_freespacemap pgrowlocks

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Tom Lane
Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Since it's contrib, I don't think we need to hold you to being done before beta1. But the sooner the better of course.

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Joshua D. Drake
Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Since it's contrib, I don't think we need to hold you to being done before beta1. But the sooner the better

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Guido Barosio
Let me know if you need an extra pair of eyes. G.- On 9/10/06, Joshua D. Drake [EMAIL PROTECTED] wrote: Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have?

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Michael Fuhr
On Sun, Sep 10, 2006 at 01:50:39PM -0700, Joshua D. Drake wrote: O.k., I will start working through it and report at the end of the week. I spent a few minutes doing the same tests I did a few months ago and found problems with dblink and ltree; I'll submit patches for those. Tom, do you recall

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes: I spent a few minutes doing the same tests I did a few months ago and found problems with dblink and ltree; I'll submit patches for those. Tom, do you recall which modules gave you trouble? Um ... hstore and tsearch2, I think. I fixed those, but was

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Michael Fuhr
On Sun, Sep 10, 2006 at 07:38:24PM -0400, Tom Lane wrote: Michael Fuhr [EMAIL PROTECTED] writes: I spent a few minutes doing the same tests I did a few months ago and found problems with dblink and ltree; I'll submit patches for those. Tom, do you recall which modules gave you trouble?

Re: [HACKERS] contrib uninstall scripts need some love

2006-09-10 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes: Should untsearch2.sql be renamed to uninstall_tsearch2.sql to be consistent with all the other uninstall scripts? Yeah, that and lo_drop are outliers that probably ought to be renamed. Offhand I don't see any serious compatibility objection --- who does