Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf

[Fujii Masao]

On Tue, Apr 11, 2017 at 4:50 PM, Masahiko Sawada  wrote:
> On Tue, Apr 11, 2017 at 1:39 AM, Fujii Masao  wrote:
>> On Mon, Apr 10, 2017 at 9:39 PM, Masahiko Sawada  
>> wrote:
>>> On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
>>>  wrote:
 On 10/04/17 07:16, Masahiko Sawada wrote:
> Hi all,
>
> Attached a patch for $subject.
>
> I added this parameter into "Asynchronous Behavior" section of
> "RESOURCE" section. But GUC parameter for subscriber now is written in
> this section, in spite of there is "REPLICATION" section. I think that
> we can coordinate these parameters to not confuse user. For example in
> documentation, these parameters are described in "19.6.4. Subscribers"
> section of "19.6. Replication" section. Thought?
>>
>> Yes, I think that we should not only add the parameter into
>> postgresql.conf.sample
>> but also
>>
>> - add REPLICATION_SUBSCRIBERS into config_group
>> - mark max_logical_replication_workers and max_sync_workers_per_subscription
>>   as REPLICATION_SUBSCRIBERS parameters, in guc.c
>> - move those parameters into "Subscribers" section in postgresql.conf.sample
>
> +1
>
>> The attached patch does these.
>
> The patch looks good to me.

Pushed. Thanks!

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf

[Masahiko Sawada]

On Tue, Apr 11, 2017 at 1:39 AM, Fujii Masao  wrote:
> On Mon, Apr 10, 2017 at 9:39 PM, Masahiko Sawada  
> wrote:
>> On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
>>  wrote:
>>> On 10/04/17 07:16, Masahiko Sawada wrote:
 Hi all,

 Attached a patch for $subject.

 I added this parameter into "Asynchronous Behavior" section of
 "RESOURCE" section. But GUC parameter for subscriber now is written in
 this section, in spite of there is "REPLICATION" section. I think that
 we can coordinate these parameters to not confuse user. For example in
 documentation, these parameters are described in "19.6.4. Subscribers"
 section of "19.6. Replication" section. Thought?
>
> Yes, I think that we should not only add the parameter into
> postgresql.conf.sample
> but also
>
> - add REPLICATION_SUBSCRIBERS into config_group
> - mark max_logical_replication_workers and max_sync_workers_per_subscription
>   as REPLICATION_SUBSCRIBERS parameters, in guc.c
> - move those parameters into "Subscribers" section in postgresql.conf.sample

+1

> The attached patch does these.

The patch looks good to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf

[Fujii Masao]

On Mon, Apr 10, 2017 at 9:39 PM, Masahiko Sawada  wrote:
> On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
>  wrote:
>> On 10/04/17 07:16, Masahiko Sawada wrote:
>>> Hi all,
>>>
>>> Attached a patch for $subject.
>>>
>>> I added this parameter into "Asynchronous Behavior" section of
>>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>>> this section, in spite of there is "REPLICATION" section. I think that
>>> we can coordinate these parameters to not confuse user. For example in
>>> documentation, these parameters are described in "19.6.4. Subscribers"
>>> section of "19.6. Replication" section. Thought?

Yes, I think that we should not only add the parameter into
postgresql.conf.sample
but also

- add REPLICATION_SUBSCRIBERS into config_group
- mark max_logical_replication_workers and max_sync_workers_per_subscription
  as REPLICATION_SUBSCRIBERS parameters, in guc.c
- move those parameters into "Subscribers" section in postgresql.conf.sample

The attached patch does these.

Regards,

-- 
Fujii Masao


Add_max_sync_workers_per_subscription_into_postgresql_conf_v3.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf

[Masahiko Sawada]

On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
 wrote:
> On 10/04/17 07:16, Masahiko Sawada wrote:
>> Hi all,
>>
>> Attached a patch for $subject.
>>
>> I added this parameter into "Asynchronous Behavior" section of
>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>> this section, in spite of there is "REPLICATION" section. I think that
>> we can coordinate these parameters to not confuse user. For example in
>> documentation, these parameters are described in "19.6.4. Subscribers"
>> section of "19.6. Replication" section. Thought?
>>
>
> Good catch, but it's actually taken from max_logical_replication_workers
> so the patch should look more like attached IMHO.
>

Thank you for the patch. The patch looks good to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf

[Petr Jelinek]

On 10/04/17 07:16, Masahiko Sawada wrote:
> Hi all,
> 
> Attached a patch for $subject.
> 
> I added this parameter into "Asynchronous Behavior" section of
> "RESOURCE" section. But GUC parameter for subscriber now is written in
> this section, in spite of there is "REPLICATION" section. I think that
> we can coordinate these parameters to not confuse user. For example in
> documentation, these parameters are described in "19.6.4. Subscribers"
> section of "19.6. Replication" section. Thought?
> 

Good catch, but it's actually taken from max_logical_replication_workers
so the patch should look more like attached IMHO.

-- 
  Petr Jelinek  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 512be0a..9107c20 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -165,6 +165,7 @@
 #max_parallel_workers = 8	# maximum number of max_worker_processes that
 	# can be used in parallel queries
 #max_logical_replication_workers = 4	# taken from max_worker_processes
+#max_sync_workers_per_subscription = 2	# taken from max_logical_replication_workers
 #old_snapshot_threshold = -1		# 1min-60d; -1 disables; 0 is immediate
 	# (change requires restart)
 #backend_flush_after = 0		# measured in pages, 0 disables

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf

[Masahiko Sawada]

Hi all,

Attached a patch for $subject.

I added this parameter into "Asynchronous Behavior" section of
"RESOURCE" section. But GUC parameter for subscriber now is written in
this section, in spite of there is "REPLICATION" section. I think that
we can coordinate these parameters to not confuse user. For example in
documentation, these parameters are described in "19.6.4. Subscribers"
section of "19.6. Replication" section. Thought?

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


Add_max_sync_workers_per_subscription_into_postgresql_conf.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers