Re: [HACKERS] where to add/change commands

2007-03-15 Thread Grzegorz Jaskiewicz
ok, it works okay. Thanks. I am really serious about adding this patch. I would like it to not only show which tables/indices are being clustered, but also some sort of progress information (print procentage of job being done, etc). Any hints, as on what might be useful for others. Perhaps

Re: [HACKERS] where to add/change commands

2007-03-15 Thread Gregory Stark
"Grzegorz Jaskiewicz" <[EMAIL PROTECTED]> writes: > On Mar 15, 2007, at 12:26 PM, Peter Eisentraut wrote: > >> >> Your patch works perfectly fine for me. > > Ok, I'll try make distclean/make -j2/sudo make install, reboot and will see. > I was kinda beliving that remaking whole thing from scratch o

Re: [HACKERS] where to add/change commands

2007-03-15 Thread Grzegorz Jaskiewicz
On Mar 15, 2007, at 12:26 PM, Peter Eisentraut wrote: Your patch works perfectly fine for me. Ok, I'll try make distclean/make -j2/sudo make install, reboot and will see. I was kinda beliving that remaking whole thing from scratch over and over again wouldn't be a necessity here. thanks

Re: [HACKERS] where to add/change commands

2007-03-15 Thread Peter Eisentraut
Grzegorz Jaskiewicz wrote: > meaning that if I type in "CLUSTER VERBOSE" in psql, I get syntax > error. Your patch works perfectly fine for me. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kil

Re: [HACKERS] where to add/change commands

2007-03-15 Thread Grzegorz Jaskiewicz
On Mar 15, 2007, at 11:46 AM, NikhilS wrote: Grzegorz, I would have suggested to make an entry for VERBOSE in parser/keywords.c, but it already seems to contain an entry for VERBOSE. I hope you are using the "opt_verbose" rule in your gram.y in the CLUSTER [VERBOSE] case. sure I am. M

Re: [HACKERS] where to add/change commands

2007-03-15 Thread NikhilS
Hi, psql? There's some code to detect commands that can't be run in a transaction block in src/bin/psql/common.c, maybe that's what you're looking for. Or did you mean something else? How doesn't it "pick it up"? I think he probably meant that he was getting a syntax error, even after maki

Re: [HACKERS] where to add/change commands

2007-03-15 Thread Grzegorz Jaskiewicz
On Mar 15, 2007, at 11:36 AM, Heikki Linnakangas wrote: Grzegorz Jaskiewicz wrote: I am trying to make CLUSTER command just a bit verbose,as an option here. Added bits to gram.y that should support CLUSTER [VERBOSE] ... but psql doesn't seem to pick it up. psql? There's some code to detec

Re: [HACKERS] where to add/change commands

2007-03-15 Thread Heikki Linnakangas
Grzegorz Jaskiewicz wrote: I am trying to make CLUSTER command just a bit verbose,as an option here. Added bits to gram.y that should support CLUSTER [VERBOSE] ... but psql doesn't seem to pick it up. psql? There's some code to detect commands that can't be run in a transaction block in src/b

[HACKERS] where to add/change commands

2007-03-15 Thread Grzegorz Jaskiewicz
Hi folks I am trying to make CLUSTER command just a bit verbose,as an option here. Added bits to gram.y that should support CLUSTER [VERBOSE] ... but psql doesn't seem to pick it up. Where else do I need to update it, besides gram.y, cluster.c and of course adding new field to ClusterStmt.