Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-03-22 Thread Haribabu Kommi
On Wed, Mar 22, 2017 at 7:57 PM, Ideriha, Takeshi < ideriha.take...@jp.fujitsu.com> wrote: > Hi, thank you very much for reviewing. > Attached is v6 patch. > > >There was a minor conflict in applying 004_declareXX patch. > > I rebased 004_declareStmt_test_v6.patch. > > >Some comments in 001_declar

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-03-22 Thread Haribabu Kommi
On Wed, Mar 22, 2017 at 12:51 PM, Haribabu Kommi wrote: > > > On Tue, Mar 7, 2017 at 4:09 PM, Ideriha, Takeshi < > ideriha.take...@jp.fujitsu.com> wrote: > >> >> Attached 004_declareStmt_test_v5.patch is a rebased one. >> The rest of patches are same as older version. >> > > Thanks for the update

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-03-21 Thread Haribabu Kommi
On Tue, Mar 7, 2017 at 4:09 PM, Ideriha, Takeshi < ideriha.take...@jp.fujitsu.com> wrote: > > Attached 004_declareStmt_test_v5.patch is a rebased one. > The rest of patches are same as older version. > Thanks for the update patch. I started reviewing the patches. There was a minor conflict in ap

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-03-05 Thread Okano, Naoki
Hi I tried applying your patches. But it failed... The error messages are as below. $ git apply ../004_declareStmt_test_v4.patch error: patch failed: src/interfaces/ecpg/test/expected/pgtypeslib-nan_test.c:82 error: src/interfaces/ecpg/test/expected/pgtypeslib-nan_test.c: patch does not apply R

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-01-24 Thread Michael Paquier
On Wed, Jan 25, 2017 at 2:58 PM, Ideriha, Takeshi wrote: > Hi, > > I'm sorry but I think I don't have time to work on this patch in this CF. > I've gotten busy for another work. > > So I moved this patch to next CF with "waiting on author" status. Thanks for doing so, that's a time-saver for me!

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-01-24 Thread Ideriha, Takeshi
gt; Sent: Friday, January 20, 2017 6:12 PM > To: 'Michael Paquier' > Cc: Michael Meskes ; pgsql-hackers@postgresql.org > Subject: RE: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in > ECPG > > > Idehira-san, this is a very intrusive patch... It really

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-01-20 Thread Ideriha, Takeshi
> Idehira-san, this is a very intrusive patch... It really needs a specific > reviewer to begin with, but really it would be nice if you could review > someone > else's patch, with a difficulty rather equivalent to what we have here. Michael, thank you for taking a look at my patch and giving me

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-01-17 Thread Michael Paquier
On Fri, Jan 6, 2017 at 6:10 PM, Ideriha, Takeshi wrote: > Hi > Thank you for looking over my patch. > >> Thank you. Would it be possible for you to re-create the patch without the >> white-space changes? > > I'm sorry for adding redundant white-spaces. > Attached is a correct version. > >> I notic

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-01-01 Thread Michael Meskes
Hi Ideriha-san, > I created a patch. Thank you. Would it be possible for you to re-create the patch without the white-space changes? > I marked [WIP] to the title because some documentation is lacked and > format needs some fixing. I noticed that the docs say the statement is a PostgreSQL addo

[WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2016-12-27 Thread Ideriha, Takeshi
> > I'm looking forward to seeing your patch. > I created a patch. I marked [WIP] to the title because some documentation is lacked and format needs some fixing. I'm going to post this patch to the January CF. But it's my first time to send a patch so please excuse me if there's something yo