On Fri, Aug 29, 2014 at 12:39 PM, Tom Lane wrote:
> Haribabu Kommi writes:
>> Thanks for your review. Please find the rebased patch to latest HEAD.
>
> Committed with minor (mostly cosmetic) alterations.
Thanks.
Regards,
Hari Babu
Fujitsu Australia
--
Sent via pgsql-hackers mailing list (pgs
Haribabu Kommi writes:
> Thanks for your review. Please find the rebased patch to latest HEAD.
Committed with minor (mostly cosmetic) alterations.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscripti
On Mon, Aug 18, 2014 at 8:12 PM, Asif Naeem wrote:
> Thank you for sharing updated patch. With latest 9.5 source code, patch
> build is failing with following error message i.e.
>
>> /Applications/Xcode.app/Contents/Developer/usr/bin/make -C catalog
>> schemapg.h
>> cd ../../../src/include/catalog
Thank you for sharing updated patch. With latest 9.5 source code, patch
build is failing with following error message i.e.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C catalog
> schemapg.h
> cd ../../../src/include/catalog && '/opt/local/bin/perl' ./duplicate_oids
> 3255
> make[3]:
On Mon, Aug 4, 2014 at 3:22 PM, Asif Naeem wrote:
> Sorry for not being clear, above mentioned test is related to following doc
> (sgml) changes that seems not working as described i.e.
>
> Table 9-35. cidr and inet Functions
>
> FunctionReturn TypeDescriptionExampleResult
>
> max(inet, inet) ine
Thank you Haribabu. Please see my comments inlined below i.e.
On Sun, Jul 27, 2014 at 11:42 AM, Haribabu Kommi
wrote:
> On Thu, Jul 24, 2014 at 5:59 PM, Asif Naeem wrote:
> > Sorry for being late. Thank you for sharing updated patch, sgml changes
> > seems not working i.e.
> >
> >> postgres=# s
On Thu, Jul 24, 2014 at 5:59 PM, Asif Naeem wrote:
> Sorry for being late. Thank you for sharing updated patch, sgml changes
> seems not working i.e.
>
>> postgres=# select max('192.168.1.5', '192.168.1.4');
>> ERROR: function max(unknown, unknown) does not exist
>> LINE 1: select max('192.168.1.
Hi Haribabu,
Sorry for being late. Thank you for sharing updated patch, sgml changes
seems not working i.e.
postgres=# select max('192.168.1.5', '192.168.1.4');
> ERROR: function max(unknown, unknown) does not exist
> LINE 1: select max('192.168.1.5', '192.168.1.4');
>^
> HINT:
Hi Asif,
On Wed, Jul 9, 2014 at 6:51 PM, Haribabu Kommi
wrote:
> On Mon, Jul 7, 2014 at 6:59 PM, Asif Naeem wrote:
> > Hi Haribabu,
> >
> > Thank you for sharing the patch. I have spent some time to review the
> > changes. Overall patch looks good to me, make check and manual testing
seems
> > r
On Mon, Jul 7, 2014 at 6:59 PM, Asif Naeem wrote:
> Hi Haribabu,
>
> Thank you for sharing the patch. I have spent some time to review the
> changes. Overall patch looks good to me, make check and manual testing seems
> run fine with it. There seems no related doc/sgml changes ?. Patch added
> net
Hi Haribabu,
Thank you for sharing the patch. I have spent some time to review the
changes. Overall patch looks good to me, make check and manual testing
seems run fine with it. There seems no related doc/sgml changes ?. Patch
added network_smaller() and network_greater() functions but in PG sourc
On Mon, Jun 30, 2014 at 4:45 PM, Abhijit Menon-Sen
wrote:
> At 2014-06-30 16:35:45 +0500, anaeem...@gmail.com wrote:
> >
> > pc1dotnetpk:postgresql asif$ patch -p0 <
> > > ~/core/min_max_support_for_inet_datatypes/inet_agg_v4.patch
> > > can't find file to patch at input line 3
> > > Perhaps you
At 2014-06-30 16:35:45 +0500, anaeem...@gmail.com wrote:
>
> pc1dotnetpk:postgresql asif$ patch -p0 <
> > ~/core/min_max_support_for_inet_datatypes/inet_agg_v4.patch
> > can't find file to patch at input line 3
> > Perhaps you used the wrong -p or --strip option?
> > The text leading up to this was
Hi Haribabu,
I am not able to apply latest patch on REL9_4_STABLE or master branch i.e.
pc1dotnetpk:postgresql asif$ git apply
> ~/core/min_max_support_for_inet_datatypes/inet_agg_v4.patch
> fatal: unrecognized input
pc1dotnetpk:postgresql asif$ patch -p0 <
> ~/core/min_max_support_for_inet_dat
On Thu, Jun 5, 2014 at 9:12 AM, Andres Freund wrote:
> Hi,
>
> On 2014-06-04 10:37:48 +1000, Haribabu Kommi wrote:
>> Thanks for the test. Patch is re-based to the latest head.
>
> Did you look at the source of the conflict? Did you intentionally mark
> the functions as leakproof and reviewed that
Hi,
On 2014-06-04 10:37:48 +1000, Haribabu Kommi wrote:
> Thanks for the test. Patch is re-based to the latest head.
Did you look at the source of the conflict? Did you intentionally mark
the functions as leakproof and reviewed that that truly is the case? Or
was that caused by copy & paste?
Gre
Andres Freund writes:
> On 2014-06-03 10:37:53 -0400, Tom Lane wrote:
>> It hasn't even got a comment saying why changes here should
>> receive any scrutiny; moreover, it's not in a file where changes would be
>> likely to excite suspicion. (Probably it should be in opr_sanity, if
>> we're going
On 2014-06-03 10:37:53 -0400, Tom Lane wrote:
> It hasn't even got a comment saying why changes here should
> receive any scrutiny; moreover, it's not in a file where changes would be
> likely to excite suspicion. (Probably it should be in opr_sanity, if
> we're going to have such a thing at all.)
On Tue, Jun 3, 2014 at 8:37 PM, Haribabu Kommi
wrote:
> On Wed, Jun 4, 2014 at 5:46 AM, Keith Fiske wrote:
> >
> > Andres's changes on June 3rd to
> >
> https://github.com/postgres/postgres/commits/master/src/test/regress/expected/create_function_3.out
> > are causing patch v2 to fail for that r
On Wed, Jun 4, 2014 at 5:46 AM, Keith Fiske wrote:
>
> Andres's changes on June 3rd to
> https://github.com/postgres/postgres/commits/master/src/test/regress/expected/create_function_3.out
> are causing patch v2 to fail for that regression test file.
>
> postgres $ patch -p1 -i ../inet_agg_v2.patc
On Tue, Jun 3, 2014 at 10:48 AM, Andres Freund
wrote:
> On 2014-06-03 10:37:53 -0400, Tom Lane wrote:
> > Andres Freund writes:
> > > On 2014-06-03 10:24:46 -0400, Tom Lane wrote:
> > >> Personally, I would wonder why the regression tests contain such a
> query
> > >> in the first place. It see
On 2014-06-03 10:37:53 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2014-06-03 10:24:46 -0400, Tom Lane wrote:
> >> Personally, I would wonder why the regression tests contain such a query
> >> in the first place. It seems like nothing but a major maintenance PITA.
>
> > I haven't added
Andres Freund writes:
> On 2014-06-03 10:24:46 -0400, Tom Lane wrote:
>> Personally, I would wonder why the regression tests contain such a query
>> in the first place. It seems like nothing but a major maintenance PITA.
> I haven't added it, but it seems appropriate in that specific case. The
>
On 2014-06-03 10:24:46 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I didn't reall look at the patch, but it very much looks to me like that
> > query result could use the \a\t treatment that rules.sql and
> > sanity_check.sql got. It's hard to see the actual difference
> > before/after the
Andres Freund writes:
> I didn't reall look at the patch, but it very much looks to me like that
> query result could use the \a\t treatment that rules.sql and
> sanity_check.sql got. It's hard to see the actual difference
> before/after the patch.
> I'll patch that now, to reduce the likelihood o
Hi,
On 2014-06-03 12:43:28 +1000, Haribabu Kommi wrote:
> *** a/src/test/regress/expected/create_function_3.out
> --- b/src/test/regress/expected/create_function_3.out
> ***
> *** 153,389 RESET SESSION AUTHORIZATION;
> SELECT proname, prorettype::regtype, proargtypes::regtype[]
On Thu, May 29, 2014 at 3:28 AM, Keith Fiske wrote:
> On Sun, Mar 23, 2014 at 10:42 PM, Haribabu Kommi
> wrote:
>>
>> On Fri, Mar 21, 2014 at 5:17 PM, wrote:
>> > The following bug has been logged on the website:
>> > reclog=> select * from foo;
>> >bar
>> > -
>> > 1.2.3.4
>> > (1
27 matches
Mail list logo
