Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

2017-05-19 Thread Tom Lane
Michael Paquier writes: > Do you think that it would be better to list the letter list for each > keyword in repl_scanner.l or have something more generic? As not that > many commands are added in the replication protocol, I would think > that this is more than enough

Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

2017-05-19 Thread Michael Paquier
On Sat, May 20, 2017 at 5:32 AM, Tom Lane wrote: > We'd probably be better off to implement case-insensitivity the hard way. > There is a reason why none of our other flex scanners use this switch. Do you think that it would be better to list the letter list for each keyword

Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

2017-05-19 Thread Tom Lane
"Higuchi, Daisuke" writes: > By adding flex option '-i', replication command parser could be more > flexible. > This option is already used for syncrep_scanner.c, so it is not strange to > add for repl_scanner.c too. Really? That wasn't an especially bright

Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

2017-05-19 Thread Robert Haas
On Fri, May 19, 2017 at 12:51 AM, Michael Paquier wrote: > On Fri, May 19, 2017 at 1:16 PM, Higuchi, Daisuke > wrote: >> The reason of this problem is that sending 'show transaction_read_only' is >> failed. >> 'show' must be in

Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

2017-05-19 Thread Higuchi, Daisuke
From: Michael Paquier [mailto:michael.paqu...@gmail.com] > if (!PQsendQuery(conn, >- "show transaction_read_only")) >+ "SHOW transaction_read_only")) >Or perhaps the replication command parser could be made

Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

2017-05-18 Thread Michael Paquier
On Fri, May 19, 2017 at 1:16 PM, Higuchi, Daisuke wrote: > The reason of this problem is that sending 'show transaction_read_only' is > failed. > 'show' must be in uppercase letters because the streaming replication > protocol only accepts capital letters. > In