Re: [HACKERS] [COMMITTERS] pgsql: Add ALTER TABLESPACE ... MOVE command

2014-04-12 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Ick. That's just plain sloppy. Please create a separate production, > *and* a separate comment header. Done. > Commit d86d51a95 was pretty damn awful in this regard as well, but > let's clean them both up, not make it worse. Yeah, I think I noticed this

Re: [HACKERS] [COMMITTERS] pgsql: Add ALTER TABLESPACE ... MOVE command

2014-04-04 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Commit d86d51a95 was pretty damn awful in this regard as well, but > let's clean them both up, not make it worse. Fair enough. I recall being a bit surprised at it also but didn't spend much time thinking about it. I'll clean it up. Thanks,

Re: [HACKERS] [COMMITTERS] pgsql: Add ALTER TABLESPACE ... MOVE command

2014-04-03 Thread Tom Lane
Alvaro Herrera writes: > Stephen Frost wrote: >> Add ALTER TABLESPACE ... MOVE command > I just noticed that this commit added the new commands under the > "ALTER THING name RENAME TO" production (which were originally for > RenameStmt); since commit d86d51a95 had already added some > AlterTableS

Re: [HACKERS] [COMMITTERS] pgsql: Add ALTER TABLESPACE ... MOVE command

2014-04-03 Thread Alvaro Herrera
Stephen Frost wrote: > Add ALTER TABLESPACE ... MOVE command > > This adds a 'MOVE' sub-command to ALTER TABLESPACE which allows moving sets of > objects from one tablespace to another. This can be extremely handy and > avoids > a lot of error-prone scripting. ALTER TABLESPACE ... MOVE will onl