Re: [HACKERS] [sqlsmith] Failed assertion in adjust_appendrel_attrs_mutator

2017-10-23 Thread Amit Langote
On 2017/10/24 0:22, Tom Lane wrote: > Amit Langote writes: >> On 2017/10/23 2:07, Tom Lane wrote: >>> Hmm. adjust_appendrel_attrs() thinks it's only used after conversion >>> of sublinks to subplans, but this is a counterexample. I wonder if >>> that assumption

Re: [HACKERS] [sqlsmith] Failed assertion in adjust_appendrel_attrs_mutator

2017-10-23 Thread Tom Lane
Amit Langote writes: > On 2017/10/23 2:07, Tom Lane wrote: >> Hmm. adjust_appendrel_attrs() thinks it's only used after conversion >> of sublinks to subplans, but this is a counterexample. I wonder if >> that assumption was ever correct? Or maybe we need to

Re: [HACKERS] [sqlsmith] Failed assertion in adjust_appendrel_attrs_mutator

2017-10-23 Thread Amit Langote
On 2017/10/23 2:07, Tom Lane wrote: > Andreas Seltenreich writes: >> testing master as of 7c981590c2, sqlsmith just triggered the following >> assertion: >> TRAP: FailedAssertion("!(!const Node*)(node))->type) == T_SubLink))", >> File: "prepunion.c", Line: 2231) > > Hmm.

Re: [HACKERS] [sqlsmith] Failed assertion in adjust_appendrel_attrs_mutator

2017-10-22 Thread Tom Lane
Andreas Seltenreich writes: > testing master as of 7c981590c2, sqlsmith just triggered the following > assertion: > TRAP: FailedAssertion("!(!const Node*)(node))->type) == T_SubLink))", > File: "prepunion.c", Line: 2231) Hmm. adjust_appendrel_attrs() thinks it's only