Re: [HACKERS] Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

2012-02-27 Thread Alvaro Herrera
Excerpts from Noah Misch's message of jue ene 26 12:00:49 -0300 2012: > > On Wed, Jan 25, 2012 at 10:39:56PM -0500, Noah Misch wrote: > > In any event, the patch needed a rebase, so I've attached it rebased and > > with > > that comment edited to reference ri_GenerateQualCollation(), that being

Re: [HACKERS] Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

2012-01-26 Thread Noah Misch
On Wed, Jan 25, 2012 at 10:39:56PM -0500, Noah Misch wrote: > In any event, the patch needed a rebase, so I've attached it rebased and with > that comment edited to reference ri_GenerateQualCollation(), that being the > most-relevant source for the assumption in question. Commit 9d35116611e6a1fc10

Re: [HACKERS] Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

2012-01-25 Thread Noah Misch
On Wed, Jan 25, 2012 at 11:17:27AM -0300, Alvaro Herrera wrote: > > Excerpts from Noah Misch's message of dom ene 22 02:05:31 -0300 2012: > > > Thanks. I've attached a new version fixing this problem. > > Looks good to me. Can you please clarify this bit? > >* Since we

Re: [HACKERS] Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

2012-01-25 Thread Alvaro Herrera
Excerpts from Noah Misch's message of dom ene 22 02:05:31 -0300 2012: > Thanks. I've attached a new version fixing this problem. Looks good to me. Can you please clarify this bit? * Since we elsewhere require that all collations share the same

Re: [HACKERS] Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

2012-01-21 Thread Jeff Janes
On Sat, Jan 21, 2012 at 9:05 PM, Noah Misch wrote: > On Sat, Jan 21, 2012 at 08:04:20PM -0800, Jeff Janes wrote: >> This is failing "make check" for me. >> >> >> *** /tmp/foo/src/test/regress/expected/alter_table.out  Sat Jan 21 19:51:46 >> 2012 >> --- /tmp/foo/src/test/regress/results/alter_tabl

Re: [HACKERS] Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

2012-01-21 Thread Noah Misch
On Sat, Jan 21, 2012 at 08:04:20PM -0800, Jeff Janes wrote: > This is failing "make check" for me. > > > *** /tmp/foo/src/test/regress/expected/alter_table.out Sat Jan 21 19:51:46 > 2012 > --- /tmp/foo/src/test/regress/results/alter_table.out Sat Jan 21 19:54:18 > 2012 > *** > **

Re: [HACKERS] Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

2012-01-21 Thread Jeff Janes
On Wed, Jan 4, 2012 at 12:35 PM, Noah Misch wrote: > I neglected to commit after revising the text of a few comments; use this > version instead.  Thanks. > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.o

Re: [HACKERS] Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

2012-01-04 Thread Noah Misch
I neglected to commit after revising the text of a few comments; use this version instead. Thanks. diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 3b52415..9eba8e8 100644 *** a/src/backend/commands/tablecmds.c --- b/src/backend/commands/tablecmds.c **