Re: [HACKERS] Changes in Trigger Firing

2013-12-05 Thread Sameer Kumar
One scenario where I can forsee an issue is when someone uses the tablename with-in the trigger function on which the trigger was fired. I am not sure how and what issue might crop up but this will be one of my test cases. -- View this message in context: http://postgresql.1045698.n5.nabble.com

Re: [HACKERS] Changes in Trigger Firing

2013-12-05 Thread Sameer Kumar
I have been finally able to get the right set of files. I going with below approach: 1) Add a new column in pg_trigger called tgiscascaded 2) Change pg_trigger.h for this 3) Made changes in trigger.c to insert this values 4) Corresponding changes made in - reltrigger.h

Re: [HACKERS] Changes in Trigger Firing

2013-12-05 Thread Sameer Kumar
> > > I read somewhere that "the best editor is the > one you master" (1) :) > 1: http://www.postgresql.org/message-id/m2wrs6giyp@hi-media.com > > Thanks, I am using eclipse now. Any comments about the utility of this feature? Or is it just me who thinks this can be useful? I think users/dev

Re: [HACKERS] Changes in Trigger Firing

2013-12-04 Thread Michael Paquier
On Wed, Dec 4, 2013 at 11:16 PM, Alvaro Herrera wrote: > Sameer Kumar wrote: > I think you need better tools to guide you in exploring the source code. > For example, you can use cscope to tell you where is CreateTrigStmt > used, and you would find gram.y; and use it to tell you where > CreateTrig

Re: [HACKERS] Changes in Trigger Firing

2013-12-04 Thread Sameer Kumar
> > > > > > CreateTrigStmt is passed to CreateTrigger function as an arguement. I am > > struggling to understand how the values for various members of trigger > are > > set and where [which file] calls CreateTrigStmt. > > > > > > Can someone provide some help on this? > > I think you need better t

Re: [HACKERS] Changes in Trigger Firing

2013-12-04 Thread Alvaro Herrera
Sameer Kumar wrote: > > CreateTrigStmt is passed to CreateTrigger function as an arguement. I am > struggling to understand how the values for various members of trigger are > set and where [which file] calls CreateTrigStmt. > > > Can someone provide some help on this? I think you need better