Peter Eisentraut writes:
> On 6/15/17 15:57, Tom Lane wrote:
>> Pushed, thanks. I grabbed the very latest copy of ax_prog_perl_modules
>> out of the GNU archives --- it's only cosmetically different, but we
>> might as well be au courant.
> Um, this patch was previously rejected. Shouldn't we a
On 6/15/17 15:57, Tom Lane wrote:
> Pushed, thanks. I grabbed the very latest copy of ax_prog_perl_modules
> out of the GNU archives --- it's only cosmetically different, but we
> might as well be au courant.
Um, this patch was previously rejected. Shouldn't we at least discuss
it, or have it go
Michael Paquier writes:
> On Tue, Jun 13, 2017 at 11:14 PM, Tom Lane wrote:
>> I'd vote for removing this and adding a configure-time check that
>> insists on IPC::Run when --enable-tap-tests is given.
> There was a patch last year to do something like that:
> https://www.postgresql.org/message-
On 6/13/17 03:49, Michael Paquier wrote:
> 001_ssltests.pl in src/test/ssl/ includes the following to skip all
> tests should IPC::Run be not available:
We used to have stanzas like that elsewhere but then removed them in
favor of the configure option. It looks like this was forgotten. I
have co
On Tue, Jun 13, 2017 at 11:14 PM, Tom Lane wrote:
> Certainly, it's pointless to have a defense only here. And I know very
> well that make check falls over in an ugly, hard-to-interpret-if-you've-
> not-seen-it-before fashion if you do --enable-tap-tests and don't have
> IPC::Run installed.
>
>
Michael Paquier writes:
> 001_ssltests.pl in src/test/ssl/ includes the following to skip all
> tests should IPC::Run be not available:
> ...
> In all the other tests or modules we don't bother about such a thing
> as prove_check only works if --enable-tap-test is used, and we get a
> hard failure
