Re: [HACKERS] Error-like LOG when connecting with SSL for password authentication

2017-07-03 Thread Michael Paquier
On Mon, Jul 3, 2017 at 9:02 PM, Heikki Linnakangas wrote: > Thanks, I've pushed the backend read part of this patch. Thanks. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Error-like LOG when connecting with SSL for password authentication

2017-07-03 Thread Heikki Linnakangas
On 05/24/2017 05:29 PM, Michael Paquier wrote: Attached is an updated patch. Thanks, I've pushed the backend read part of this patch. That's enough to fix the original complaint with password authentication. I think the rest was a bit dubious, and I'm hesitant to commit that (or at least to

Re: [HACKERS] Error-like LOG when connecting with SSL for password authentication

2017-05-24 Thread Michael Paquier
On Tue, May 23, 2017 at 6:26 AM, Heikki Linnakangas wrote: > Yeah. The be_tls_read() change looks OK to me. > > Can SSL_ERROR_ZERO_RETURN also happen in a write? I suppose it can, but > returning 0 from secure_write() seems iffy. It seems to me that it could be the case, the man page of SSL_write

Re: [HACKERS] Error-like LOG when connecting with SSL for password authentication

2017-05-23 Thread Michael Paquier
On Tue, May 23, 2017 at 6:36 AM, Heikki Linnakangas wrote: > On 05/22/2017 10:11 PM, Vaishnavi Prabakaran wrote: >> >> On Mon, May 22, 2017 at 5:10 PM, Michael Paquier >> >> wrote: >> >>> If the protocol version is SSL >>> 3.0 or TLS 1.0, this result code is returned only if a closure alert >>> h

Re: [HACKERS] Error-like LOG when connecting with SSL for password authentication

2017-05-23 Thread Heikki Linnakangas
On 05/22/2017 10:11 PM, Vaishnavi Prabakaran wrote: On Mon, May 22, 2017 at 5:10 PM, Michael Paquier wrote: If the protocol version is SSL 3.0 or TLS 1.0, this result code is returned only if a closure alert has occurred in the protocol, i.e. if the connection has been closed cleanly. Note tha

Re: [HACKERS] Error-like LOG when connecting with SSL for password authentication

2017-05-23 Thread Heikki Linnakangas
On 05/22/2017 03:10 AM, Michael Paquier wrote: Hi all, When attempting to connect using password authentication through SSL, the backend will complain in its log with the following entry before calling sendAuthRequest(), which asks the client for a password: LOG: could not receive data from cli

Re: [HACKERS] Error-like LOG when connecting with SSL for password authentication

2017-05-22 Thread Vaishnavi Prabakaran
On Mon, May 22, 2017 at 5:10 PM, Michael Paquier wrote: > If the protocol version is SSL > 3.0 or TLS 1.0, this result code is returned only if a closure alert > has occurred in the protocol, i.e. if the connection has been closed > cleanly. Note that in this case SSL_ERROR_ZERO_RETURN does not >