Re: [HACKERS] Exposing currentTransactionWALVolume

2014-02-17 Thread KONDO Mitsumasa
(2014/02/15 23:04), Andres Freund wrote: Hi Simon, On 2014-01-14 17:12:35 +, Simon Riggs wrote: /* - * MarkCurrentTransactionIdLoggedIfAny + * ReportTransactionInsertedWAL * - * Remember that the current xid - if it is assigned - now has been wal logged. + * Remember that the curre

Re: [HACKERS] Exposing currentTransactionWALVolume

2014-02-15 Thread Andres Freund
Hi Simon, On 2014-01-14 17:12:35 +, Simon Riggs wrote: > /* > - * MarkCurrentTransactionIdLoggedIfAny > + * ReportTransactionInsertedWAL > * > - * Remember that the current xid - if it is assigned - now has been wal > logged. > + * Remember that the current xid - if it is assigned - has

Re: [HACKERS] Exposing currentTransactionWALVolume

2014-01-31 Thread Simon Riggs
On 31 January 2014 13:56, Fujii Masao wrote: > On Wed, Jan 15, 2014 at 2:12 AM, Simon Riggs wrote: >> Short patch to expose a function GetCurrentTransactionWALVolume() that >> gives the total number of bytes written to WAL by current transaction. > > Could you tell me the use case of this functio

Re: [HACKERS] Exposing currentTransactionWALVolume

2014-01-31 Thread Mitsumasa KONDO
I send you my review comment. 2014-01-15 Simon Riggs : > Short patch to expose a function GetCurrentTransactionWALVolume() that > gives the total number of bytes written to WAL by current transaction. > * It's simple and good feature. It is useful for system management, and forecasting server spe

Re: [HACKERS] Exposing currentTransactionWALVolume

2014-01-31 Thread Fujii Masao
On Wed, Jan 15, 2014 at 2:12 AM, Simon Riggs wrote: > Short patch to expose a function GetCurrentTransactionWALVolume() that > gives the total number of bytes written to WAL by current transaction. Could you tell me the use case of this function? ISTM that it's less useful in the real world becau