Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-18 Thread Fujii Masao
On Thu, Jul 18, 2013 at 1:49 PM, Rushabh Lathia rushabh.lat...@gmail.com wrote: On Thu, Jul 18, 2013 at 9:40 AM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/07/18 2:31), Fujii Masao wrote: On Tue, Jul 16, 2013 at 3:00 PM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/07/04 3:58),

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-17 Thread Fujii Masao
On Tue, Jul 16, 2013 at 3:00 PM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/07/04 3:58), Fujii Masao wrote: On Wed, Jun 26, 2013 at 12:39 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 20, 2013 at 2:32 PM, Fujii Masao masao.fu...@gmail.com wrote: Since pg_relpages(oid) doesn't

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-17 Thread Satoshi Nagayasu
(2013/07/18 2:31), Fujii Masao wrote: On Tue, Jul 16, 2013 at 3:00 PM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/07/04 3:58), Fujii Masao wrote: For the test, I just implemented the regclass-version of pg_relpages() (patch attached) and tested some cases. But I could not get that problem.

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-17 Thread Rushabh Lathia
On Thu, Jul 18, 2013 at 9:40 AM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/07/18 2:31), Fujii Masao wrote: On Tue, Jul 16, 2013 at 3:00 PM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/07/04 3:58), Fujii Masao wrote: For the test, I just implemented the regclass-version of

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-16 Thread Satoshi Nagayasu
(2013/07/04 3:58), Fujii Masao wrote: On Wed, Jun 26, 2013 at 12:39 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 20, 2013 at 2:32 PM, Fujii Masao masao.fu...@gmail.com wrote: Since pg_relpages(oid) doesn't exist, pg_relpages() is in the same situation as pgstatindex(), i.e., we

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-16 Thread Satoshi Nagayasu
Hi Rushabh, (2013/07/16 14:58), Rushabh Lathia wrote: Hello Satoshi, I assigned myself for the reviewer of this patch. Issue status is waiting on author. Thank you for picking it up. Now looking at the discussion under the thread it seems like we are waiting for the suggestion for the new

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-16 Thread Rushabh Lathia
Hi Satoshi, I spent some time on the revised version on the patch(pgstattuple_regclass_v2.diff) and here are my comments. .) Patch get applies cleanly on PG master branch .) Successful build and database creation .) Basic test coverage included in the patch .) make check running cleanly

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-15 Thread Rushabh Lathia
Hello Satoshi, I assigned myself for the reviewer of this patch. Issue status is waiting on author. Now looking at the discussion under the thread it seems like we are waiting for the suggestion for the new function name, right ? I am wondering why actually we need new name ? Can't we just

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-07-03 Thread Fujii Masao
On Wed, Jun 26, 2013 at 12:39 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 20, 2013 at 2:32 PM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jun 20, 2013 at 11:43 AM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/06/17 4:02), Fujii Masao wrote: On Sat, Mar 9, 2013 at 3:23 PM,

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 2:32 PM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jun 20, 2013 at 11:43 AM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/06/17 4:02), Fujii Masao wrote: On Sat, Mar 9, 2013 at 3:23 PM, Satoshi Nagayasu sn...@uptime.jp wrote: It is obviously easy to keep two

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-06-20 Thread Fujii Masao
On Thu, Jun 20, 2013 at 11:43 AM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/06/17 4:02), Fujii Masao wrote: On Sat, Mar 9, 2013 at 3:23 PM, Satoshi Nagayasu sn...@uptime.jp wrote: It is obviously easy to keep two types of function interfaces, one with regclass-type and another with

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-06-19 Thread Satoshi Nagayasu
(2013/06/17 4:02), Fujii Masao wrote: On Sat, Mar 9, 2013 at 3:23 PM, Satoshi Nagayasu sn...@uptime.jp wrote: It is obviously easy to keep two types of function interfaces, one with regclass-type and another with text-type, in the next release for backward-compatibility like below:

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-06-16 Thread Fujii Masao
On Sat, Mar 9, 2013 at 3:23 PM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/03/05 22:46), Robert Haas wrote: On Sun, Mar 3, 2013 at 5:32 PM, Tom Lane t...@sss.pgh.pa.us wrote: Maybe this is acceptable collateral damage. I don't know. But we definitely stand a chance of breaking

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-03-08 Thread Satoshi Nagayasu
(2013/03/05 22:46), Robert Haas wrote: On Sun, Mar 3, 2013 at 5:32 PM, Tom Lane t...@sss.pgh.pa.us wrote: Maybe this is acceptable collateral damage. I don't know. But we definitely stand a chance of breaking applications if we change pgstatindex like this. It might be better to invent a

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-03-05 Thread Robert Haas
On Sun, Mar 3, 2013 at 5:32 PM, Tom Lane t...@sss.pgh.pa.us wrote: Maybe this is acceptable collateral damage. I don't know. But we definitely stand a chance of breaking applications if we change pgstatindex like this. It might be better to invent a differently-named function to replace

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-03-03 Thread Tom Lane
Satoshi Nagayasu sn...@uptime.jp writes: My goal is to allow specifying a relation/index with several expressions, 'relname', 'schemaname.relname' and oid in all pgstattuple functions. pgstatindex() does not accept oid so far. I have found that the backward-compatibility can be kept when the