Re: [HACKERS] INSERT and parentheses

2010-09-18 Thread Tom Lane
Marko Tiikkaja marko.tiikk...@cs.helsinki.fi writes: [ patch for a misleading error message ] I've committed the attached revised version of this patch. The main change is to only emit the hint if the insertion source can be shown to be a RowExpr with exactly the number of columns expected by

Re: [HACKERS] INSERT and parentheses

2010-08-24 Thread Marko Tiikkaja
On 2010-08-24 8:25 AM +0300, igor polishchuk wrote: Marko et al, This is my first ever attempt of a patch review just for learning the procedure. I'm not a postgres developer, so the review is partial and mostly from the usability prospective. That's all right. I'm sure any help is

Re: [HACKERS] INSERT and parentheses

2010-05-31 Thread Bruce Momjian
I have added this to the next commit-fest: https://commitfest.postgresql.org/action/commitfest_view?id=6 --- Marko Tiikkaja wrote: Hi, This came up on IRC today and I recall several instances of this during

Re: [HACKERS] INSERT and parentheses

2010-04-26 Thread Robert Haas
On Mon, Apr 26, 2010 at 8:57 AM, Marko Tiikkaja marko.tiikk...@cs.helsinki.fi wrote: Hi, This came up on IRC today and I recall several instances of this during the last two months or so, so I decided to send a patch.  The problem in question occurs when you have extra parentheses in an

Re: [HACKERS] INSERT and parentheses

2010-04-26 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: The first version is a lot more common and as it turns out, is sometimes very hard to spot.  This patch attaches a HINT message to these two cases.  The message itself could probably be a lot better, but I can't think of anything. Thoughts?

Re: [HACKERS] INSERT and parentheses

2010-04-26 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: Not to be a pain, but the hint really is kind of terrible.. It'd probably be better if you included somewhere that the insert appears to be a single column with a record-type rather than multiple columns of non-composite type.. I don't much care for