Re: [HACKERS] Missing newlines in error messages

2016-12-15 Thread Magnus Hagander
On Thu, Dec 15, 2016 at 4:38 PM, Tom Lane wrote: > Magnus Hagander writes: > > While poking around the pg_basebackup code, I noticed there are a lot of > > error messages are missing the \n at the end. Most of them are very > > unlikely to happen, but in general I believe all error messages we p

Re: [HACKERS] Missing newlines in error messages

2016-12-15 Thread Tom Lane
Magnus Hagander writes: > While poking around the pg_basebackup code, I noticed there are a lot of > error messages are missing the \n at the end. Most of them are very > unlikely to happen, but in general I believe all error messages we print to > stderr from those binaries should have a newline

Re: [HACKERS] Missing newlines in error messages

2016-12-15 Thread Magnus Hagander
(oops, accidental send button press) While poking around the pg_basebackup code, I noticed there are a lot of error messages are missing the \n at the end. Most of them are very unlikely to happen, but in general I believe all error messages we print to stderr from those binaries should have a ne