Re: [HACKERS] Questionable coding in orderedsetaggs.c

2014-01-25 Thread Atri Sharma
On Sunday, January 26, 2014, Tom Lane wrote: > Jeremy Harris > writes: > > In ordered_set_startup() sorts are initialised in non-randomAccess mode > > (tuplesort_begin_heap() and ~datum(), last argument). > > > The use of tuplesort_skip_tuples() feels very like a random access to > > me. I think

Re: [HACKERS] Questionable coding in orderedsetaggs.c

2014-01-25 Thread Tom Lane
Jeremy Harris writes: > In ordered_set_startup() sorts are initialised in non-randomAccess mode > (tuplesort_begin_heap() and ~datum(), last argument). > The use of tuplesort_skip_tuples() feels very like a random access to > me. I think it doesn't fail because the only use (and implementation)