Re: [HACKERS] Random PGDLLIMPORTing

2016-11-26 Thread Magnus Hagander
On Fri, Nov 25, 2016 at 9:54 AM, Craig Ringer wrote: > On 25 November 2016 at 14:16, Tom Lane wrote: > > Craig Ringer writes: > >> PGDLLIMPORT is free, so the question should be "is there a reason not > >> to add it here?". > > > > TBH, my basic complaint about it is that I do not like Microsof

Re: [HACKERS] Random PGDLLIMPORTing

2016-11-25 Thread Craig Ringer
On 25 November 2016 at 14:16, Tom Lane wrote: > Craig Ringer writes: >> PGDLLIMPORT is free, so the question should be "is there a reason not >> to add it here?". > > TBH, my basic complaint about it is that I do not like Microsoft's tool > chain assuming that it's entitled to demand that people

Re: [HACKERS] Random PGDLLIMPORTing

2016-11-24 Thread Tom Lane
Craig Ringer writes: > PGDLLIMPORT is free, so the question should be "is there a reason not > to add it here?". TBH, my basic complaint about it is that I do not like Microsoft's tool chain assuming that it's entitled to demand that people sprinkle Microsoft-specific droppings throughout what wo

Re: [HACKERS] Random PGDLLIMPORTing

2016-11-24 Thread Craig Ringer
On 25 November 2016 at 07:36, Michael Paquier wrote: > On Thu, Nov 24, 2016 at 11:01 PM, Magnus Hagander wrote: >> On Thu, Nov 24, 2016 at 2:58 PM, Craig Ringer wrote: >> My guess is that PGDLLIMPORT has been added explicitly when somebody needed >> it for something, without any actual thought.

Re: [HACKERS] Random PGDLLIMPORTing

2016-11-24 Thread Michael Paquier
On Thu, Nov 24, 2016 at 11:01 PM, Magnus Hagander wrote: > On Thu, Nov 24, 2016 at 2:58 PM, Craig Ringer wrote: > My guess is that PGDLLIMPORT has been added explicitly when somebody needed > it for something, without any actual thought. I can't say I see any reason > not to export the other ones

Re: [HACKERS] Random PGDLLIMPORTing

2016-11-24 Thread Victor Wagner
On Thu, 24 Nov 2016 15:01:33 +0100 Magnus Hagander wrote: > On Thu, Nov 24, 2016 at 2:58 PM, Craig Ringer > wrote: > > > Hi all > > > > Noticed this while reading something unrelated > > > > extern PGDLLIMPORT pid_t PostmasterPid; > > extern bool IsPostmasterEnvironment; > > extern PGDLLIMPORT

Re: [HACKERS] Random PGDLLIMPORTing

2016-11-24 Thread Magnus Hagander
On Thu, Nov 24, 2016 at 2:58 PM, Craig Ringer wrote: > Hi all > > Noticed this while reading something unrelated > > extern PGDLLIMPORT pid_t PostmasterPid; > extern bool IsPostmasterEnvironment; > extern PGDLLIMPORT bool IsUnderPostmaster; > extern bool IsBackgroundWorker; > extern PGDLLIMPORT b

Re: [HACKERS] Random PGDLLIMPORTing

2016-11-24 Thread Magnus Hagander
On Thu, Nov 24, 2016 at 2:58 PM, Craig Ringer wrote: > Hi all > > Noticed this while reading something unrelated > > extern PGDLLIMPORT pid_t PostmasterPid; > extern bool IsPostmasterEnvironment; > extern PGDLLIMPORT bool IsUnderPostmaster; > extern bool IsBackgroundWorker; > extern PGDLLIMPORT b